Re: [PR] POC: Vectorized hashtable for aggregation [datafusion]

["Dandandan (via GitHub)" <gi...@apache.org>]

Dandandan commented on code in PR #12996:
URL: https://github.com/apache/datafusion/pull/12996#discussion_r1807821784


##########
datafusion/physical-plan/src/aggregates/group_values/column.rs:
##########
@@ -160,11 +162,112 @@ macro_rules! instantiate_primitive {
     };
 }
 
-fn append_col_value<C>(mut core: C, array: &ArrayRef, row: usize)
-where
-    C: FnMut(&ArrayRef, usize),
-{
-    core(array, row);
+struct AggregationHashTable<T: AggregationHashTableEntry> {
+    /// Raw table storing values in a `Vec`
+    raw_table: Vec<T>,

Review Comment:
   Based on some experiments in changing hash join algorithm, I think it's likely `hashbrown` performs much better than implementing a hashtable ourselves although I would like to be surprised 🙂



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org