You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/11/03 13:34:40 UTC

[GitHub] [mynewt-nimble] rymanluk commented on a change in pull request #1033: apps/bttester: implement NRPA rotation

rymanluk commented on a change in pull request #1033:
URL: https://github.com/apache/mynewt-nimble/pull/1033#discussion_r741941908



##########
File path: apps/bttester/src/gap.c
##########
@@ -248,6 +252,40 @@ static struct ble_gap_adv_params adv_params = {
 	.disc_mode = BLE_GAP_DISC_MODE_NON,
 };
 
+#if MYNEWT_VAL(BTTESTER_PRIVACY_MODE) && MYNEWT_VAL(BTTESTER_USE_NRPA)
+static void rotate_nrpa_cb(struct os_event *ev)
+{
+    assert(ev != NULL);

Review comment:
       this assert seems to be not needed. Otherwise looks good. Please remove it and feel free to merge




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org