[GitHub] [spark] EnricoMi commented on a diff in pull request #35965: [SPARK-38647][SQL] Add SupportsReportOrdering mix in interface for Scan (DataSourceV2)

[GitBox <gi...@apache.org>]

EnricoMi commented on code in PR #35965:
URL: https://github.com/apache/spark/pull/35965#discussion_r892865243


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2ScanExecBase.scala:
##########
@@ -138,6 +138,15 @@ trait DataSourceV2ScanExecBase extends LeafExecNode {
     }
   }
 
+  override def outputOrdering: Seq[SortOrder] = scan match {
+    case s: SupportsReportOrdering if this.logicalLink.isDefined &&

Review Comment:
   Awesome! Rules is where the magic happens...
   
   Integrating this into `V2ScanPartitioning` makes this so much nicer, gets rid of the awful `this.logicalLink.isDefined`.
   
   I have renamed `V2ScanPartitioning` to `V2ScanPartitioningAndOrdering`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org