You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@dubbo.apache.org by GitBox <gi...@apache.org> on 2018/04/09 08:55:19 UTC
[GitHub] codecov-io commented on issue #1573: Method extraction & Unnecessary code remove & Typo fix
codecov-io commented on issue #1573: Method extraction & Unnecessary code remove & Typo fix
URL: https://github.com/apache/incubator-dubbo/pull/1573#issuecomment-379682150
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1573?src=pr&el=h1) Report
> Merging [#1573](https://codecov.io/gh/apache/incubator-dubbo/pull/1573?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/497803c836e46ede3a91e79865eef0fe567e4ea9?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `71.87%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/1573/graphs/tree.svg?token=VnEIkiFQT0&src=pr&height=150&width=650)](https://codecov.io/gh/apache/incubator-dubbo/pull/1573?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1573 +/- ##
==========================================
+ Coverage 32.17% 32.19% +0.02%
==========================================
Files 682 682
Lines 32972 32977 +5
Branches 6597 6598 +1
==========================================
+ Hits 10608 10617 +9
+ Misses 20468 20467 -1
+ Partials 1896 1893 -3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1573?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...libaba/dubbo/common/extension/ExtensionLoader.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1573/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL2V4dGVuc2lvbi9FeHRlbnNpb25Mb2FkZXIuamF2YQ==) | `71.69% <71.87%> (+0.7%)` | :arrow_up: |
| [...libaba/com/caucho/hessian/util/IdentityIntMap.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1573/diff?src=pr&el=tree#diff-aGVzc2lhbi1saXRlL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvY29tL2NhdWNoby9oZXNzaWFuL3V0aWwvSWRlbnRpdHlJbnRNYXAuamF2YQ==) | `25% <0%> (-5.96%)` | :arrow_down: |
| [...bo/remoting/transport/netty/NettyCodecAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1573/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDb2RlY0FkYXB0ZXIuamF2YQ==) | `55.22% <0%> (-1.5%)` | :arrow_down: |
| [.../alibaba/dubbo/config/AbstractInterfaceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1573/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvQWJzdHJhY3RJbnRlcmZhY2VDb25maWcuamF2YQ==) | `38% <0%> (-0.46%)` | :arrow_down: |
| [.../dubbo/rpc/protocol/dubbo/filter/FutureFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1573/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9maWx0ZXIvRnV0dXJlRmlsdGVyLmphdmE=) | `56.56% <0%> (+2.02%)` | :arrow_up: |
| [...a/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1573/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDaGFubmVsLmphdmE=) | `66.25% <0%> (+8.75%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1573?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1573?src=pr&el=footer). Last update [497803c...bb3eb3a](https://codecov.io/gh/apache/incubator-dubbo/pull/1573?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services