You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by dkuppitz <gi...@git.apache.org> on 2017/07/27 16:16:48 UTC

[GitHub] tinkerpop pull request #683: TINKERPOP-1736 Sack step evaluated by groovy in...

GitHub user dkuppitz opened a pull request:

    https://github.com/apache/tinkerpop/pull/683

    TINKERPOP-1736 Sack step evaluated by groovy interprets numbers in an unexpected way

    Follow-up on #682. This PR fixes the test case that failed in `master/`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1736

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/683.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #683
    
----
commit 3d8c03bb2c3cdd09a44e8b163d62db6d18773490
Author: Daniel Kuppitz <da...@hotmail.com>
Date:   2017-07-27T16:07:25Z

    Fixed test case that ultimately failed in `master/` (coerced `BigDecimal` to `Double`).

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop pull request #683: TINKERPOP-1736 Sack step evaluated by groovy in...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/tinkerpop/pull/683


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #683: TINKERPOP-1736 Sack step evaluated by groovy interpret...

Posted by twilmes <gi...@git.apache.org>.
Github user twilmes commented on the issue:

    https://github.com/apache/tinkerpop/pull/683
  
    VOTE: +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #683: TINKERPOP-1736 Sack step evaluated by groovy interpret...

Posted by okram <gi...@git.apache.org>.
Github user okram commented on the issue:

    https://github.com/apache/tinkerpop/pull/683
  
    VOTE +1 (got rid of BigDecimal typing -- good).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---