You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hive.apache.org by pengcheng xiong <px...@hortonworks.com> on 2016/01/21 08:46:27 UTC

Re: Review Request 41807: further improve user level explain

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41807/
-----------------------------------------------------------

(Updated Jan. 21, 2016, 7:46 a.m.)


Review request for hive and John Pullokkaran.


Repository: hive-git


Description
-------

HIVE-12709


Diffs (updated)
-----

  common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Attr.java 5d355d2 
  common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Op.java d0c1037 
  common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Stage.java 455d59f 
  common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/TezJsonParser.java b193fef 
  common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/TezJsonParserUtils.java PRE-CREATION 
  common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Vertex.java be01b8b 
  ql/src/java/org/apache/hadoop/hive/ql/exec/ExplainTask.java f48db6a 
  ql/src/java/org/apache/hadoop/hive/ql/plan/AbstractOperatorDesc.java bc67e5a 
  ql/src/java/org/apache/hadoop/hive/ql/plan/BaseWork.java ad34b98 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java 3f38f74 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableLikeDesc.java f051712 
  ql/src/java/org/apache/hadoop/hive/ql/plan/FileSinkDesc.java 40a8477 
  ql/src/java/org/apache/hadoop/hive/ql/plan/FilterDesc.java d04cb78 
  ql/src/java/org/apache/hadoop/hive/ql/plan/GroupByDesc.java 0f2855e 
  ql/src/java/org/apache/hadoop/hive/ql/plan/HashTableSinkDesc.java 7c8eee2 
  ql/src/java/org/apache/hadoop/hive/ql/plan/JoinDesc.java eb83fd6 
  ql/src/java/org/apache/hadoop/hive/ql/plan/LateralViewJoinDesc.java 12f01e5 
  ql/src/java/org/apache/hadoop/hive/ql/plan/LoadTableDesc.java 427aac1 
  ql/src/java/org/apache/hadoop/hive/ql/plan/MapJoinDesc.java 4b93e7c 
  ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java 5bea6fb 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ReduceSinkDesc.java 2f69b7f 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ReduceWork.java 1c31962 
  ql/src/java/org/apache/hadoop/hive/ql/plan/SelectDesc.java e7bbab4 
  ql/src/java/org/apache/hadoop/hive/ql/plan/Statistics.java 4e52bac 
  ql/src/java/org/apache/hadoop/hive/ql/plan/TableDesc.java 2fdb0a1 
  ql/src/java/org/apache/hadoop/hive/ql/plan/TableScanDesc.java 098aa89 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ptf/PTFQueryInputDef.java ae55741 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ptf/PartitionedTableFunctionDef.java 46f106c 
  ql/src/test/queries/clientpositive/explainuser_4.q PRE-CREATION 
  ql/src/test/results/clientpositive/perf/query12.q.out 648d64d 
  ql/src/test/results/clientpositive/perf/query13.q.out 6113d18 
  ql/src/test/results/clientpositive/perf/query15.q.out c237828 
  ql/src/test/results/clientpositive/perf/query17.q.out 0e42d05 
  ql/src/test/results/clientpositive/perf/query18.q.out 83f21dc 
  ql/src/test/results/clientpositive/perf/query19.q.out d565839 
  ql/src/test/results/clientpositive/perf/query20.q.out 40c9a17 
  ql/src/test/results/clientpositive/perf/query21.q.out 2634d3d 
  ql/src/test/results/clientpositive/perf/query22.q.out 72935ed 
  ql/src/test/results/clientpositive/perf/query25.q.out dabc1c5 
  ql/src/test/results/clientpositive/perf/query26.q.out 84cc238 
  ql/src/test/results/clientpositive/perf/query27.q.out ac38683 
  ql/src/test/results/clientpositive/perf/query28.q.out cac9ac3 
  ql/src/test/results/clientpositive/perf/query29.q.out 8991f35 
  ql/src/test/results/clientpositive/perf/query3.q.out 871ad74 
  ql/src/test/results/clientpositive/perf/query31.q.out 909d64c 
  ql/src/test/results/clientpositive/perf/query32.q.out da2ac8f 
  ql/src/test/results/clientpositive/perf/query34.q.out 1cb7c28 
  ql/src/test/results/clientpositive/perf/query39.q.out 9f3e650 
  ql/src/test/results/clientpositive/perf/query40.q.out b2d6262 
  ql/src/test/results/clientpositive/perf/query42.q.out 9ede45d 
  ql/src/test/results/clientpositive/perf/query43.q.out 7fa4f53 
  ql/src/test/results/clientpositive/perf/query45.q.out f55f20c 
  ql/src/test/results/clientpositive/perf/query46.q.out 0ded912 
  ql/src/test/results/clientpositive/perf/query48.q.out 40b76f0 
  ql/src/test/results/clientpositive/perf/query50.q.out 8b41d05 
  ql/src/test/results/clientpositive/perf/query51.q.out f57af2c 
  ql/src/test/results/clientpositive/perf/query52.q.out 7e7224b 
  ql/src/test/results/clientpositive/perf/query54.q.out 56c70b7 
  ql/src/test/results/clientpositive/perf/query55.q.out d36f378 
  ql/src/test/results/clientpositive/perf/query58.q.out c2f7189 
  ql/src/test/results/clientpositive/perf/query64.q.out 9331673 
  ql/src/test/results/clientpositive/perf/query65.q.out 12bdd33 
  ql/src/test/results/clientpositive/perf/query66.q.out a25664e 
  ql/src/test/results/clientpositive/perf/query67.q.out dda5347 
  ql/src/test/results/clientpositive/perf/query68.q.out 8ecde89 
  ql/src/test/results/clientpositive/perf/query7.q.out a463a8b 
  ql/src/test/results/clientpositive/perf/query70.q.out d13165d 
  ql/src/test/results/clientpositive/perf/query71.q.out fa50e56 
  ql/src/test/results/clientpositive/perf/query72.q.out bb56f0d 
  ql/src/test/results/clientpositive/perf/query73.q.out 9c88854 
  ql/src/test/results/clientpositive/perf/query75.q.out f3f9827 
  ql/src/test/results/clientpositive/perf/query76.q.out e540ee7 
  ql/src/test/results/clientpositive/perf/query79.q.out a0d5a51 
  ql/src/test/results/clientpositive/perf/query80.q.out 37cb542 
  ql/src/test/results/clientpositive/perf/query82.q.out 654a772 
  ql/src/test/results/clientpositive/perf/query84.q.out e522f23 
  ql/src/test/results/clientpositive/perf/query85.q.out 54061ce 
  ql/src/test/results/clientpositive/perf/query87.q.out a336189 
  ql/src/test/results/clientpositive/perf/query88.q.out f139dd1 
  ql/src/test/results/clientpositive/perf/query89.q.out ee9eabc 
  ql/src/test/results/clientpositive/perf/query90.q.out d34aaf4 
  ql/src/test/results/clientpositive/perf/query91.q.out 54f58e4 
  ql/src/test/results/clientpositive/perf/query92.q.out 6fb2133 
  ql/src/test/results/clientpositive/perf/query93.q.out 5255145 
  ql/src/test/results/clientpositive/perf/query94.q.out 0357835 
  ql/src/test/results/clientpositive/perf/query95.q.out a7c6a98 
  ql/src/test/results/clientpositive/perf/query96.q.out bba8965 
  ql/src/test/results/clientpositive/perf/query97.q.out c4c384d 
  ql/src/test/results/clientpositive/perf/query98.q.out baff7e0 
  ql/src/test/results/clientpositive/tez/explainuser_1.q.out 8c78fd9 
  ql/src/test/results/clientpositive/tez/explainuser_2.q.out eb7d564 
  ql/src/test/results/clientpositive/tez/explainuser_3.q.out e2db163 
  ql/src/test/results/clientpositive/tez/explainuser_4.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/41807/diff/


Testing
-------


Thanks,

pengcheng xiong

Re: Review Request 41807: further improve user level explain

Posted by John Pullokkaran <jp...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41807/#review116548
-----------------------------------------------------------




ql/src/test/results/clientpositive/perf/query12.q.out (line 47)
<https://reviews.apache.org/r/41807/#comment177571>

    Could we write keys as expression
    i.e instead of keys
    RS_9:_col0=RS_11:d_date_sk


- John Pullokkaran


On Jan. 21, 2016, 7:46 a.m., pengcheng xiong wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41807/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2016, 7:46 a.m.)
> 
> 
> Review request for hive and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-12709
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Attr.java 5d355d2 
>   common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Op.java d0c1037 
>   common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Stage.java 455d59f 
>   common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/TezJsonParser.java b193fef 
>   common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/TezJsonParserUtils.java PRE-CREATION 
>   common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Vertex.java be01b8b 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/ExplainTask.java f48db6a 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/AbstractOperatorDesc.java bc67e5a 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/BaseWork.java ad34b98 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java 3f38f74 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableLikeDesc.java f051712 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/FileSinkDesc.java 40a8477 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/FilterDesc.java d04cb78 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/GroupByDesc.java 0f2855e 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/HashTableSinkDesc.java 7c8eee2 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/JoinDesc.java eb83fd6 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/LateralViewJoinDesc.java 12f01e5 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/LoadTableDesc.java 427aac1 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/MapJoinDesc.java 4b93e7c 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java 5bea6fb 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/ReduceSinkDesc.java 2f69b7f 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/ReduceWork.java 1c31962 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/SelectDesc.java e7bbab4 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/Statistics.java 4e52bac 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/TableDesc.java 2fdb0a1 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/TableScanDesc.java 098aa89 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/ptf/PTFQueryInputDef.java ae55741 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/ptf/PartitionedTableFunctionDef.java 46f106c 
>   ql/src/test/queries/clientpositive/explainuser_4.q PRE-CREATION 
>   ql/src/test/results/clientpositive/perf/query12.q.out 648d64d 
>   ql/src/test/results/clientpositive/perf/query13.q.out 6113d18 
>   ql/src/test/results/clientpositive/perf/query15.q.out c237828 
>   ql/src/test/results/clientpositive/perf/query17.q.out 0e42d05 
>   ql/src/test/results/clientpositive/perf/query18.q.out 83f21dc 
>   ql/src/test/results/clientpositive/perf/query19.q.out d565839 
>   ql/src/test/results/clientpositive/perf/query20.q.out 40c9a17 
>   ql/src/test/results/clientpositive/perf/query21.q.out 2634d3d 
>   ql/src/test/results/clientpositive/perf/query22.q.out 72935ed 
>   ql/src/test/results/clientpositive/perf/query25.q.out dabc1c5 
>   ql/src/test/results/clientpositive/perf/query26.q.out 84cc238 
>   ql/src/test/results/clientpositive/perf/query27.q.out ac38683 
>   ql/src/test/results/clientpositive/perf/query28.q.out cac9ac3 
>   ql/src/test/results/clientpositive/perf/query29.q.out 8991f35 
>   ql/src/test/results/clientpositive/perf/query3.q.out 871ad74 
>   ql/src/test/results/clientpositive/perf/query31.q.out 909d64c 
>   ql/src/test/results/clientpositive/perf/query32.q.out da2ac8f 
>   ql/src/test/results/clientpositive/perf/query34.q.out 1cb7c28 
>   ql/src/test/results/clientpositive/perf/query39.q.out 9f3e650 
>   ql/src/test/results/clientpositive/perf/query40.q.out b2d6262 
>   ql/src/test/results/clientpositive/perf/query42.q.out 9ede45d 
>   ql/src/test/results/clientpositive/perf/query43.q.out 7fa4f53 
>   ql/src/test/results/clientpositive/perf/query45.q.out f55f20c 
>   ql/src/test/results/clientpositive/perf/query46.q.out 0ded912 
>   ql/src/test/results/clientpositive/perf/query48.q.out 40b76f0 
>   ql/src/test/results/clientpositive/perf/query50.q.out 8b41d05 
>   ql/src/test/results/clientpositive/perf/query51.q.out f57af2c 
>   ql/src/test/results/clientpositive/perf/query52.q.out 7e7224b 
>   ql/src/test/results/clientpositive/perf/query54.q.out 56c70b7 
>   ql/src/test/results/clientpositive/perf/query55.q.out d36f378 
>   ql/src/test/results/clientpositive/perf/query58.q.out c2f7189 
>   ql/src/test/results/clientpositive/perf/query64.q.out 9331673 
>   ql/src/test/results/clientpositive/perf/query65.q.out 12bdd33 
>   ql/src/test/results/clientpositive/perf/query66.q.out a25664e 
>   ql/src/test/results/clientpositive/perf/query67.q.out dda5347 
>   ql/src/test/results/clientpositive/perf/query68.q.out 8ecde89 
>   ql/src/test/results/clientpositive/perf/query7.q.out a463a8b 
>   ql/src/test/results/clientpositive/perf/query70.q.out d13165d 
>   ql/src/test/results/clientpositive/perf/query71.q.out fa50e56 
>   ql/src/test/results/clientpositive/perf/query72.q.out bb56f0d 
>   ql/src/test/results/clientpositive/perf/query73.q.out 9c88854 
>   ql/src/test/results/clientpositive/perf/query75.q.out f3f9827 
>   ql/src/test/results/clientpositive/perf/query76.q.out e540ee7 
>   ql/src/test/results/clientpositive/perf/query79.q.out a0d5a51 
>   ql/src/test/results/clientpositive/perf/query80.q.out 37cb542 
>   ql/src/test/results/clientpositive/perf/query82.q.out 654a772 
>   ql/src/test/results/clientpositive/perf/query84.q.out e522f23 
>   ql/src/test/results/clientpositive/perf/query85.q.out 54061ce 
>   ql/src/test/results/clientpositive/perf/query87.q.out a336189 
>   ql/src/test/results/clientpositive/perf/query88.q.out f139dd1 
>   ql/src/test/results/clientpositive/perf/query89.q.out ee9eabc 
>   ql/src/test/results/clientpositive/perf/query90.q.out d34aaf4 
>   ql/src/test/results/clientpositive/perf/query91.q.out 54f58e4 
>   ql/src/test/results/clientpositive/perf/query92.q.out 6fb2133 
>   ql/src/test/results/clientpositive/perf/query93.q.out 5255145 
>   ql/src/test/results/clientpositive/perf/query94.q.out 0357835 
>   ql/src/test/results/clientpositive/perf/query95.q.out a7c6a98 
>   ql/src/test/results/clientpositive/perf/query96.q.out bba8965 
>   ql/src/test/results/clientpositive/perf/query97.q.out c4c384d 
>   ql/src/test/results/clientpositive/perf/query98.q.out baff7e0 
>   ql/src/test/results/clientpositive/tez/explainuser_1.q.out 8c78fd9 
>   ql/src/test/results/clientpositive/tez/explainuser_2.q.out eb7d564 
>   ql/src/test/results/clientpositive/tez/explainuser_3.q.out e2db163 
>   ql/src/test/results/clientpositive/tez/explainuser_4.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41807/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengcheng xiong
> 
>

Re: Review Request 41807: further improve user level explain

Posted by John Pullokkaran <jp...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41807/#review116546
-----------------------------------------------------------




ql/src/test/results/clientpositive/perf/query90.q.out (line 100)
<https://reviews.apache.org/r/41807/#comment177570>

    We are missing info on join type: inner vs outer


- John Pullokkaran


On Jan. 21, 2016, 7:46 a.m., pengcheng xiong wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41807/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2016, 7:46 a.m.)
> 
> 
> Review request for hive and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-12709
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Attr.java 5d355d2 
>   common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Op.java d0c1037 
>   common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Stage.java 455d59f 
>   common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/TezJsonParser.java b193fef 
>   common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/TezJsonParserUtils.java PRE-CREATION 
>   common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Vertex.java be01b8b 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/ExplainTask.java f48db6a 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/AbstractOperatorDesc.java bc67e5a 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/BaseWork.java ad34b98 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java 3f38f74 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableLikeDesc.java f051712 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/FileSinkDesc.java 40a8477 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/FilterDesc.java d04cb78 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/GroupByDesc.java 0f2855e 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/HashTableSinkDesc.java 7c8eee2 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/JoinDesc.java eb83fd6 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/LateralViewJoinDesc.java 12f01e5 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/LoadTableDesc.java 427aac1 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/MapJoinDesc.java 4b93e7c 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java 5bea6fb 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/ReduceSinkDesc.java 2f69b7f 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/ReduceWork.java 1c31962 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/SelectDesc.java e7bbab4 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/Statistics.java 4e52bac 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/TableDesc.java 2fdb0a1 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/TableScanDesc.java 098aa89 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/ptf/PTFQueryInputDef.java ae55741 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/ptf/PartitionedTableFunctionDef.java 46f106c 
>   ql/src/test/queries/clientpositive/explainuser_4.q PRE-CREATION 
>   ql/src/test/results/clientpositive/perf/query12.q.out 648d64d 
>   ql/src/test/results/clientpositive/perf/query13.q.out 6113d18 
>   ql/src/test/results/clientpositive/perf/query15.q.out c237828 
>   ql/src/test/results/clientpositive/perf/query17.q.out 0e42d05 
>   ql/src/test/results/clientpositive/perf/query18.q.out 83f21dc 
>   ql/src/test/results/clientpositive/perf/query19.q.out d565839 
>   ql/src/test/results/clientpositive/perf/query20.q.out 40c9a17 
>   ql/src/test/results/clientpositive/perf/query21.q.out 2634d3d 
>   ql/src/test/results/clientpositive/perf/query22.q.out 72935ed 
>   ql/src/test/results/clientpositive/perf/query25.q.out dabc1c5 
>   ql/src/test/results/clientpositive/perf/query26.q.out 84cc238 
>   ql/src/test/results/clientpositive/perf/query27.q.out ac38683 
>   ql/src/test/results/clientpositive/perf/query28.q.out cac9ac3 
>   ql/src/test/results/clientpositive/perf/query29.q.out 8991f35 
>   ql/src/test/results/clientpositive/perf/query3.q.out 871ad74 
>   ql/src/test/results/clientpositive/perf/query31.q.out 909d64c 
>   ql/src/test/results/clientpositive/perf/query32.q.out da2ac8f 
>   ql/src/test/results/clientpositive/perf/query34.q.out 1cb7c28 
>   ql/src/test/results/clientpositive/perf/query39.q.out 9f3e650 
>   ql/src/test/results/clientpositive/perf/query40.q.out b2d6262 
>   ql/src/test/results/clientpositive/perf/query42.q.out 9ede45d 
>   ql/src/test/results/clientpositive/perf/query43.q.out 7fa4f53 
>   ql/src/test/results/clientpositive/perf/query45.q.out f55f20c 
>   ql/src/test/results/clientpositive/perf/query46.q.out 0ded912 
>   ql/src/test/results/clientpositive/perf/query48.q.out 40b76f0 
>   ql/src/test/results/clientpositive/perf/query50.q.out 8b41d05 
>   ql/src/test/results/clientpositive/perf/query51.q.out f57af2c 
>   ql/src/test/results/clientpositive/perf/query52.q.out 7e7224b 
>   ql/src/test/results/clientpositive/perf/query54.q.out 56c70b7 
>   ql/src/test/results/clientpositive/perf/query55.q.out d36f378 
>   ql/src/test/results/clientpositive/perf/query58.q.out c2f7189 
>   ql/src/test/results/clientpositive/perf/query64.q.out 9331673 
>   ql/src/test/results/clientpositive/perf/query65.q.out 12bdd33 
>   ql/src/test/results/clientpositive/perf/query66.q.out a25664e 
>   ql/src/test/results/clientpositive/perf/query67.q.out dda5347 
>   ql/src/test/results/clientpositive/perf/query68.q.out 8ecde89 
>   ql/src/test/results/clientpositive/perf/query7.q.out a463a8b 
>   ql/src/test/results/clientpositive/perf/query70.q.out d13165d 
>   ql/src/test/results/clientpositive/perf/query71.q.out fa50e56 
>   ql/src/test/results/clientpositive/perf/query72.q.out bb56f0d 
>   ql/src/test/results/clientpositive/perf/query73.q.out 9c88854 
>   ql/src/test/results/clientpositive/perf/query75.q.out f3f9827 
>   ql/src/test/results/clientpositive/perf/query76.q.out e540ee7 
>   ql/src/test/results/clientpositive/perf/query79.q.out a0d5a51 
>   ql/src/test/results/clientpositive/perf/query80.q.out 37cb542 
>   ql/src/test/results/clientpositive/perf/query82.q.out 654a772 
>   ql/src/test/results/clientpositive/perf/query84.q.out e522f23 
>   ql/src/test/results/clientpositive/perf/query85.q.out 54061ce 
>   ql/src/test/results/clientpositive/perf/query87.q.out a336189 
>   ql/src/test/results/clientpositive/perf/query88.q.out f139dd1 
>   ql/src/test/results/clientpositive/perf/query89.q.out ee9eabc 
>   ql/src/test/results/clientpositive/perf/query90.q.out d34aaf4 
>   ql/src/test/results/clientpositive/perf/query91.q.out 54f58e4 
>   ql/src/test/results/clientpositive/perf/query92.q.out 6fb2133 
>   ql/src/test/results/clientpositive/perf/query93.q.out 5255145 
>   ql/src/test/results/clientpositive/perf/query94.q.out 0357835 
>   ql/src/test/results/clientpositive/perf/query95.q.out a7c6a98 
>   ql/src/test/results/clientpositive/perf/query96.q.out bba8965 
>   ql/src/test/results/clientpositive/perf/query97.q.out c4c384d 
>   ql/src/test/results/clientpositive/perf/query98.q.out baff7e0 
>   ql/src/test/results/clientpositive/tez/explainuser_1.q.out 8c78fd9 
>   ql/src/test/results/clientpositive/tez/explainuser_2.q.out eb7d564 
>   ql/src/test/results/clientpositive/tez/explainuser_3.q.out e2db163 
>   ql/src/test/results/clientpositive/tez/explainuser_4.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41807/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengcheng xiong
> 
>

Re: Review Request 41807: further improve user level explain

Posted by John Pullokkaran <jp...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41807/#review116704
-----------------------------------------------------------


Ship it!




Ship It!

- John Pullokkaran


On Jan. 21, 2016, 7:46 a.m., pengcheng xiong wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41807/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2016, 7:46 a.m.)
> 
> 
> Review request for hive and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-12709
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Attr.java 5d355d2 
>   common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Op.java d0c1037 
>   common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Stage.java 455d59f 
>   common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/TezJsonParser.java b193fef 
>   common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/TezJsonParserUtils.java PRE-CREATION 
>   common/src/java/org/apache/hadoop/hive/common/jsonexplain/tez/Vertex.java be01b8b 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/ExplainTask.java f48db6a 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/AbstractOperatorDesc.java bc67e5a 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/BaseWork.java ad34b98 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java 3f38f74 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableLikeDesc.java f051712 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/FileSinkDesc.java 40a8477 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/FilterDesc.java d04cb78 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/GroupByDesc.java 0f2855e 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/HashTableSinkDesc.java 7c8eee2 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/JoinDesc.java eb83fd6 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/LateralViewJoinDesc.java 12f01e5 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/LoadTableDesc.java 427aac1 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/MapJoinDesc.java 4b93e7c 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java 5bea6fb 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/ReduceSinkDesc.java 2f69b7f 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/ReduceWork.java 1c31962 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/SelectDesc.java e7bbab4 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/Statistics.java 4e52bac 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/TableDesc.java 2fdb0a1 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/TableScanDesc.java 098aa89 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/ptf/PTFQueryInputDef.java ae55741 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/ptf/PartitionedTableFunctionDef.java 46f106c 
>   ql/src/test/queries/clientpositive/explainuser_4.q PRE-CREATION 
>   ql/src/test/results/clientpositive/perf/query12.q.out 648d64d 
>   ql/src/test/results/clientpositive/perf/query13.q.out 6113d18 
>   ql/src/test/results/clientpositive/perf/query15.q.out c237828 
>   ql/src/test/results/clientpositive/perf/query17.q.out 0e42d05 
>   ql/src/test/results/clientpositive/perf/query18.q.out 83f21dc 
>   ql/src/test/results/clientpositive/perf/query19.q.out d565839 
>   ql/src/test/results/clientpositive/perf/query20.q.out 40c9a17 
>   ql/src/test/results/clientpositive/perf/query21.q.out 2634d3d 
>   ql/src/test/results/clientpositive/perf/query22.q.out 72935ed 
>   ql/src/test/results/clientpositive/perf/query25.q.out dabc1c5 
>   ql/src/test/results/clientpositive/perf/query26.q.out 84cc238 
>   ql/src/test/results/clientpositive/perf/query27.q.out ac38683 
>   ql/src/test/results/clientpositive/perf/query28.q.out cac9ac3 
>   ql/src/test/results/clientpositive/perf/query29.q.out 8991f35 
>   ql/src/test/results/clientpositive/perf/query3.q.out 871ad74 
>   ql/src/test/results/clientpositive/perf/query31.q.out 909d64c 
>   ql/src/test/results/clientpositive/perf/query32.q.out da2ac8f 
>   ql/src/test/results/clientpositive/perf/query34.q.out 1cb7c28 
>   ql/src/test/results/clientpositive/perf/query39.q.out 9f3e650 
>   ql/src/test/results/clientpositive/perf/query40.q.out b2d6262 
>   ql/src/test/results/clientpositive/perf/query42.q.out 9ede45d 
>   ql/src/test/results/clientpositive/perf/query43.q.out 7fa4f53 
>   ql/src/test/results/clientpositive/perf/query45.q.out f55f20c 
>   ql/src/test/results/clientpositive/perf/query46.q.out 0ded912 
>   ql/src/test/results/clientpositive/perf/query48.q.out 40b76f0 
>   ql/src/test/results/clientpositive/perf/query50.q.out 8b41d05 
>   ql/src/test/results/clientpositive/perf/query51.q.out f57af2c 
>   ql/src/test/results/clientpositive/perf/query52.q.out 7e7224b 
>   ql/src/test/results/clientpositive/perf/query54.q.out 56c70b7 
>   ql/src/test/results/clientpositive/perf/query55.q.out d36f378 
>   ql/src/test/results/clientpositive/perf/query58.q.out c2f7189 
>   ql/src/test/results/clientpositive/perf/query64.q.out 9331673 
>   ql/src/test/results/clientpositive/perf/query65.q.out 12bdd33 
>   ql/src/test/results/clientpositive/perf/query66.q.out a25664e 
>   ql/src/test/results/clientpositive/perf/query67.q.out dda5347 
>   ql/src/test/results/clientpositive/perf/query68.q.out 8ecde89 
>   ql/src/test/results/clientpositive/perf/query7.q.out a463a8b 
>   ql/src/test/results/clientpositive/perf/query70.q.out d13165d 
>   ql/src/test/results/clientpositive/perf/query71.q.out fa50e56 
>   ql/src/test/results/clientpositive/perf/query72.q.out bb56f0d 
>   ql/src/test/results/clientpositive/perf/query73.q.out 9c88854 
>   ql/src/test/results/clientpositive/perf/query75.q.out f3f9827 
>   ql/src/test/results/clientpositive/perf/query76.q.out e540ee7 
>   ql/src/test/results/clientpositive/perf/query79.q.out a0d5a51 
>   ql/src/test/results/clientpositive/perf/query80.q.out 37cb542 
>   ql/src/test/results/clientpositive/perf/query82.q.out 654a772 
>   ql/src/test/results/clientpositive/perf/query84.q.out e522f23 
>   ql/src/test/results/clientpositive/perf/query85.q.out 54061ce 
>   ql/src/test/results/clientpositive/perf/query87.q.out a336189 
>   ql/src/test/results/clientpositive/perf/query88.q.out f139dd1 
>   ql/src/test/results/clientpositive/perf/query89.q.out ee9eabc 
>   ql/src/test/results/clientpositive/perf/query90.q.out d34aaf4 
>   ql/src/test/results/clientpositive/perf/query91.q.out 54f58e4 
>   ql/src/test/results/clientpositive/perf/query92.q.out 6fb2133 
>   ql/src/test/results/clientpositive/perf/query93.q.out 5255145 
>   ql/src/test/results/clientpositive/perf/query94.q.out 0357835 
>   ql/src/test/results/clientpositive/perf/query95.q.out a7c6a98 
>   ql/src/test/results/clientpositive/perf/query96.q.out bba8965 
>   ql/src/test/results/clientpositive/perf/query97.q.out c4c384d 
>   ql/src/test/results/clientpositive/perf/query98.q.out baff7e0 
>   ql/src/test/results/clientpositive/tez/explainuser_1.q.out 8c78fd9 
>   ql/src/test/results/clientpositive/tez/explainuser_2.q.out eb7d564 
>   ql/src/test/results/clientpositive/tez/explainuser_3.q.out e2db163 
>   ql/src/test/results/clientpositive/tez/explainuser_4.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41807/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengcheng xiong
> 
>