You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by Rucongzhang <gi...@git.apache.org> on 2015/08/15 11:53:27 UTC
[GitHub] flink pull request: [FLINK-2478]fix the array may have out of boun...
GitHub user Rucongzhang opened a pull request:
https://github.com/apache/flink/pull/1021
[FLINK-2478]fix the array may have out of bounds
In getNestedDelta function, the array length of oldDatapoint and the array length of newDatapoint are not been ensured same.So add the judgement.And I fixed the problem. Please put this problem to master branch. Thank you.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Rucongzhang/flink FLINK-2487
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1021.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1021
----
commit e68c86f4ce8ae2d1e2bac8ab432fc93b5f52f756
Author: Rucongzhang <zh...@huawei.com>
Date: 2015-08-15T09:25:25Z
[FLINK-2478]fix the array may have out of bounds
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2478]fix the array may have out of boun...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1021
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2478]fix the array may have out of boun...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1021#issuecomment-131402990
If the two arrays are of different lengths, should this throw an exception? After all, the cosine distance is not well defined then and returning 0 may give the impression that things are correct, when they are not.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2478]fix the array may have out of boun...
Posted by Rucongzhang <gi...@git.apache.org>.
Github user Rucongzhang commented on the pull request:
https://github.com/apache/flink/pull/1021#issuecomment-131493503
Yes,stephan it should throw an exception.I will modify .Thank you very much!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---