You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Abhay Kulkarni <ak...@hortonworks.com> on 2019/01/29 20:12:32 UTC
Review Request 69856: RANGER-2328: Time-based policies do not work
correctly if access time is not set in the authorization request
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69856/
-----------------------------------------------------------
Review request for ranger, Madhan Neethiraj, Ramesh Mani, and Velmurugan Periasamy.
Bugs: RANGER-2328
https://issues.apache.org/jira/browse/RANGER-2328
Repository: ranger
Description
-------
Access authorization decision depends on the time of the access (which is retrieved from the authorization request) when evaluating Time-based policies. If access time is not set in the authorization request, current time should be used for evaluating access request.
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerScriptExecutionContext.java c3ed240ac
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java f8ca67e00
Diff: https://reviews.apache.org/r/69856/diff/1/
Testing
-------
Tested with local VM
Thanks,
Abhay Kulkarni
Re: Review Request 69856: RANGER-2328: Time-based policies do not work
correctly if access time is not set in the authorization request
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69856/#review212422
-----------------------------------------------------------
Ship it!
Ship It!
- Ramesh Mani
On Jan. 29, 2019, 8:12 p.m., Abhay Kulkarni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69856/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2019, 8:12 p.m.)
>
>
> Review request for ranger, Madhan Neethiraj, Ramesh Mani, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2328
> https://issues.apache.org/jira/browse/RANGER-2328
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Access authorization decision depends on the time of the access (which is retrieved from the authorization request) when evaluating Time-based policies. If access time is not set in the authorization request, current time should be used for evaluating access request.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerScriptExecutionContext.java c3ed240ac
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java f8ca67e00
>
>
> Diff: https://reviews.apache.org/r/69856/diff/1/
>
>
> Testing
> -------
>
> Tested with local VM
>
>
> Thanks,
>
> Abhay Kulkarni
>
>