[GitHub] [logging-log4j2] rgoers commented on a change in pull request #480: Master java11

[GitBox <gi...@apache.org>]

rgoers commented on a change in pull request #480:
URL: https://github.com/apache/logging-log4j2/pull/480#discussion_r603718254



##########
File path: log4j-core/src/main/java/org/apache/logging/log4j/core/time/internal/SystemClock.java
##########
@@ -16,13 +16,19 @@
  */
 package org.apache.logging.log4j.core.time.internal;
 
+import java.time.Instant;
+
 import org.apache.logging.log4j.core.time.Clock;
+import org.apache.logging.log4j.core.time.MutableInstant;
+import org.apache.logging.log4j.core.time.PreciseClock;
 
 /**
  * Implementation of the {@code Clock} interface that returns the system time.
+ * @since 2.11.0
  */
+// Precise clock is not implemented because the instant() method in the init method is not garbage free.

Review comment:
       I agree. If it is possible to detect that we are not in "garbage free mode" then we could go ahead with the init method. I admittedly took a shortcut has I spent nearly a week getting this done and I didn't want to solve every problem in Log4j.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org