[GitHub] [solr] joshgog commented on a diff in pull request #1218: SOLR-16573:SolrClientTestRule for EmbeddedSolrServer

["joshgog (via GitHub)" <gi...@apache.org>]

joshgog commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1087414035


##########
solr/core/src/test/org/apache/solr/update/RootFieldTest.java:
##########
@@ -54,7 +54,7 @@ public static void beforeTest() throws Exception {
     solrClientTestRule.startSolr(Path.of(SolrTestCaseJ4.TEST_HOME()));
 
     solrClientTestRule
-        .newCollection(DEFAULT_TEST_COLLECTION_NAME)

Review Comment:
   That was a misunderstanding. We aren't going away from using going away from using `DEFAULT_TEST_COLLECTION_NAME`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org