You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/08/31 17:43:17 UTC
[GitHub] [beam] damccorm opened a new pull request, #22977: Run cred rotation every month
damccorm opened a new pull request, #22977:
URL: https://github.com/apache/beam/pull/22977
Jenkins recently went down for a while because our creds expired. Running the IODatastores rotation job fixed it. Given that its relatively cheap, we should probably run that job every month so that we're not cutting it close on expirations. I could actually be convinced that running it even more frequently is a good idea.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #22977: Run cred rotation every month
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #22977:
URL: https://github.com/apache/beam/pull/22977#issuecomment-1233362067
R: @Abacn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22977: Run cred rotation every month
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22977:
URL: https://github.com/apache/beam/pull/22977#issuecomment-1233363170
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #22977: Run cred rotation every month
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #22977:
URL: https://github.com/apache/beam/pull/22977#issuecomment-1233396482
It ran for the first time a little less than 2 months ago, but the creds expired before the second run. Had there been a run in between we would've most likely avoided the problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #22977: Run cred rotation every month
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #22977:
URL: https://github.com/apache/beam/pull/22977#issuecomment-1233236279
@eilnk21 are there any reasons that you know of not to run this more frequently? (asking since you added this in https://github.com/apache/beam/pull/17383)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #22977: Run cred rotation every month
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #22977:
URL: https://github.com/apache/beam/pull/22977#issuecomment-1233368401
Thanks. Is the original every other month setting never working?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #22977: Run cred rotation every month
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #22977:
URL: https://github.com/apache/beam/pull/22977#issuecomment-1233304328
@elink21 are there any reasons that you know of not to run this more frequently? (asking since you added this in https://github.com/apache/beam/pull/17383)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] elink21 commented on pull request #22977: Run cred rotation every month
Posted by GitBox <gi...@apache.org>.
elink21 commented on PR #22977:
URL: https://github.com/apache/beam/pull/22977#issuecomment-1233356404
> @elink21 are there any reasons that you know of not to run this more frequently? (asking since you added this in #17383)
The initial bi-monthly frequency was proposed given the credentials lifetime reported by this [command](https://cloud.google.com/kubernetes-engine/docs/how-to/credential-rotation#check_credential_lifetime). As all the jobs get their cluster credentials dynamically through gcloud, I think there won't be a huge impact if those are rotated on a more frequent basis.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm merged pull request #22977: Run cred rotation every month
Posted by GitBox <gi...@apache.org>.
damccorm merged PR #22977:
URL: https://github.com/apache/beam/pull/22977
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org