You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/09/09 06:08:52 UTC

[GitHub] [skywalking] kezhenxu94 opened a new issue #7682: [Feature] inject Python agent automatically in SWCK

kezhenxu94 opened a new issue #7682:
URL: https://github.com/apache/skywalking/issues/7682


   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement.
   
   
   ### Description
   
   Since https://github.com/apache/skywalking-python/pull/159 is merged, we have Docker image for SkyWalking Python agent and non-intrusive way to install the agent, it would be perfect if we can also enhance [SWCK](http://github.com/apache/skywalking-swck) to make it possible to inject the Python agent automatically when Kubernetes annotation is specified.
   
   ### Use case
   
   When users label a Kubernetes namespace with a special annotation, for example, `swck-java-agent-injected=true`, SWCK can automatically inject the Python agent to the application Pod, hence the users don't even need to modify their Docker image.
   
   ### Related issues
   
   Java agent injector: https://github.com/apache/skywalking-swck/pull/30
   
   https://github.com/apache/skywalking-python/pull/159
   https://github.com/apache/skywalking/issues/7461
   
   ### Are you willing to submit a PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] kezhenxu94 commented on issue #7682: [Feature] inject Python agent automatically in SWCK

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #7682:
URL: https://github.com/apache/skywalking/issues/7682#issuecomment-919774927


   @Superskyyy FYI https://github.com/apache/skywalking-swck/pull/30 is merged


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on issue #7682: [Feature] inject Python agent automatically in SWCK

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7682:
URL: https://github.com/apache/skywalking/issues/7682#issuecomment-1042358512


   Service Mesh is good to learn :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] Superskyyy commented on issue #7682: [Feature] inject Python agent automatically in SWCK

Posted by GitBox <gi...@apache.org>.
Superskyyy commented on issue #7682:
URL: https://github.com/apache/skywalking/issues/7682#issuecomment-919981003


   > @Superskyyy FYI [apache/skywalking-swck#30](https://github.com/apache/skywalking-swck/pull/30) is merged
   
   Okay, my turn then.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on issue #7682: [Feature] inject Python agent automatically in SWCK

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7682:
URL: https://github.com/apache/skywalking/issues/7682#issuecomment-917742148


   @hanahmily Please confirm tye statue of that PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on issue #7682: [Feature] inject Python agent automatically in SWCK

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7682:
URL: https://github.com/apache/skywalking/issues/7682#issuecomment-1038734063


   @Superskyyy Could you try to finish this? I hope we could move forward 1.0 soon.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] Superskyyy commented on issue #7682: [Feature] inject Python agent automatically in SWCK

Posted by GitBox <gi...@apache.org>.
Superskyyy commented on issue #7682:
URL: https://github.com/apache/skywalking/issues/7682#issuecomment-917674354


   Do I wait the Java PR to be ready first? In case something can be reused. Looks like a very big feature there base on the LOC.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] kezhenxu94 commented on issue #7682: [Feature] inject Python agent automatically in SWCK

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #7682:
URL: https://github.com/apache/skywalking/issues/7682#issuecomment-915792208


   @Superskyyy FYI 😉 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] Superskyyy commented on issue #7682: [Feature] inject Python agent automatically in SWCK

Posted by GitBox <gi...@apache.org>.
Superskyyy commented on issue #7682:
URL: https://github.com/apache/skywalking/issues/7682#issuecomment-1042115558


   > @Superskyyy Could you try to finish this? I hope we could move forward 1.0 soon.
   
   @wu-sheng I would try my best to proceed soon, so that hopefully we could go to 1.0.0 in early March. Sorry for the delays, I had to focus on my graduate research on service mesh recently.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org