You are viewing a plain text version of this content. The canonical link for it is here.
Posted to rivet-dev@tcl.apache.org by Cyril Shtumf <sh...@gmail.com> on 2012/05/10 14:54:07 UTC

Several errors in mod_rivet

Hi all

I found several errors in mod_rivet. Patches to fix them are attached.

The package DIO doesn't check server connection.
For example, if set in mysql config "wait_timeout = 60", after 1 minute 
I get the error "server has gone away". [1]

Also in DIO. Multiple fields in "delete" returns sql-query with wrong 
syntax.
For example: db delete [list $var1 $var2] -keyfield [list {var1} {var2}] 
-table {my_table}. [2]

In the session package. The session data need to delete 
(rivet_session_cache table). Wrong syntax in sql-query and "ON DELETE 
CASCADE" available only for mysql-engine INNODB. May make sense a 
cleaning table through a script? [3]

A small addition. Cookie doesn't support HttpOnly flag. [4]

1. *dio_check_conn.diff*
2. *fix_delete_for_multiple_fields.diff*
3. *delete_session_data.diff*
4. *add_HttpOnly_cookies.diff*

-- 
Best regards,
Cyril


Re: R: Re: Several errors in mod_rivet

Posted by Cyril Shtumf <sh...@gmail.com>.
No problem, I created the bug reports on bugzilla.

12.05.2012 04:39, Massimo Manghi wrote:
> Yes, this is the way we ought to work. If Cyril doesn't file these bugs I will do it on behalf of him.
>
>   -- Massimo
>
> Le mail ti raggiungono ovunque con BlackBerry® from Vodafone!
>
> -----Original Message-----
> From: Jeff Lawson<je...@bovine.net>
> Date: Thu, 10 May 2012 20:07:36
> To: Cyril Shtumf<sh...@gmail.com>
> Cc:<ri...@tcl.apache.org>
> Subject: Re: Several errors in mod_rivet
>
> Maybe it would make sense to have separate issues opened in Bugzilla
> for each of these items so that there can be a clearer history trail
> about these aspects and the commit logs can reference the bug numbers?
>   https://issues.apache.org/bugzilla/


-- 
Best regards,
Cyril


---------------------------------------------------------------------
To unsubscribe, e-mail: rivet-dev-unsubscribe@tcl.apache.org
For additional commands, e-mail: rivet-dev-help@tcl.apache.org


Re: Several errors in mod_rivet

Posted by Jeff Lawson <je...@bovine.net>.
Maybe it would make sense to have separate issues opened in Bugzilla
for each of these items so that there can be a clearer history trail
about these aspects and the commit logs can reference the bug numbers?
 https://issues.apache.org/bugzilla/



On Thu, May 10, 2012 at 7:54 AM, Cyril Shtumf <sh...@gmail.com> wrote:
> Hi all
>
> I found several errors in mod_rivet. Patches to fix them are attached.
>
> The package DIO doesn't check server connection.
> For example, if set in mysql config "wait_timeout = 60", after 1 minute I
> get the error "server has gone away". [1]
>
> Also in DIO. Multiple fields in "delete" returns sql-query with wrong
> syntax.
> For example: db delete [list $var1 $var2] -keyfield [list {var1} {var2}]
> -table {my_table}. [2]
>
> In the session package. The session data need to delete (rivet_session_cache
> table). Wrong syntax in sql-query and "ON DELETE CASCADE" available only for
> mysql-engine INNODB. May make sense a cleaning table through a script? [3]
>
> A small addition. Cookie doesn't support HttpOnly flag. [4]
>
> 1. dio_check_conn.diff
> 2. fix_delete_for_multiple_fields.diff
> 3. delete_session_data.diff
> 4. add_HttpOnly_cookies.diff
>
> --
> Best regards,
> Cyril
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: rivet-dev-unsubscribe@tcl.apache.org
> For additional commands, e-mail: rivet-dev-help@tcl.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: rivet-dev-unsubscribe@tcl.apache.org
For additional commands, e-mail: rivet-dev-help@tcl.apache.org