You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2021/02/05 00:23:34 UTC

[GitHub] [helix] narendly commented on a change in pull request #1532: Per replica throttle

narendly commented on a change in pull request #1532:
URL: https://github.com/apache/helix/pull/1532#discussion_r570636751



##########
File path: helix-core/src/main/java/org/apache/helix/controller/stages/AttributeName.java
##########
@@ -48,7 +48,20 @@
   // This attribute should only be used in TaskGarbageCollectionStage, misuse could cause race conditions.
   TO_BE_PURGED_WORKFLOWS,
   // This attribute should only be used in TaskGarbageCollectionStage, misuse could cause race conditions.
+
   JOBS_WITHOUT_CONFIG,
   // This attribute should only be used in TaskGarbageCollectionStage, misuse could cause race conditions.
-  TO_BE_PURGED_JOBS_MAP
+  TO_BE_PURGED_JOBS_MAP,
+
+  // This attribute denotes the messages output from Per Preplica Throttle stage
+  PER_REPLICA_OUTPUT_MESSAGES,
+
+  // This attribute denotes the targeted partition state mapping from Per Preplica Throttle stage
+  PER_REPLICA_RETRACED_STATES,
+
+  // This attribute denotes the filtered out messages deemed as recovery message
+  PER_REPLICA_THROTTLED_RECOVERY_MESSAGES,
+
+  // This attribute denotes the filtered out messages deemed as load message
+  PER_REPLICA_THROTTLED_LOAD_MESSAGES

Review comment:
       ```suggestion
     TO_BE_PURGED_JOBS_MAP,
   
     // This attribute denotes the messages output from Per Preplica Throttle stage
     PER_REPLICA_OUTPUT_MESSAGES,
   
     // This attribute denotes the targeted partition state mapping from Per Preplica Throttle stage
     PER_REPLICA_RETRACED_STATES,
   
     // This attribute denotes the filtered out messages deemed as recovery message
     PER_REPLICA_THROTTLED_RECOVERY_MESSAGES,
   
     // This attribute denotes the filtered out messages deemed as load message
     PER_REPLICA_THROTTLED_LOAD_MESSAGES
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org