You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2023/01/09 18:58:00 UTC

[GitHub] [airflow] eladkal commented on a diff in pull request #28808: Allow setting the name for the base container within K8s Pod Operator

eladkal commented on code in PR #28808:
URL: https://github.com/apache/airflow/pull/28808#discussion_r1065003786


##########
airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py:
##########
@@ -206,9 +206,10 @@ class KubernetesPodOperator(BaseOperator):
         to populate the environment variables with. The contents of the target
         ConfigMap's Data field will represent the key-value pairs as environment variables.
         Extends env_from.
+    :param base_container_name: The name of the base container in the pod. This container's logs

Review Comment:
   Should we have some doc explnations about this? Mainly around what this capability brings



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org