You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2023/01/08 16:44:12 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #4855: Minor: Move test data into `datafusion/core/tests/data`
alamb opened a new pull request, #4855:
URL: https://github.com/apache/arrow-datafusion/pull/4855
# Which issue does this PR close?
Na
# Rationale for this change
This is a cleanup I have wanted to do for a while whenever I look in the `datafusion/core/tests` directory and see intermixed data and code, which offends my sense of order
```shell
$ ls tests/
aggregate_simple.csv data/ join_fuzz.rs parquet_exec.rs sql_integration.rs user_defined_plan.rs
aggregate_simple_pipe.csv dataframe.rs jsons/ path_partition.rs sqllogictests/ window_fuzz.rs
capitalized_example.csv dataframe_functions.rs memory_limit.rs provider_filter_pushdown.rs statistics.rs
config_from_env.rs decimal_data.csv merge_fuzz.rs row.rs tpc-ds/
csv/ empty.csv null_cases.csv simplification.rs tpcds_planning.rs
custom_sources.rs example.csv order_spill_fuzz.rs sort_key_cursor.rs tpch-csv/
customer.csv fifo.rs parquet/ sql/ user_defined_aggregates.rs
```
🤮
# What changes are included in this PR?
Move all `.csv` data files `datafusion/core/tests/data`
# Are these changes tested?
Covered by existing tests
# Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #4855: Minor: Move test data into `datafusion/core/tests/data`
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #4855:
URL: https://github.com/apache/arrow-datafusion/pull/4855#issuecomment-1376789486
Thanks @jackwener
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #4855: Minor: Move test data into `datafusion/core/tests/data`
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #4855:
URL: https://github.com/apache/arrow-datafusion/pull/4855#issuecomment-1375091921
Benchmark runs are scheduled for baseline = 71b9baecd0a3c881f96e9994d922f3c1b3d61854 and contender = 664edea4ec78114e8335a05a0e0dfa06a0d223b9. 664edea4ec78114e8335a05a0e0dfa06a0d223b9 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/8c9f12d1170a4615b2a4ee2513c101fa...590cc260566944dd9c447c88d0c05f29/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/2bd47be4a1674cb783872452a7f1b02e...27c202bd7b5d4f55a3f4897e8d7ba3f9/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/f8bbba9a26944dd8b750d0a620f853fe...139227b1e22c4414ab928ac2704753d1/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/8459c58354cb4d39aef47fafad70cce4...a112229f911a401b973d33f732cd6057/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jackwener merged pull request #4855: Minor: Move test data into `datafusion/core/tests/data`
Posted by GitBox <gi...@apache.org>.
jackwener merged PR #4855:
URL: https://github.com/apache/arrow-datafusion/pull/4855
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org