You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@dubbo.apache.org by "lexburner (GitHub)" <gi...@apache.org> on 2019/01/19 14:38:56 UTC

[GitHub] [incubator-dubbo] lexburner commented on pull request #3276: Improve/heartbeat

> > @kexianjun In my opinion, idle check timer is responsible to a `Connection`, not a `Service`.
> 
> 目前的处理方式，一个HashedWheelTimer最多只处理两个任务(server端是一个，clien端是两个)，每个HashedWheelTimer都会启动一个线程检测，如果一个服务作为消费方调用服务比较多的情况下，就需要起很多线程做心跳检查，比如说我们的一个业务系统，调用其他不同系统的服务多达上十个，再加上线上集群部署，单是心跳检测线程就要起二三十个了。我觉得检测的任务和连接是对应的，定时器是可以共享的。

Got it. I will make this change.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3276 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org