You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "mehrdadh (via GitHub)" <gi...@apache.org> on 2023/03/15 22:45:21 UTC
[GitHub] [tvm] mehrdadh opened a new pull request, #14314: [microTVM][Target]Consolidate `stm32` target to `micro` target
mehrdadh opened a new pull request, #14314:
URL: https://github.com/apache/tvm/pull/14314
This PR consolidates stm32 targets into micro targets and renames some of the STM micro targets with generalized name. In addition it adds -keys=arm_cpu,cpu by default to all ARM micro targets.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh commented on pull request #14314: [microTVM][Target]Consolidate `stm32` target to `micro` target
Posted by "mehrdadh (via GitHub)" <gi...@apache.org>.
mehrdadh commented on PR #14314:
URL: https://github.com/apache/tvm/pull/14314#issuecomment-1478167815
cc @areusch for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #14314: [microTVM][Target]Consolidate `stm32` target to `micro` target
Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #14314:
URL: https://github.com/apache/tvm/pull/14314#issuecomment-1470941517
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* cc @alanmacd, @gromero, @leandron, @mkatanbaf <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on a diff in pull request #14314: [microTVM][Target]Consolidate `stm32` target to `micro` target
Posted by "areusch (via GitHub)" <gi...@apache.org>.
areusch commented on code in PR #14314:
URL: https://github.com/apache/tvm/pull/14314#discussion_r1144070270
##########
apps/microtvm/zephyr/template_project/boards.json:
##########
@@ -43,15 +43,15 @@
},
"nucleo_f746zg": {
"board": "nucleo_f746zg",
- "model": "stm32f746xx",
+ "model": "stm32f7xx",
Review Comment:
why these changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh commented on a diff in pull request #14314: [microTVM][Target]Consolidate `stm32` target to `micro` target
Posted by "mehrdadh (via GitHub)" <gi...@apache.org>.
mehrdadh commented on code in PR #14314:
URL: https://github.com/apache/tvm/pull/14314#discussion_r1144101546
##########
python/tvm/target/target.py:
##########
@@ -443,22 +443,45 @@ def intel_graphics(model="unknown", options=None):
MICRO_SUPPORTED_MODELS = {
+ # X86 emulation
"host": [],
- "atsamd51": ["-mcpu=cortex-m4"],
- "cxd5602gg": ["-mcpu=cortex-m4"],
+ # STM High-Performance
+ "stm32h7xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m7", "-march=armv7e-m"],
+ "stm32f7xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m7", "-march=armv7e-m"],
+ "stm32f4xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m4"],
+ "stm32f2xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m3"],
+ # STM Mainstream
+ "stm32g0xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m0+"],
+ "stm32f0xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m0"],
+ "stm32f1xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m3"],
+ "stm32g4xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m4"],
+ "stm32f3xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m4"],
+ "stm32l4r5xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m4"],
+ # STM Low-power
+ "stm32u5xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m33"],
+ "stm32l5xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m33"],
+ "stm32l4xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m4"],
+ "stm32l1xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m3"],
+ "stm32l0xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m0+"],
+ # NRF
+ "nrf52840": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m4+nodsp"],
+ "nrf5340dk": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m33"],
+ # Microchip
+ "atsamd51": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m4"],
+ "sam3x8e": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m3"],
+ # Sony
+ "cxd5602gg": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m4"],
+ # ESP
"esp32": [],
- "imxrt10xx": ["-mcpu=cortex-m7"],
- "mps2_an521": ["-mcpu=cortex-m33"],
- "mps3_an547": ["-mcpu=cortex-m55"],
- "nrf52840": ["-mcpu=cortex-m4+nodsp"],
- "nrf5340dk": ["-mcpu=cortex-m33"],
- "rp2040": ["-mcpu=cortex-m0"],
- "sam3x8e": ["-mcpu=cortex-m3"],
- "stm32f746xx": ["-mcpu=cortex-m7", "-march=armv7e-m"],
- "stm32h7xx": ["-mcpu=cortex-m7"],
- "stm32l4r5zi": ["-mcpu=cortex-m4"],
- "stm32u5xx": ["-mcpu=cortex-m33"],
- "zynq_mp_r5": ["-mcpu=cortex-r5"],
+ # NXP
+ "imxrt10xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m7"],
Review Comment:
I think `armv7e-m` should be on all cortex-m4 and cortex-m7 boards:
https://en.wikipedia.org/wiki/ARM_Cortex-M
##########
python/tvm/target/target.py:
##########
@@ -443,22 +443,45 @@ def intel_graphics(model="unknown", options=None):
MICRO_SUPPORTED_MODELS = {
+ # X86 emulation
"host": [],
- "atsamd51": ["-mcpu=cortex-m4"],
- "cxd5602gg": ["-mcpu=cortex-m4"],
+ # STM High-Performance
+ "stm32h7xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m7", "-march=armv7e-m"],
+ "stm32f7xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m7", "-march=armv7e-m"],
+ "stm32f4xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m4"],
+ "stm32f2xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m3"],
+ # STM Mainstream
+ "stm32g0xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m0+"],
+ "stm32f0xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m0"],
+ "stm32f1xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m3"],
+ "stm32g4xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m4"],
+ "stm32f3xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m4"],
+ "stm32l4r5xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m4"],
+ # STM Low-power
+ "stm32u5xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m33"],
+ "stm32l5xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m33"],
+ "stm32l4xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m4"],
+ "stm32l1xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m3"],
+ "stm32l0xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m0+"],
+ # NRF
+ "nrf52840": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m4+nodsp"],
+ "nrf5340dk": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m33"],
+ # Microchip
+ "atsamd51": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m4"],
+ "sam3x8e": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m3"],
+ # Sony
+ "cxd5602gg": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m4"],
+ # ESP
"esp32": [],
- "imxrt10xx": ["-mcpu=cortex-m7"],
- "mps2_an521": ["-mcpu=cortex-m33"],
- "mps3_an547": ["-mcpu=cortex-m55"],
- "nrf52840": ["-mcpu=cortex-m4+nodsp"],
- "nrf5340dk": ["-mcpu=cortex-m33"],
- "rp2040": ["-mcpu=cortex-m0"],
- "sam3x8e": ["-mcpu=cortex-m3"],
- "stm32f746xx": ["-mcpu=cortex-m7", "-march=armv7e-m"],
- "stm32h7xx": ["-mcpu=cortex-m7"],
- "stm32l4r5zi": ["-mcpu=cortex-m4"],
- "stm32u5xx": ["-mcpu=cortex-m33"],
- "zynq_mp_r5": ["-mcpu=cortex-r5"],
+ # NXP
+ "imxrt10xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m7"],
Review Comment:
cc @areusch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] janetsc commented on a diff in pull request #14314: [microTVM][Target]Consolidate `stm32` target to `micro` target
Posted by "janetsc (via GitHub)" <gi...@apache.org>.
janetsc commented on code in PR #14314:
URL: https://github.com/apache/tvm/pull/14314#discussion_r1146467325
##########
python/tvm/target/target.py:
##########
@@ -443,22 +443,45 @@ def intel_graphics(model="unknown", options=None):
MICRO_SUPPORTED_MODELS = {
+ # X86 emulation
"host": [],
- "atsamd51": ["-mcpu=cortex-m4"],
- "cxd5602gg": ["-mcpu=cortex-m4"],
+ # STM High-Performance
+ "stm32h7xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m7", "-march=armv7e-m"],
+ "stm32f7xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m7", "-march=armv7e-m"],
+ "stm32f4xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m4"],
+ "stm32f2xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m3"],
+ # STM Mainstream
+ "stm32g0xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m0+"],
+ "stm32f0xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m0"],
+ "stm32f1xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m3"],
+ "stm32g4xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m4"],
+ "stm32f3xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m4"],
+ "stm32l4r5xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m4"],
+ # STM Low-power
+ "stm32u5xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m33"],
+ "stm32l5xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m33"],
+ "stm32l4xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m4"],
+ "stm32l1xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m3"],
+ "stm32l0xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m0+"],
+ # NRF
+ "nrf52840": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m4+nodsp"],
+ "nrf5340dk": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m33"],
+ # Microchip
+ "atsamd51": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m4"],
+ "sam3x8e": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m3"],
+ # Sony
+ "cxd5602gg": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m4"],
+ # ESP
"esp32": [],
- "imxrt10xx": ["-mcpu=cortex-m7"],
- "mps2_an521": ["-mcpu=cortex-m33"],
- "mps3_an547": ["-mcpu=cortex-m55"],
- "nrf52840": ["-mcpu=cortex-m4+nodsp"],
- "nrf5340dk": ["-mcpu=cortex-m33"],
- "rp2040": ["-mcpu=cortex-m0"],
- "sam3x8e": ["-mcpu=cortex-m3"],
- "stm32f746xx": ["-mcpu=cortex-m7", "-march=armv7e-m"],
- "stm32h7xx": ["-mcpu=cortex-m7"],
- "stm32l4r5zi": ["-mcpu=cortex-m4"],
- "stm32u5xx": ["-mcpu=cortex-m33"],
- "zynq_mp_r5": ["-mcpu=cortex-r5"],
+ # NXP
+ "imxrt10xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m7"],
Review Comment:
+1 - that's why I asked, because I saw it specified above. Maybe that can be removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh commented on a diff in pull request #14314: [microTVM][Target]Consolidate `stm32` target to `micro` target
Posted by "mehrdadh (via GitHub)" <gi...@apache.org>.
mehrdadh commented on code in PR #14314:
URL: https://github.com/apache/tvm/pull/14314#discussion_r1146450677
##########
python/tvm/target/target.py:
##########
@@ -443,22 +443,45 @@ def intel_graphics(model="unknown", options=None):
MICRO_SUPPORTED_MODELS = {
+ # X86 emulation
"host": [],
- "atsamd51": ["-mcpu=cortex-m4"],
- "cxd5602gg": ["-mcpu=cortex-m4"],
+ # STM High-Performance
+ "stm32h7xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m7", "-march=armv7e-m"],
+ "stm32f7xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m7", "-march=armv7e-m"],
+ "stm32f4xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m4"],
+ "stm32f2xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m3"],
+ # STM Mainstream
+ "stm32g0xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m0+"],
+ "stm32f0xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m0"],
+ "stm32f1xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m3"],
+ "stm32g4xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m4"],
+ "stm32f3xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m4"],
+ "stm32l4r5xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m4"],
+ # STM Low-power
+ "stm32u5xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m33"],
+ "stm32l5xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m33"],
+ "stm32l4xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m4"],
+ "stm32l1xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m3"],
+ "stm32l0xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m0+"],
+ # NRF
+ "nrf52840": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m4+nodsp"],
+ "nrf5340dk": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m33"],
+ # Microchip
+ "atsamd51": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m4"],
+ "sam3x8e": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m3"],
+ # Sony
+ "cxd5602gg": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m4"],
+ # ESP
"esp32": [],
- "imxrt10xx": ["-mcpu=cortex-m7"],
- "mps2_an521": ["-mcpu=cortex-m33"],
- "mps3_an547": ["-mcpu=cortex-m55"],
- "nrf52840": ["-mcpu=cortex-m4+nodsp"],
- "nrf5340dk": ["-mcpu=cortex-m33"],
- "rp2040": ["-mcpu=cortex-m0"],
- "sam3x8e": ["-mcpu=cortex-m3"],
- "stm32f746xx": ["-mcpu=cortex-m7", "-march=armv7e-m"],
- "stm32h7xx": ["-mcpu=cortex-m7"],
- "stm32l4r5zi": ["-mcpu=cortex-m4"],
- "stm32u5xx": ["-mcpu=cortex-m33"],
- "zynq_mp_r5": ["-mcpu=cortex-r5"],
+ # NXP
+ "imxrt10xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m7"],
Review Comment:
@areusch that was my expectation too, but I saw `-march=armv7e-m` in one of the targets and I got confused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on a diff in pull request #14314: [microTVM][Target]Consolidate `stm32` target to `micro` target
Posted by "areusch (via GitHub)" <gi...@apache.org>.
areusch commented on code in PR #14314:
URL: https://github.com/apache/tvm/pull/14314#discussion_r1145432075
##########
python/tvm/target/target.py:
##########
@@ -443,22 +443,45 @@ def intel_graphics(model="unknown", options=None):
MICRO_SUPPORTED_MODELS = {
+ # X86 emulation
"host": [],
- "atsamd51": ["-mcpu=cortex-m4"],
- "cxd5602gg": ["-mcpu=cortex-m4"],
+ # STM High-Performance
+ "stm32h7xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m7", "-march=armv7e-m"],
+ "stm32f7xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m7", "-march=armv7e-m"],
+ "stm32f4xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m4"],
+ "stm32f2xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m3"],
+ # STM Mainstream
+ "stm32g0xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m0+"],
+ "stm32f0xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m0"],
+ "stm32f1xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m3"],
+ "stm32g4xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m4"],
+ "stm32f3xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m4"],
+ "stm32l4r5xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m4"],
+ # STM Low-power
+ "stm32u5xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m33"],
+ "stm32l5xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m33"],
+ "stm32l4xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m4"],
+ "stm32l1xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m3"],
+ "stm32l0xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m0+"],
+ # NRF
+ "nrf52840": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m4+nodsp"],
+ "nrf5340dk": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m33"],
+ # Microchip
+ "atsamd51": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m4"],
+ "sam3x8e": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m3"],
+ # Sony
+ "cxd5602gg": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m4"],
+ # ESP
"esp32": [],
- "imxrt10xx": ["-mcpu=cortex-m7"],
- "mps2_an521": ["-mcpu=cortex-m33"],
- "mps3_an547": ["-mcpu=cortex-m55"],
- "nrf52840": ["-mcpu=cortex-m4+nodsp"],
- "nrf5340dk": ["-mcpu=cortex-m33"],
- "rp2040": ["-mcpu=cortex-m0"],
- "sam3x8e": ["-mcpu=cortex-m3"],
- "stm32f746xx": ["-mcpu=cortex-m7", "-march=armv7e-m"],
- "stm32h7xx": ["-mcpu=cortex-m7"],
- "stm32l4r5zi": ["-mcpu=cortex-m4"],
- "stm32u5xx": ["-mcpu=cortex-m33"],
- "zynq_mp_r5": ["-mcpu=cortex-r5"],
+ # NXP
+ "imxrt10xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m7"],
Review Comment:
i believe the compiler infers this from -mcpu for ARM parts. cc @Mousius if he knows more
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] janetsc commented on a diff in pull request #14314: [microTVM][Target]Consolidate `stm32` target to `micro` target
Posted by "janetsc (via GitHub)" <gi...@apache.org>.
janetsc commented on code in PR #14314:
URL: https://github.com/apache/tvm/pull/14314#discussion_r1144085816
##########
python/tvm/target/target.py:
##########
@@ -443,22 +443,45 @@ def intel_graphics(model="unknown", options=None):
MICRO_SUPPORTED_MODELS = {
+ # X86 emulation
"host": [],
- "atsamd51": ["-mcpu=cortex-m4"],
- "cxd5602gg": ["-mcpu=cortex-m4"],
+ # STM High-Performance
+ "stm32h7xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m7", "-march=armv7e-m"],
+ "stm32f7xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m7", "-march=armv7e-m"],
+ "stm32f4xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m4"],
+ "stm32f2xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m3"],
+ # STM Mainstream
+ "stm32g0xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m0+"],
+ "stm32f0xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m0"],
+ "stm32f1xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m3"],
+ "stm32g4xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m4"],
+ "stm32f3xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m4"],
+ "stm32l4r5xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m4"],
+ # STM Low-power
+ "stm32u5xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m33"],
+ "stm32l5xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m33"],
+ "stm32l4xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m4"],
+ "stm32l1xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m3"],
+ "stm32l0xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m0+"],
+ # NRF
+ "nrf52840": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m4+nodsp"],
+ "nrf5340dk": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m33"],
+ # Microchip
+ "atsamd51": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m4"],
+ "sam3x8e": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m3"],
+ # Sony
+ "cxd5602gg": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m4"],
+ # ESP
"esp32": [],
- "imxrt10xx": ["-mcpu=cortex-m7"],
- "mps2_an521": ["-mcpu=cortex-m33"],
- "mps3_an547": ["-mcpu=cortex-m55"],
- "nrf52840": ["-mcpu=cortex-m4+nodsp"],
- "nrf5340dk": ["-mcpu=cortex-m33"],
- "rp2040": ["-mcpu=cortex-m0"],
- "sam3x8e": ["-mcpu=cortex-m3"],
- "stm32f746xx": ["-mcpu=cortex-m7", "-march=armv7e-m"],
- "stm32h7xx": ["-mcpu=cortex-m7"],
- "stm32l4r5zi": ["-mcpu=cortex-m4"],
- "stm32u5xx": ["-mcpu=cortex-m33"],
- "zynq_mp_r5": ["-mcpu=cortex-r5"],
+ # NXP
+ "imxrt10xx": ["-keys=arm_cpu,cpu", "-mcpu=cortex-m7"],
Review Comment:
Does this also need "-march=armv7e-m"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh commented on a diff in pull request #14314: [microTVM][Target]Consolidate `stm32` target to `micro` target
Posted by "mehrdadh (via GitHub)" <gi...@apache.org>.
mehrdadh commented on code in PR #14314:
URL: https://github.com/apache/tvm/pull/14314#discussion_r1144080935
##########
apps/microtvm/zephyr/template_project/boards.json:
##########
@@ -43,15 +43,15 @@
},
"nucleo_f746zg": {
"board": "nucleo_f746zg",
- "model": "stm32f746xx",
+ "model": "stm32f7xx",
Review Comment:
`stm32f7xx` is more generic than `stm32f746xx`
https://www.st.com/en/microcontrollers-microprocessors/stm32f7-series.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org