You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/08 16:09:36 UTC

[GitHub] [arrow] bkietz commented on a change in pull request #9140: ARROW-11189: [Developer] support benchmark diff between JSONs

bkietz commented on a change in pull request #9140:
URL: https://github.com/apache/arrow/pull/9140#discussion_r554038453



##########
File path: dev/archery/archery/cli.py
##########
@@ -586,14 +585,29 @@ def _get_comparisons_as_json(comparisons):
     return buf.getvalue()
 
 
-def _format_comparisons_with_pandas(comparisons_json):
+def _format_comparisons_with_pandas(comparisons_json, no_counters):
     import pandas as pd

Review comment:
       @kszucs I don't see `pandas` in dev/archery/requirements.txt or ci/conda_env_archery.yml. Should it be added?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org