You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/11/01 08:39:57 UTC
[GitHub] [echarts] Ovilia opened a new pull request #15985: fix(radar): name being - in tooltip when name.show is false #15915
Ovilia opened a new pull request #15985:
URL: https://github.com/apache/echarts/pull/15985
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
<!-- USE ONCE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
Radar indicator names were displayed in the tooltip as "-" when `indicator.name.show` is set to be false.
### Fixed issues
- #15915
## Details
### Before: What was the problem?
<!-- DESCRIBE THE BUG OR REQUIREMENT HERE. -->
<!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
Radar indicator names were displayed in the tooltip as "-" when `indicator.name.show` is set to be false.
### After: How is it fixed in this PR?
<!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. -->
<!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
Radar indicator name should be displayed in the tooltip.
## Misc
<!-- ADD RELATED ISSUE ID WHEN APPLICABLE -->
- [ ] The API has been changed (apache/echarts-doc#xxx).
- [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
### Related test cases or examples to use the new APIs
NA.
## Others
### Merging options
- [ ] Please squash the commits into a single one when merge.
### Other information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #15985: fix(radar): name being - in tooltip when name.show is false #15915
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #15985:
URL: https://github.com/apache/echarts/pull/15985#issuecomment-1011751573
Congratulations! Your PR has been merged. Thanks for your contribution! 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #15985: fix(radar): name being - in tooltip when name.show is false #15915
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #15985:
URL: https://github.com/apache/echarts/pull/15985#issuecomment-956040296
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
The pull request is marked to be `PR: author is committer` because you are a committer of this project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang merged pull request #15985: fix(radar): name being - in tooltip when name.show is false #15915
Posted by GitBox <gi...@apache.org>.
pissang merged pull request #15985:
URL: https://github.com/apache/echarts/pull/15985
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] plainheart commented on a change in pull request #15985: fix(radar): name being - in tooltip when name.show is false #15915
Posted by GitBox <gi...@apache.org>.
plainheart commented on a change in pull request #15985:
URL: https://github.com/apache/echarts/pull/15985#discussion_r774333439
##########
File path: src/preprocessor/helper/compatStyle.ts
##########
@@ -307,6 +307,11 @@ export default function globalCompatStyle(option: any, isTheme?: boolean) {
deprecateLog('nameGap property in radar component has been changed to axisNameGap');
}
}
+ each(radarOpt.indicator, function (indicatorOpt: any) {
+ if (__DEV__ && indicatorOpt.text) {
Review comment:
There may be an unnecessary empty function invoking as `__DEV__` check is put into the loop.
The final output will be as follows, (minimized)
```js
Jp(t.indicator,(function(t){0}))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org