You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/03/01 02:22:00 UTC
[jira] [Work logged] (BEAM-13907) Increase unit testing coverage in the textio package
[ https://issues.apache.org/jira/browse/BEAM-13907?focusedWorklogId=734310&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-734310 ]
ASF GitHub Bot logged work on BEAM-13907:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Mar/22 02:21
Start Date: 01/Mar/22 02:21
Worklog Time Spent: 10m
Work Description: lostluck commented on a change in pull request #16937:
URL: https://github.com/apache/beam/pull/16937#discussion_r816399192
##########
File path: sdks/go/pkg/beam/io/textio/textio_test.go
##########
@@ -17,20 +17,26 @@
package textio
import (
+ "errors"
+ "os"
"testing"
+ "github.com/apache/beam/sdks/v2/go/pkg/beam"
_ "github.com/apache/beam/sdks/v2/go/pkg/beam/io/filesystem/local"
+ _ "github.com/apache/beam/sdks/v2/go/pkg/beam/runners/direct"
Review comment:
Same as the other PR, just removing the unnecessary direct import.
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 734310)
Time Spent: 2.5h (was: 2h 20m)
> Increase unit testing coverage in the textio package
> ----------------------------------------------------
>
> Key: BEAM-13907
> URL: https://issues.apache.org/jira/browse/BEAM-13907
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Jack McCluskey
> Assignee: Danny McCormick
> Priority: P2
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Increase unit testing coverage in the [textio package|https://github.com/apache/beam/tree/release-2.36.0/sdks/go/pkg/beam/io/textio]
> We want code coverage at or above 50%, it is currently at 45.5%.
> This task is mostly testing the DoFns and SDFs, with some coverage increases coming from finding testing gaps in helper functions.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)