You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by PRAGYA MITTAL <mi...@gmail.com> on 2015/08/10 21:40:31 UTC
Review Request 37313: Add Instance Dependency API Test
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37313/
-----------------------------------------------------------
Review request for Falcon.
Bugs: FALCON-1387
https://issues.apache.org/jira/browse/FALCON-1387
Repository: falcon-git
Description
-------
Test cases related to https://issues.apache.org/jira/browse/FALCON-1039
Diffs
-----
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/ResponseErrors.java 85f3692
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java 2baa35f
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java f984457
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java 4550666
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/MatrixUtil.java c68dd3c
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java f327178
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/TimeUtil.java c5dd0fd
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java 6c8d4ee
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/FeedInstanceDependencyTest.java PRE-CREATION
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/ProcessInstanceDependencyTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/37313/diff/
Testing
-------
Tested.
Thanks,
PRAGYA MITTAL
Re: Review Request 37313: Add Instance Dependency API Test
Posted by PRAGYA MITTAL <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37313/#review95705
-----------------------------------------------------------
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java (line 807)
<https://reviews.apache.org/r/37313/#comment150801>
Instance dependency API for feed provides information related to feed. It gives which process the feed belongs to, hence the validation is for process and its name.
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java (line 807)
<https://reviews.apache.org/r/37313/#comment150802>
Instance dependency API for feed provides information related to feed. It gives which process the feed belongs to, hence the validation is for process and its name.
- PRAGYA MITTAL
On Aug. 10, 2015, 7:40 p.m., PRAGYA MITTAL wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37313/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2015, 7:40 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1387
> https://issues.apache.org/jira/browse/FALCON-1387
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Test cases related to https://issues.apache.org/jira/browse/FALCON-1039
>
>
> Diffs
> -----
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/ResponseErrors.java 85f3692
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java 2baa35f
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java f984457
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java 4550666
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/MatrixUtil.java c68dd3c
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java f327178
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/TimeUtil.java c5dd0fd
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java 6c8d4ee
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/FeedInstanceDependencyTest.java PRE-CREATION
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/ProcessInstanceDependencyTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37313/diff/
>
>
> Testing
> -------
>
> Tested.
>
>
> Thanks,
>
> PRAGYA MITTAL
>
>
Re: Review Request 37313: Add Instance Dependency API Test
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37313/#review101102
-----------------------------------------------------------
Ship it!
Ship It!
- Ajay Yadava
On Sept. 30, 2015, 9:53 a.m., PRAGYA MITTAL wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37313/
> -----------------------------------------------------------
>
> (Updated Sept. 30, 2015, 9:53 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1387
> https://issues.apache.org/jira/browse/FALCON-1387
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Test cases related to https://issues.apache.org/jira/browse/FALCON-1039
>
>
> Diffs
> -----
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/ResponseErrors.java 85f3692
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java 0bd8a32
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java 1546415
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java 4550666
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/MatrixUtil.java c68dd3c
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java f327178
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/TimeUtil.java c5dd0fd
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java 6c8d4ee
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/FeedInstanceDependencyTest.java PRE-CREATION
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/ProcessInstanceDependencyTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37313/diff/
>
>
> Testing
> -------
>
> Tested.
>
>
> Thanks,
>
> PRAGYA MITTAL
>
>
Re: Review Request 37313: Add Instance Dependency API Test
Posted by PRAGYA MITTAL <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37313/
-----------------------------------------------------------
(Updated Sept. 30, 2015, 9:53 a.m.)
Review request for Falcon.
Changes
-------
Addressed review comments by Ajay Yadava.
Bugs: FALCON-1387
https://issues.apache.org/jira/browse/FALCON-1387
Repository: falcon-git
Description
-------
Test cases related to https://issues.apache.org/jira/browse/FALCON-1039
Diffs (updated)
-----
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/ResponseErrors.java 85f3692
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java 0bd8a32
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java 1546415
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java 4550666
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/MatrixUtil.java c68dd3c
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java f327178
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/TimeUtil.java c5dd0fd
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java 6c8d4ee
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/FeedInstanceDependencyTest.java PRE-CREATION
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/ProcessInstanceDependencyTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/37313/diff/
Testing
-------
Tested.
Thanks,
PRAGYA MITTAL
Re: Review Request 37313: Add Instance Dependency API Test
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37313/#review101094
-----------------------------------------------------------
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java (line 751)
<https://reviews.apache.org/r/37313/#comment158415>
Is the method getConf() used only for Processes?
Will this condition ever be true for a process? - more than 2 coords and appName contains "PROCESS" ?
- Ajay Yadava
On Sept. 24, 2015, 1:46 p.m., PRAGYA MITTAL wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37313/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2015, 1:46 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1387
> https://issues.apache.org/jira/browse/FALCON-1387
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Test cases related to https://issues.apache.org/jira/browse/FALCON-1039
>
>
> Diffs
> -----
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/ResponseErrors.java 85f3692
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java 0bd8a32
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java f984457
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java 4550666
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/MatrixUtil.java c68dd3c
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java f327178
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/TimeUtil.java c5dd0fd
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java 6c8d4ee
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/FeedInstanceDependencyTest.java PRE-CREATION
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/ProcessInstanceDependencyTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37313/diff/
>
>
> Testing
> -------
>
> Tested.
>
>
> Thanks,
>
> PRAGYA MITTAL
>
>
Re: Review Request 37313: Add Instance Dependency API Test
Posted by PRAGYA MITTAL <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37313/#review101098
-----------------------------------------------------------
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java (line 751)
<https://reviews.apache.org/r/37313/#comment158422>
currently i am using it for process only. As discussed offline i will rename the function and remove the extra if else.
- PRAGYA MITTAL
On Sept. 24, 2015, 1:46 p.m., PRAGYA MITTAL wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37313/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2015, 1:46 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1387
> https://issues.apache.org/jira/browse/FALCON-1387
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Test cases related to https://issues.apache.org/jira/browse/FALCON-1039
>
>
> Diffs
> -----
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/ResponseErrors.java 85f3692
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java 0bd8a32
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java f984457
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java 4550666
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/MatrixUtil.java c68dd3c
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java f327178
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/TimeUtil.java c5dd0fd
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java 6c8d4ee
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/FeedInstanceDependencyTest.java PRE-CREATION
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/ProcessInstanceDependencyTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37313/diff/
>
>
> Testing
> -------
>
> Tested.
>
>
> Thanks,
>
> PRAGYA MITTAL
>
>
Re: Review Request 37313: Add Instance Dependency API Test
Posted by PRAGYA MITTAL <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37313/
-----------------------------------------------------------
(Updated Sept. 24, 2015, 1:46 p.m.)
Review request for Falcon.
Changes
-------
Addressed review comments.
Bugs: FALCON-1387
https://issues.apache.org/jira/browse/FALCON-1387
Repository: falcon-git
Description
-------
Test cases related to https://issues.apache.org/jira/browse/FALCON-1039
Diffs (updated)
-----
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/ResponseErrors.java 85f3692
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java 0bd8a32
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java f984457
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java 4550666
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/MatrixUtil.java c68dd3c
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java f327178
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/TimeUtil.java c5dd0fd
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java 6c8d4ee
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/FeedInstanceDependencyTest.java PRE-CREATION
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/ProcessInstanceDependencyTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/37313/diff/
Testing
-------
Tested.
Thanks,
PRAGYA MITTAL
Re: Review Request 37313: Add Instance Dependency API Test
Posted by PRAGYA MITTAL <mi...@gmail.com>.
> On Aug. 10, 2015, 8 p.m., sandeep samudrala wrote:
> > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/TimeUtil.java, line 291
> > <https://reviews.apache.org/r/37313/diff/1/?file=1036576#file1036576line291>
> >
> > set time zone to UTC
Time zone is already set to UTC. No need to set it again here.
- PRAGYA
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37313/#review94784
-----------------------------------------------------------
On Aug. 10, 2015, 7:40 p.m., PRAGYA MITTAL wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37313/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2015, 7:40 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1387
> https://issues.apache.org/jira/browse/FALCON-1387
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Test cases related to https://issues.apache.org/jira/browse/FALCON-1039
>
>
> Diffs
> -----
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/ResponseErrors.java 85f3692
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java 2baa35f
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java f984457
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java 4550666
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/MatrixUtil.java c68dd3c
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java f327178
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/TimeUtil.java c5dd0fd
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java 6c8d4ee
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/FeedInstanceDependencyTest.java PRE-CREATION
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/ProcessInstanceDependencyTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37313/diff/
>
>
> Testing
> -------
>
> Tested.
>
>
> Thanks,
>
> PRAGYA MITTAL
>
>
Re: Review Request 37313: Add Instance Dependency API Test
Posted by sandeep samudrala <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37313/#review94784
-----------------------------------------------------------
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/TimeUtil.java (line 291)
<https://reviews.apache.org/r/37313/#comment149403>
set time zone to UTC
- sandeep samudrala
On Aug. 10, 2015, 7:40 p.m., PRAGYA MITTAL wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37313/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2015, 7:40 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1387
> https://issues.apache.org/jira/browse/FALCON-1387
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Test cases related to https://issues.apache.org/jira/browse/FALCON-1039
>
>
> Diffs
> -----
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/ResponseErrors.java 85f3692
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java 2baa35f
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java f984457
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java 4550666
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/MatrixUtil.java c68dd3c
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java f327178
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/TimeUtil.java c5dd0fd
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java 6c8d4ee
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/FeedInstanceDependencyTest.java PRE-CREATION
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/ProcessInstanceDependencyTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37313/diff/
>
>
> Testing
> -------
>
> Tested.
>
>
> Thanks,
>
> PRAGYA MITTAL
>
>
Re: Review Request 37313: Add Instance Dependency API Test
Posted by PRAGYA MITTAL <mi...@gmail.com>.
> On Aug. 13, 2015, 2:47 p.m., Ajay Yadava wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/FeedInstanceDependencyTest.java, line 59
> > <https://reviews.apache.org/r/37313/diff/1/?file=1036578#file1036578line59>
> >
> > should it be private?
Seems private. Will change it.
> On Aug. 13, 2015, 2:47 p.m., Ajay Yadava wrote:
> > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java, line 460
> > <https://reviews.apache.org/r/37313/diff/1/?file=1036572#file1036572line460>
> >
> > assertNotNull can be used here.
Sure.
> On Aug. 13, 2015, 2:47 p.m., Ajay Yadava wrote:
> > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/ResponseErrors.java, line 27
> > <https://reviews.apache.org/r/37313/diff/1/?file=1036570#file1036570line27>
> >
> > some name like PROCESS_INVALID_RANGE and FEED_INVALID_RANGE instead of unparsable?
Sure.
- PRAGYA
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37313/#review95255
-----------------------------------------------------------
On Aug. 10, 2015, 7:40 p.m., PRAGYA MITTAL wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37313/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2015, 7:40 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1387
> https://issues.apache.org/jira/browse/FALCON-1387
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Test cases related to https://issues.apache.org/jira/browse/FALCON-1039
>
>
> Diffs
> -----
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/ResponseErrors.java 85f3692
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java 2baa35f
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java f984457
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java 4550666
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/MatrixUtil.java c68dd3c
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java f327178
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/TimeUtil.java c5dd0fd
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java 6c8d4ee
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/FeedInstanceDependencyTest.java PRE-CREATION
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/ProcessInstanceDependencyTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37313/diff/
>
>
> Testing
> -------
>
> Tested.
>
>
> Thanks,
>
> PRAGYA MITTAL
>
>
Re: Review Request 37313: Add Instance Dependency API Test
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37313/#review95255
-----------------------------------------------------------
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/ResponseErrors.java (line 27)
<https://reviews.apache.org/r/37313/#comment150107>
some name like PROCESS_INVALID_RANGE and FEED_INVALID_RANGE instead of unparsable?
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java (line 459)
<https://reviews.apache.org/r/37313/#comment150108>
assertNotNull can be used here.
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/FeedInstanceDependencyTest.java (line 59)
<https://reviews.apache.org/r/37313/#comment150110>
should it be private?
- Ajay Yadava
On Aug. 10, 2015, 7:40 p.m., PRAGYA MITTAL wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37313/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2015, 7:40 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1387
> https://issues.apache.org/jira/browse/FALCON-1387
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Test cases related to https://issues.apache.org/jira/browse/FALCON-1039
>
>
> Diffs
> -----
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/ResponseErrors.java 85f3692
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java 2baa35f
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java f984457
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java 4550666
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/MatrixUtil.java c68dd3c
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java f327178
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/TimeUtil.java c5dd0fd
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java 6c8d4ee
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/FeedInstanceDependencyTest.java PRE-CREATION
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/ProcessInstanceDependencyTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37313/diff/
>
>
> Testing
> -------
>
> Tested.
>
>
> Thanks,
>
> PRAGYA MITTAL
>
>
Re: Review Request 37313: Add Instance Dependency API Test
Posted by PRAGYA MITTAL <mi...@gmail.com>.
> On Aug. 17, 2015, 5:36 a.m., samarth gupta wrote:
> > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java, line 745
> > <https://reviews.apache.org/r/37313/diff/1/?file=1036575#file1036575line745>
> >
> > get coordJobs.get(0) might not work in case of feeds , where we have 2 coords , retention and replication
Handled it accordingly.
- PRAGYA
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37313/#review95564
-----------------------------------------------------------
On Aug. 10, 2015, 7:40 p.m., PRAGYA MITTAL wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37313/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2015, 7:40 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1387
> https://issues.apache.org/jira/browse/FALCON-1387
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Test cases related to https://issues.apache.org/jira/browse/FALCON-1039
>
>
> Diffs
> -----
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/ResponseErrors.java 85f3692
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java 2baa35f
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java f984457
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java 4550666
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/MatrixUtil.java c68dd3c
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java f327178
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/TimeUtil.java c5dd0fd
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java 6c8d4ee
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/FeedInstanceDependencyTest.java PRE-CREATION
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/ProcessInstanceDependencyTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37313/diff/
>
>
> Testing
> -------
>
> Tested.
>
>
> Thanks,
>
> PRAGYA MITTAL
>
>
Re: Review Request 37313: Add Instance Dependency API Test
Posted by PRAGYA MITTAL <mi...@gmail.com>.
> On Aug. 17, 2015, 5:36 a.m., samarth gupta wrote:
> > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java, line 794
> > <https://reviews.apache.org/r/37313/diff/1/?file=1036573#file1036573line794>
> >
> > is it possible to have some common code from assertInstances ? if not, lets name assertInstances as assertProcessInstance
I tried doing that. But instance dependecy for process and feed produces different output and hence need to be handled separately. Will name assertInstances as assertProcessInstance
> On Aug. 17, 2015, 5:36 a.m., samarth gupta wrote:
> > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java, line 755
> > <https://reviews.apache.org/r/37313/diff/1/?file=1036573#file1036573line755>
> >
> > java doc missing
Will add java doc.
> On Aug. 17, 2015, 5:36 a.m., samarth gupta wrote:
> > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java, line 763
> > <https://reviews.apache.org/r/37313/diff/1/?file=1036573#file1036573line763>
> >
> > java doc here and method below.
Will add java doc.
> On Aug. 17, 2015, 5:36 a.m., samarth gupta wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/FeedInstanceDependencyTest.java, line 45
> > <https://reviews.apache.org/r/37313/diff/1/?file=1036578#file1036578line45>
> >
> > it might be a good idea to put dev jira link here also, for future reference.
Sure.
> On Aug. 17, 2015, 5:36 a.m., samarth gupta wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/FeedInstanceDependencyTest.java, line 86
> > <https://reviews.apache.org/r/37313/diff/1/?file=1036578#file1036578line86>
> >
> > some java doc abt test description and for data provider also
Will add java doc.
> On Aug. 17, 2015, 5:36 a.m., samarth gupta wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/ProcessInstanceDependencyTest.java, line 114
> > <https://reviews.apache.org/r/37313/diff/1/?file=1036579#file1036579line114>
> >
> > java doc for test and dp methods.
Will add java doc.
- PRAGYA
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37313/#review95564
-----------------------------------------------------------
On Aug. 10, 2015, 7:40 p.m., PRAGYA MITTAL wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37313/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2015, 7:40 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1387
> https://issues.apache.org/jira/browse/FALCON-1387
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Test cases related to https://issues.apache.org/jira/browse/FALCON-1039
>
>
> Diffs
> -----
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/ResponseErrors.java 85f3692
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java 2baa35f
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java f984457
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java 4550666
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/MatrixUtil.java c68dd3c
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java f327178
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/TimeUtil.java c5dd0fd
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java 6c8d4ee
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/FeedInstanceDependencyTest.java PRE-CREATION
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/ProcessInstanceDependencyTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37313/diff/
>
>
> Testing
> -------
>
> Tested.
>
>
> Thanks,
>
> PRAGYA MITTAL
>
>
Re: Review Request 37313: Add Instance Dependency API Test
Posted by samarth gupta <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37313/#review95564
-----------------------------------------------------------
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java (line 755)
<https://reviews.apache.org/r/37313/#comment150575>
java doc missing
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java (line 763)
<https://reviews.apache.org/r/37313/#comment150576>
java doc here and method below.
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java (line 794)
<https://reviews.apache.org/r/37313/#comment150577>
is it possible to have some common code from assertInstances ? if not, lets name assertInstances as assertProcessInstance
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java (line 807)
<https://reviews.apache.org/r/37313/#comment150578>
i dont know the functionality. Is checking for "PROCESS" correct here since method name is assertFeedInstances
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java (line 745)
<https://reviews.apache.org/r/37313/#comment150579>
get coordJobs.get(0) might not work in case of feeds , where we have 2 coords , retention and replication
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/FeedInstanceDependencyTest.java (line 45)
<https://reviews.apache.org/r/37313/#comment150580>
it might be a good idea to put dev jira link here also, for future reference.
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/FeedInstanceDependencyTest.java (line 86)
<https://reviews.apache.org/r/37313/#comment150581>
some java doc abt test description and for data provider also
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/ProcessInstanceDependencyTest.java (line 114)
<https://reviews.apache.org/r/37313/#comment150582>
java doc for test and dp methods.
- samarth gupta
On Aug. 10, 2015, 7:40 p.m., PRAGYA MITTAL wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37313/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2015, 7:40 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1387
> https://issues.apache.org/jira/browse/FALCON-1387
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Test cases related to https://issues.apache.org/jira/browse/FALCON-1039
>
>
> Diffs
> -----
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/ResponseErrors.java 85f3692
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java 2baa35f
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java f984457
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java 4550666
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/MatrixUtil.java c68dd3c
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java f327178
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/TimeUtil.java c5dd0fd
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java 6c8d4ee
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/FeedInstanceDependencyTest.java PRE-CREATION
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/ProcessInstanceDependencyTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37313/diff/
>
>
> Testing
> -------
>
> Tested.
>
>
> Thanks,
>
> PRAGYA MITTAL
>
>