You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@royale.apache.org by GitBox <gi...@apache.org> on 2020/08/10 20:52:45 UTC
[GitHub] [royale-asjs] brianraymes opened a new pull request #895: jewel-listitemrenderer: Partial revert of data setter so dataChange event can fire when necessary
brianraymes opened a new pull request #895:
URL: https://github.com/apache/royale-asjs/pull/895
This small fix reverts part of a recent change that allows the "dataChange" event to fire when data is changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [royale-asjs] carlosrovira commented on pull request #895: jewel-listitemrenderer: Partial revert of data setter so dataChange event can fire when necessary
Posted by GitBox <gi...@apache.org>.
carlosrovira commented on pull request #895:
URL: https://github.com/apache/royale-asjs/pull/895#issuecomment-671771825
Hi @brianraymes and @Harbs, I fixed the problem. While that fixes the issue, it removes the motivation of the change. I detected a double data assignment in renderers due to overrides, so keeping that way, while works, will always generate that problem. The problem is I forgot to add the "dataChange" event. All should be ok now. Let me know if something still fails and thanks for reporting! :). Closing this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [royale-asjs] Harbs commented on pull request #895: jewel-listitemrenderer: Partial revert of data setter so dataChange event can fire when necessary
Posted by GitBox <gi...@apache.org>.
Harbs commented on pull request #895:
URL: https://github.com/apache/royale-asjs/pull/895#issuecomment-671595006
Looks correct to me. @carlosrovira Considering you're more familiar here, I'll leave this to you to merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [royale-asjs] carlosrovira closed pull request #895: jewel-listitemrenderer: Partial revert of data setter so dataChange event can fire when necessary
Posted by GitBox <gi...@apache.org>.
carlosrovira closed pull request #895:
URL: https://github.com/apache/royale-asjs/pull/895
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org