You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2023/10/09 20:24:20 UTC
[native-toolchain-CR] IMPALA-12484: Update kudu and libunwind
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20550
Change subject: IMPALA-12484: Update kudu and libunwind
......................................................................
IMPALA-12484: Update kudu and libunwind
Updates libunwind to 1.7.2 for official ARM support, and Kudu to a
version that has also updated libunwind.
Change-Id: Iccc3c6d1f33804c0e4958c040a41bcfbb4c1d4e0
---
M buildall.sh
R source/libunwind/libunwind-1.7.2-patches/0001-libunwind-trace-cache-destructor.patch
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/50/20550/1
--
To view, visit http://gerrit.cloudera.org:8080/20550
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iccc3c6d1f33804c0e4958c040a41bcfbb4c1d4e0
Gerrit-Change-Number: 20550
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
[native-toolchain-CR] IMPALA-12484: Update kudu and libunwind
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20550 )
Change subject: IMPALA-12484: Update kudu and libunwind
......................................................................
Patch Set 2: Verified+1
Tested in https://jenkins.impala.io/job/ubuntu-20.04-from-scratch-ARM/48/.
--
To view, visit http://gerrit.cloudera.org:8080/20550
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iccc3c6d1f33804c0e4958c040a41bcfbb4c1d4e0
Gerrit-Change-Number: 20550
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Oct 2023 21:32:42 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-12484: Update kudu and libunwind
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20550 )
Change subject: IMPALA-12484: Update kudu and libunwind
......................................................................
Patch Set 2: Code-Review+2
This looks good
--
To view, visit http://gerrit.cloudera.org:8080/20550
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iccc3c6d1f33804c0e4958c040a41bcfbb4c1d4e0
Gerrit-Change-Number: 20550
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Oct 2023 18:33:06 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-12484: Update kudu and libunwind
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20550 )
Change subject: IMPALA-12484: Update kudu and libunwind
......................................................................
IMPALA-12484: Update kudu and libunwind
Updates libunwind to 1.7.2 for official ARM support, and Kudu to a
version that has also updated libunwind, to fix a crash in Kudu release
builds when starting the minicluster.
Change-Id: Iccc3c6d1f33804c0e4958c040a41bcfbb4c1d4e0
Reviewed-on: http://gerrit.cloudera.org:8080/20550
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Michael Smith <mi...@cloudera.com>
---
M buildall.sh
R source/libunwind/libunwind-1.7.2-patches/0001-libunwind-trace-cache-destructor.patch
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Joe McDonnell: Looks good to me, approved
Michael Smith: Verified
--
To view, visit http://gerrit.cloudera.org:8080/20550
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iccc3c6d1f33804c0e4958c040a41bcfbb4c1d4e0
Gerrit-Change-Number: 20550
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[native-toolchain-CR] IMPALA-12484: Update kudu and libunwind
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20550 )
Change subject: IMPALA-12484: Update kudu and libunwind
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/20550
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iccc3c6d1f33804c0e4958c040a41bcfbb4c1d4e0
Gerrit-Change-Number: 20550
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Oct 2023 20:37:02 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-12484: Update kudu and libunwind
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Laszlo Gaal, Joe McDonnell, Wenzhe Zhou,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20550
to look at the new patch set (#2).
Change subject: IMPALA-12484: Update kudu and libunwind
......................................................................
IMPALA-12484: Update kudu and libunwind
Updates libunwind to 1.7.2 for official ARM support, and Kudu to a
version that has also updated libunwind, to fix a crash in Kudu release
builds when starting the minicluster.
Change-Id: Iccc3c6d1f33804c0e4958c040a41bcfbb4c1d4e0
---
M buildall.sh
R source/libunwind/libunwind-1.7.2-patches/0001-libunwind-trace-cache-destructor.patch
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/50/20550/2
--
To view, visit http://gerrit.cloudera.org:8080/20550
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iccc3c6d1f33804c0e4958c040a41bcfbb4c1d4e0
Gerrit-Change-Number: 20550
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>