You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Wendy Smoak <ws...@gmail.com> on 2008/07/31 22:11:55 UTC
Re: Releasng the war and deploy plugins
On Fri, May 9, 2008 at 1:38 PM, Olivier Lamy <ol...@apache.org> wrote:
> Hi,
> No objections.
> But currently the war plugin trunk depends on other snapshots :
> - org.apache.maven.plugins:maven-invoker-plugin:1.2-SNAPSHOT
> - org.apache.maven.shared:maven-filtering:1.0-alpha-1-SNAPSHOT
>
> The first one has one issue open.
> The second one is a new shared component which IMHO can be released.
I *think* this has all been resolved now. I'll take another look at
these tomorrow and see if they're ready.
--
Wendy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Releasing Maven Invoker and Maven Invoker Plugin
Posted by Dennis Lundberg <de...@apache.org>.
Dennis Lundberg wrote:
> This MINVOKER-43 issue seems to be hitting a lot of our projects. Is
> there something that's stopping us from releasing Maven Invoker 2.0.9
> and Maven Invoker Plugin 1.2.1?
>
> In JIRA there are only requests for new features left:
> http://jira.codehaus.org/browse/MSHARED/component/13271?selected=com.atlassian.jira.plugin.system.project:component-openissues-panel
>
> http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=true&mode=hide&sorter/order=DESC&sorter/field=priority&resolution=-1&pid=11441&fixfor=-1
>
>
> I'm going to go through the documentation for both, and try to learn
> what they do in the process. If there's nothing holding back their
> releases I'll start preparing them.
I'm just about finished going through the documentation now. Maven
Invoker is OK, but for the plugin I have a couple of suggestions.
Hopefully someone more familiar with the plugin can help out with these.
I'd like to see a directory layout of a project with one IT in it on the
usage page, that matches with the configuration on that page. Many of
the different concepts are described in the various examples, but I
still can't "get" the big picture. I think a directory layout would help
with this. This should include files like settings.xml, goals.txt,
verify.bsh, pom.xml and build.log. Examples of the contents of
goals.txt, pom.xml and build.log would also be good.
Also a step-by-step walk-through of what happens (related to this
plugin) when you run 'mvn integration-test' would be a nice addition.
> Benjamin Bentmann wrote:
>> Hi Wendy,
>>
>>> Olivier, would you be able to make the change you describe below on
>>> the deploy plugin trunk?
>>
>> The "small change" is to switch back to using the Install Plugin to
>> stage the artifact under test into the IT repo. I hope Oliver doesn't
>> mind that I went for this ;-)
>>
>>> Or can you explain how to reproduce the problem *without* doing a
>>> release, so I can tell that what I'm adding to the pom fixes it?
>>
>> Steps to reproduce the problem on maven-deploy-plugin trunk:
>> - Enable snapshot repo for the ITs, e.g. add apache.snapshots to the
>> src/it/settings.xml
>> - Remove the execution of install:install-file I added in r681943
>> - Run "mvn clean verify"
>> - Check the target/its/mdeploy-45-test/build.log for this line
>>> [DEBUG] maven-deploy-plugin: resolved to version
>>> 2.4-20080802.034406-6 from repository apache.snapshots
>> which should have been
>>> [DEBUG] maven-deploy-plugin: using locally installed snapshot
>> if MINVOKER-43 wouldn't exist.
>>
>> In other words, the IT is not testing your locally build artifact.
>> This need not fail the tests as long as the snapshot erroneouly pulled
>> in from remote is good/recent enough, but the IT remains broken.
>>
>>
>> Benjamin
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
>
>
--
Dennis Lundberg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Releasing Maven Invoker and Maven Invoker Plugin
Posted by Benjamin Bentmann <be...@udo.edu>.
Dennis Lundberg wrote:
> Is there something that's stopping us from releasing Maven Invoker 2.0.9
> and Maven Invoker Plugin 1.2.1?
Not that I know of. I know Oliver had similar plans, so you two should
probably sync.
Benjamin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Releasing Maven Invoker and Maven Invoker Plugin (was: Releasng the
war and deploy plugins)
Posted by Dennis Lundberg <de...@apache.org>.
This MINVOKER-43 issue seems to be hitting a lot of our projects. Is
there something that's stopping us from releasing Maven Invoker 2.0.9
and Maven Invoker Plugin 1.2.1?
In JIRA there are only requests for new features left:
http://jira.codehaus.org/browse/MSHARED/component/13271?selected=com.atlassian.jira.plugin.system.project:component-openissues-panel
http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=true&mode=hide&sorter/order=DESC&sorter/field=priority&resolution=-1&pid=11441&fixfor=-1
I'm going to go through the documentation for both, and try to learn
what they do in the process. If there's nothing holding back their
releases I'll start preparing them.
Benjamin Bentmann wrote:
> Hi Wendy,
>
>> Olivier, would you be able to make the change you describe below on
>> the deploy plugin trunk?
>
> The "small change" is to switch back to using the Install Plugin to
> stage the artifact under test into the IT repo. I hope Oliver doesn't
> mind that I went for this ;-)
>
>> Or can you explain how to reproduce the problem *without* doing a
>> release, so I can tell that what I'm adding to the pom fixes it?
>
> Steps to reproduce the problem on maven-deploy-plugin trunk:
> - Enable snapshot repo for the ITs, e.g. add apache.snapshots to the
> src/it/settings.xml
> - Remove the execution of install:install-file I added in r681943
> - Run "mvn clean verify"
> - Check the target/its/mdeploy-45-test/build.log for this line
>> [DEBUG] maven-deploy-plugin: resolved to version 2.4-20080802.034406-6
>> from repository apache.snapshots
> which should have been
>> [DEBUG] maven-deploy-plugin: using locally installed snapshot
> if MINVOKER-43 wouldn't exist.
>
> In other words, the IT is not testing your locally build artifact. This
> need not fail the tests as long as the snapshot erroneouly pulled in
> from remote is good/recent enough, but the IT remains broken.
>
>
> Benjamin
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
--
Dennis Lundberg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Releasng the war and deploy plugins
Posted by Olivier Lamy <ol...@apache.org>.
Yes (after my week-end ;-) ).
--
Olivier
2008/8/3 Wendy Smoak <ws...@gmail.com>:
> On Sat, Aug 2, 2008 at 6:48 AM, Benjamin Bentmann
> <be...@udo.edu> wrote:
>
>> So, I assume your local POM states 2.4 as the version, right?
>
> Perhaps when it failed during the release, but not when I was just
> building the snapshot locally. Whatever you changed seems to have
> fixed it, though. Thanks. :)
>
> And the deploy plugin release is staged.
>
> The war plugin is blocked by a snapshot depedency on the new
> maven-filtering component. Looks like the vote on an initial release
> for that wasn't successful. Olivier, are you planning to re-try it
> soon?
>
> --
> Wendy
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
AW: Releasng the war and deploy plugins
Posted by "Annies, Sebastian" <se...@coremedia.com>.
Thank you, Benjamin
as it seems you just downgraded to parent 11 and everything works.
Is it ready for release now? I'd like to finally use it!
Grüße,
Sebastian
-----Ursprüngliche Nachricht-----
Von: Stephane Nicoll [mailto:stephane.nicoll@gmail.com]
Gesendet: Freitag, 8. August 2008 23:01
An: Maven Developers List
Betreff: Re: Releasng the war and deploy plugins
Mmmm as far as I can tell it could be related to the changes in the MINVOKER
configuration. You may want to have a look to the history of the pom and
revert the hack.
Best,
Stéphane
On Fri, Aug 8, 2008 at 10:56 PM, Wendy Smoak <ws...@gmail.com> wrote:
> On Sat, Aug 2, 2008 at 7:49 PM, Wendy Smoak <ws...@gmail.com> wrote:
>
> > The war plugin is blocked by a snapshot depedency on the new
> > maven-filtering component. Looks like the vote on an initial release
> > for that wasn't successful. Olivier, are you planning to re-try it
> > soon?
>
> It was *so* close. Now the war plugin is blocked by a snapshot of the
> maven-plugins parent. I tried going back to the released version 11,
> but that breaks the build.
>
> If someone would like to adjust things so maven-war-plugin builds with
> the released parent, then I'll stage it and call a vote. Otherwise
> I'll watch for the parent pom releases and try again after that.
>
> --
> Wendy
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
--
Large Systems Suck: This rule is 100% transitive. If you build one, you
suck" -- S.Yegge
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Releasng the war and deploy plugins
Posted by Stephane Nicoll <st...@gmail.com>.
Mmmm as far as I can tell it could be related to the changes in the MINVOKER
configuration. You may want to have a look to the history of the pom and
revert the hack.
Best,
Stéphane
On Fri, Aug 8, 2008 at 10:56 PM, Wendy Smoak <ws...@gmail.com> wrote:
> On Sat, Aug 2, 2008 at 7:49 PM, Wendy Smoak <ws...@gmail.com> wrote:
>
> > The war plugin is blocked by a snapshot depedency on the new
> > maven-filtering component. Looks like the vote on an initial release
> > for that wasn't successful. Olivier, are you planning to re-try it
> > soon?
>
> It was *so* close. Now the war plugin is blocked by a snapshot of the
> maven-plugins parent. I tried going back to the released version 11,
> but that breaks the build.
>
> If someone would like to adjust things so maven-war-plugin builds with
> the released parent, then I'll stage it and call a vote. Otherwise
> I'll watch for the parent pom releases and try again after that.
>
> --
> Wendy
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
--
Large Systems Suck: This rule is 100% transitive. If you build one, you
suck" -- S.Yegge
Re: Releasng the war and deploy plugins
Posted by Wendy Smoak <ws...@gmail.com>.
On Sat, Aug 2, 2008 at 7:49 PM, Wendy Smoak <ws...@gmail.com> wrote:
> The war plugin is blocked by a snapshot depedency on the new
> maven-filtering component. Looks like the vote on an initial release
> for that wasn't successful. Olivier, are you planning to re-try it
> soon?
It was *so* close. Now the war plugin is blocked by a snapshot of the
maven-plugins parent. I tried going back to the released version 11,
but that breaks the build.
If someone would like to adjust things so maven-war-plugin builds with
the released parent, then I'll stage it and call a vote. Otherwise
I'll watch for the parent pom releases and try again after that.
--
Wendy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Releasng the war and deploy plugins
Posted by Wendy Smoak <ws...@gmail.com>.
On Sat, Aug 2, 2008 at 6:48 AM, Benjamin Bentmann
<be...@udo.edu> wrote:
> So, I assume your local POM states 2.4 as the version, right?
Perhaps when it failed during the release, but not when I was just
building the snapshot locally. Whatever you changed seems to have
fixed it, though. Thanks. :)
And the deploy plugin release is staged.
The war plugin is blocked by a snapshot depedency on the new
maven-filtering component. Looks like the vote on an initial release
for that wasn't successful. Olivier, are you planning to re-try it
soon?
--
Wendy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Releasng the war and deploy plugins
Posted by Benjamin Bentmann <be...@udo.edu>.
Wendy Smoak wrote:
> Strangely, the integration test for MDEPLOY-45 is now failing for me,
> complaining that it can't find maven-deploy-plugin 2.4-SNAPSHOT
> [...]
> I'd swear it worked initially, then
> failed when I tried to release, and now it's failing just with 'mvn
> install'.
So, I assume your local POM states 2.4 as the version, right? Then it
should only be a matter of a bad IT POM: It literally specified
"2.4-SNAPSHOT" as the version for the plugin instead of "@pom.version@"
which is replaced by the Invoker Plugin with the actual version. I fixed
that in r681974 but better you have a second look at the IT POM yourself
since I am not familiar with its intention.
Benjamin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Releasng the war and deploy plugins
Posted by Wendy Smoak <ws...@gmail.com>.
On Sat, Aug 2, 2008 at 2:09 AM, Benjamin Bentmann
<be...@udo.edu> wrote:
> The "small change" is to switch back to using the Install Plugin to stage
> the artifact under test into the IT repo. I hope Oliver doesn't mind that I
> went for this ;-)
Thanks!
Strangely, the integration test for MDEPLOY-45 is now failing for me,
complaining that it can't find maven-deploy-plugin 2.4-SNAPSHOT in
either central or local.central. It's definitely there in my local
repo.
I thought mirrorOf=* in my settings.xml might be causing problems but
removing that didn't help. Hudson says it's fine so it must be
something wrong on my side. I'd swear it worked initially, then
failed when I tried to release, and now it's failing just with 'mvn
install'.
Here's the output from the it during the failed release:
http://people.apache.org/~wsmoak/maven/maven-deploy-plugin-failed-release-it45-build-log.txt
--
Wendy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Releasng the war and deploy plugins
Posted by Benjamin Bentmann <be...@udo.edu>.
Hi Wendy,
> Olivier, would you be able to make the change you describe below on
> the deploy plugin trunk?
The "small change" is to switch back to using the Install Plugin to
stage the artifact under test into the IT repo. I hope Oliver doesn't
mind that I went for this ;-)
> Or can you explain how to reproduce the problem *without* doing a
> release, so I can tell that what I'm adding to the pom fixes it?
Steps to reproduce the problem on maven-deploy-plugin trunk:
- Enable snapshot repo for the ITs, e.g. add apache.snapshots to the
src/it/settings.xml
- Remove the execution of install:install-file I added in r681943
- Run "mvn clean verify"
- Check the target/its/mdeploy-45-test/build.log for this line
> [DEBUG] maven-deploy-plugin: resolved to version 2.4-20080802.034406-6 from repository apache.snapshots
which should have been
> [DEBUG] maven-deploy-plugin: using locally installed snapshot
if MINVOKER-43 wouldn't exist.
In other words, the IT is not testing your locally build artifact. This
need not fail the tests as long as the snapshot erroneouly pulled in
from remote is good/recent enough, but the IT remains broken.
Benjamin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Releasng the war and deploy plugins
Posted by Wendy Smoak <ws...@gmail.com>.
I started a separate thread to see if someone can look at MWAR-133,
but it looks like the deploy plugin is ready to go.
Olivier, would you be able to make the change you describe below on
the deploy plugin trunk?
Or can you explain how to reproduce the problem *without* doing a
release, so I can tell that what I'm adding to the pom fixes it?
Thanks,
Wendy
On Thu, Jul 31, 2008 at 1:18 PM, Olivier Lamy <ol...@apache.org> wrote:
> Hi,
> Due to MINVOKER-43, you can't release it with the current trunk
> without a small change :-(.
> You have to disable the feature from the version 1.2 [1] or use the
> workaround like this commit [2].
>
> --
> Olivier
>
> [1] http://maven.apache.org/plugins/maven-invoker-plugin/examples/fast-use.html
> [2] http://svn.apache.org/viewvc?view=rev&revision=680385
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Releasng the war and deploy plugins
Posted by Olivier Lamy <ol...@apache.org>.
Hi,
Due to MINVOKER-43, you can't release it with the current trunk
without a small change :-(.
You have to disable the feature from the version 1.2 [1] or use the
workaround like this commit [2].
--
Olivier
[1] http://maven.apache.org/plugins/maven-invoker-plugin/examples/fast-use.html
[2] http://svn.apache.org/viewvc?view=rev&revision=680385
2008/7/31 Wendy Smoak <ws...@gmail.com>:
> On Fri, May 9, 2008 at 1:38 PM, Olivier Lamy <ol...@apache.org> wrote:
>> Hi,
>> No objections.
>> But currently the war plugin trunk depends on other snapshots :
>> - org.apache.maven.plugins:maven-invoker-plugin:1.2-SNAPSHOT
>> - org.apache.maven.shared:maven-filtering:1.0-alpha-1-SNAPSHOT
>>
>> The first one has one issue open.
>> The second one is a new shared component which IMHO can be released.
>
> I *think* this has all been resolved now. I'll take another look at
> these tomorrow and see if they're ready.
>
> --
> Wendy
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org