Re: [PR] Kafka metrics [beam]

["Abacn (via GitHub)" <gi...@apache.org>]

Abacn commented on code in PR #32402:
URL: https://github.com/apache/beam/pull/32402#discussion_r1872386710


##########
runners/google-cloud-dataflow-java/worker/build.gradle:
##########
@@ -54,6 +54,7 @@ def sdk_provided_project_dependencies = [
         ":runners:google-cloud-dataflow-java",
         ":sdks:java:extensions:avro",
         ":sdks:java:extensions:google-cloud-platform-core",
+        ":sdks:java:io:kafka", // For metric propagation into worker

Review Comment:
   This is bad code coupling. Fetching static name isn't sufficient justification to introduce this mandatory dependency to Dataflow worker jar. This also makes confluent repository mandatory for user project.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org