You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Sergey Shelukhin <se...@hortonworks.com> on 2013/12/02 22:18:20 UTC
Re: Review Request 15869: HIVE-5895 vectorization handles division by zero
differently from normal execution
> On Nov. 27, 2013, 7:02 p.m., Eric Hanson wrote:
> > ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideScalar.txt, line 73
> > <https://reviews.apache.org/r/15869/diff/1/?file=391378#file391378line73>
> >
> > you could simplify this to set the output to repeating and make it null, since all outputs will be null if value == 0
that's what I do if there's no selected in use; should it be done also w/selected?
> On Nov. 27, 2013, 7:02 p.m., Eric Hanson wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColDivideLongScalar.java, line 72
> > <https://reviews.apache.org/r/15869/diff/1/?file=391381#file391381line72>
> >
> > same thing -- output will be null and repeating so you can simplify
same as above
> On Nov. 27, 2013, 7:02 p.m., Eric Hanson wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColDivideLongColumn.java, line 101
> > <https://reviews.apache.org/r/15869/diff/1/?file=391380#file391380line101>
> >
> > I think the output will be always all nulls in this case so you can simplify it to always set output to repeating and null.
same as above
- Sergey
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15869/#review29493
-----------------------------------------------------------
On Nov. 27, 2013, 2:20 a.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15869/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2013, 2:20 a.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-5895 vectorization handles division by zero differently from normal execution
>
>
> Diffs
> -----
>
> ant/src/org/apache/hadoop/hive/ant/GenVectorCode.java 5dc50d6
> ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideColumn.txt PRE-CREATION
> ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideScalar.txt PRE-CREATION
> ql/src/gen/vectorization/ExpressionTemplates/ScalarDivideColumn.txt PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColDivideLongColumn.java 482df3c
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColDivideLongScalar.java 7d517ca
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongScalarDivideLongColumn.java e1ecefa
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/NullUtil.java e1867a2
> ql/src/test/queries/clientpositive/vectorization_div0.q PRE-CREATION
> ql/src/test/results/clientpositive/vectorization_div0.q.out PRE-CREATION
> ql/src/test/results/clientpositive/vectorization_short_regress.q.out c9296e1
>
> Diff: https://reviews.apache.org/r/15869/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>