You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by mike-jumper <gi...@git.apache.org> on 2017/06/25 20:39:05 UTC

[GitHub] incubator-guacamole-manual pull request #46: GUACAMOLE-203: Update SSH docum...

Github user mike-jumper commented on a diff in the pull request:

    https://github.com/apache/incubator-guacamole-manual/pull/46#discussion_r123908400
  
    --- Diff: src/chapters/configuring.xml ---
    @@ -2772,6 +2794,24 @@ ed272546-87bd-4db9-acba-e36e1a9ca20a
                                             session will use the user's default shell.</para>
                                     </entry>
                                 </row>
    +                            <row>
    +                                <entry><parameter>server-alive-interval</parameter></entry>
    +                                <entry>
    +                                    <para>
    +                                        <indexterm>
    +                                            <primary>SSH</primary>
    +                                            <secondary>server-alive-interval</secondary>
    +                                        </indexterm>
    +                                        By default the SSH client does not send keepalive requests
    +                                        to the server.  This parameter allows you to configure the
    +                                        the interval (in seconds) at which the client connection
    +                                        sends keepalive packets to the server.  The default is 0,
    +                                        which disables sending the packets.  A value of 1 is
    --- End diff --
    
    > ... A value of 1 is automatically increased to 2.  Negative values are set to 0, disabling sending keepalives.
    
    The "default is zero, one becomes two, negative becomes zero" description seems convoluted/confusing. It makes sense in the code, but this description borders on being pseudocode.
    
    Wouldn't it be easier to understand as simply being disabled by default, with the minimum legal value being 2?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---