You are viewing a plain text version of this content. The canonical link for it is here.

Posted to yarn-issues@hadoop.apache.org by "Zhijie Shen (JIRA)" <ji...@apache.org> on 2015/03/02 18:35:04 UTC

[jira] [Commented] (YARN-3210) [Source organization] Refactor timeline aggregator according to new code organization

    [ https://issues.apache.org/jira/browse/YARN-3210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14343429#comment-14343429 ] 

Zhijie Shen commented on YARN-3210:
-----------------------------------

Thanks for the patch. Two quick comments:

1. Can we remove the build dependency on timeline service in NM module?

2. Shall we call AppLevelTimelineAggregatorsCollection instead of TimelineAggregatorsCollection? Looking into the detail, it's not the collection of any aggregator that extends BaseTimelineAggregator, but the particular AppLevelTimelineAggregator.

> [Source organization] Refactor timeline aggregator according to new code organization
> -------------------------------------------------------------------------------------
>
>                 Key: YARN-3210
>                 URL: https://issues.apache.org/jira/browse/YARN-3210
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Li Lu
>            Assignee: Li Lu
>              Labels: refactor
>         Attachments: YARN-3210-022715.patch
>
>
> We may want to refactor the code of timeline aggregator according to the discussion of YARN-3166, the code organization for timeline service v2. We need to refactor the code after we reach an agreement on the aggregator part of YARN-3166. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)