[GitHub] [incubator-doris] imay commented on a change in pull request #1915: Add address reuesd option for http server

[GitBox <gi...@apache.org>]

imay commented on a change in pull request #1915: Add address reuesd option for http server
URL: https://github.com/apache/incubator-doris/pull/1915#discussion_r329397950
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/http/HttpServer.java
 ##########
 @@ -216,7 +221,14 @@ public void run() {
     // used for test, release bound port
     public void shutDown() {
         if (serverBootstrap != null) {
-            serverBootstrap.config().group().shutdownGracefully(0, 5, TimeUnit.SECONDS).awaitUninterruptibly();
+            serverBootstrap.config().childGroup().shutdownGracefully();
+            Future future = serverBootstrap.config().group().shutdownGracefully(0, 1, TimeUnit.SECONDS).syncUninterruptibly();
+            try {
+                future.get();
+                LOG.info("Http Server was closed completely");
+            } catch (Throwable e) {
+                e.printStackTrace();
 
 Review comment:
   change it to LOG?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org