You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/26 12:06:46 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #4380: Add check for nested types in equivalent names and types
alamb opened a new pull request, #4380:
URL: https://github.com/apache/arrow-datafusion/pull/4380
# Which issue does this PR close?
re https://github.com/apache/arrow-datafusion/pull/4347/files
# Rationale for this change
per @mingmwang 's suggestion, handle field equivalence checks for nested types: https://github.com/apache/arrow-datafusion/pull/4347/files#r1031012003
# What changes are included in this PR?
1. Check equivalences for nested types
2. Tests
# Are these changes tested?
Yes
# Are there any user-facing changes?
No (fewer potential false positives in optimizer checks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #4380: Add check for nested types in equivalent names and types
Posted by GitBox <gi...@apache.org>.
alamb merged PR #4380:
URL: https://github.com/apache/arrow-datafusion/pull/4380
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #4380: Add check for nested types in equivalent names and types
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #4380:
URL: https://github.com/apache/arrow-datafusion/pull/4380#issuecomment-1333899938
Benchmark runs are scheduled for baseline = ebb475e871294316dbe0d0bf23554a99dd44fd31 and contender = a0485e7e0fc69aa5dca35339108142a0fd1dc703. a0485e7e0fc69aa5dca35339108142a0fd1dc703 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/e25d3ddac5f24f6ab2eedbf56eae23d3...03aed9136f1b4325beae90ae8d35faef/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/8dcfccf03d284947889178faedce1f1b...2f999fbb339d41fdac2228ae4abc5808/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/82de8df769a44023a487bfbc75625a02...964e5a61381b453782c8e41264fe39b3/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/d6edfe1c5bb44b5ca4e71d63178cca35...cf3944e59f224206b57677d015b6f12e/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] mingmwang commented on pull request #4380: Add check for nested types in equivalent names and types
Posted by GitBox <gi...@apache.org>.
mingmwang commented on PR #4380:
URL: https://github.com/apache/arrow-datafusion/pull/4380#issuecomment-1330034985
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org