You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by rdblue <gi...@git.apache.org> on 2018/08/22 21:35:23 UTC

[GitHub] spark pull request #22190: [SPARK-25188][SQL] Add WriteConfig to v2 write AP...

Github user rdblue commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22190#discussion_r212118021
  
    --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala ---
    @@ -279,10 +277,7 @@ private[kafka010] class KafkaSourceProvider extends DataSourceRegister
         // We convert the options argument from V2 -> Java map -> scala mutable -> scala immutable.
         val producerParams = kafkaParamsForProducer(options.asMap.asScala.toMap)
     
    -    KafkaWriter.validateQuery(
    --- End diff --
    
    This query validation happens in `KafkaStreamingWriteSupport`. It was duplicated here and in that class. Now, it happens just once when creating the scan config.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org