You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by jo...@apache.org on 2016/08/04 00:52:08 UTC
mesos git commit: Fixed sign comparisons in logrotate module.
Repository: mesos
Updated Branches:
refs/heads/master c4975c99b -> 08d07248e
Fixed sign comparisons in logrotate module.
Review: https://reviews.apache.org/r/50775/
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/08d07248
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/08d07248
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/08d07248
Branch: refs/heads/master
Commit: 08d07248ebc7ab46fceb35a4fe645d2b191433d5
Parents: c4975c9
Author: Joseph Wu <jo...@mesosphere.io>
Authored: Wed Aug 3 17:51:40 2016 -0700
Committer: Joseph Wu <jo...@apache.org>
Committed: Wed Aug 3 17:51:50 2016 -0700
----------------------------------------------------------------------
src/slave/container_loggers/lib_logrotate.hpp | 2 +-
src/slave/container_loggers/logrotate.hpp | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/08d07248/src/slave/container_loggers/lib_logrotate.hpp
----------------------------------------------------------------------
diff --git a/src/slave/container_loggers/lib_logrotate.hpp b/src/slave/container_loggers/lib_logrotate.hpp
index 6fe38d1..f216548 100644
--- a/src/slave/container_loggers/lib_logrotate.hpp
+++ b/src/slave/container_loggers/lib_logrotate.hpp
@@ -132,7 +132,7 @@ struct Flags : public virtual flags::FlagsBase
static Option<Error> validateSize(const Bytes& value)
{
- if (value.bytes() < os::pagesize()) {
+ if (value.bytes() < static_cast<uint64_t>(os::pagesize())) {
return Error(
"Expected --max_stdout_size and --max_stderr_size of "
"at least " + stringify(os::pagesize()) + " bytes");
http://git-wip-us.apache.org/repos/asf/mesos/blob/08d07248/src/slave/container_loggers/logrotate.hpp
----------------------------------------------------------------------
diff --git a/src/slave/container_loggers/logrotate.hpp b/src/slave/container_loggers/logrotate.hpp
index f906a16..96697d4 100644
--- a/src/slave/container_loggers/logrotate.hpp
+++ b/src/slave/container_loggers/logrotate.hpp
@@ -57,7 +57,7 @@ struct Flags : public virtual flags::FlagsBase
"Defaults to 10 MB. Must be at least 1 (memory) page.",
Megabytes(10),
[](const Bytes& value) -> Option<Error> {
- if (value.bytes() < os::pagesize()) {
+ if (value.bytes() < static_cast<uint64_t>(os::pagesize())) {
return Error(
"Expected --max_size of at least " +
stringify(os::pagesize()) + " bytes");