You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2023/02/15 18:35:52 UTC
[GitHub] [ozone] adoroszlai opened a new pull request, #4281: HDDS-7976. FsShell creates unrelated trace spans
adoroszlai opened a new pull request, #4281:
URL: https://github.com/apache/ozone/pull/4281
## What changes were proposed in this pull request?
Create a main span in `OzoneFsShell` to encompass spans created by inner method calls, similar to how `OzoneShell`, `OzoneAdmin` etc. do it.
https://issues.apache.org/jira/browse/HDDS-7976
## How was this patch tested?
```
cd hadoop-ozone/dist/target/ozone-1.4.0-SNAPSHOT/compose/ozone
export COMPOSE_FILE=docker-compose.yaml:monitoring.yaml
./run.sh -d
sleep 60
docker-compose exec scm ozone fs -mkdir ofs://om/vol1
open http://localhost:16686
```
Regular CI:
https://github.com/adoroszlai/hadoop-ozone/actions/runs/4186458710
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #4281: HDDS-7976. FsShell creates unrelated trace spans
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #4281:
URL: https://github.com/apache/ozone/pull/4281
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #4281: HDDS-7976. FsShell creates unrelated trace spans
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #4281:
URL: https://github.com/apache/ozone/pull/4281#issuecomment-1433047458
> Is it possible to log arguments (argv) of the shell in the span?
I hope so. I have filed a follow-up task for that (HDDS-7978) because it affects other CLI commands, not only `ozone fs`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #4281: HDDS-7976. FsShell creates unrelated trace spans
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #4281:
URL: https://github.com/apache/ozone/pull/4281#issuecomment-1433765899
Thanks @jojochuang for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org