You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@carbondata.apache.org by aj...@apache.org on 2020/09/23 04:57:22 UTC
[carbondata] branch master updated: [CARBONDATA-4000] Presto select
query failure right after firing update query.
This is an automated email from the ASF dual-hosted git repository.
ajantha pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/carbondata.git
The following commit(s) were added to refs/heads/master by this push:
new 0b752bb [CARBONDATA-4000] Presto select query failure right after firing update query.
0b752bb is described below
commit 0b752bb04d0040ac0430cd40220d329b697b9f5d
Author: akkio-97 <ak...@gmail.com>
AuthorDate: Mon Sep 21 14:41:07 2020 +0530
[CARBONDATA-4000] Presto select query failure right after firing update query.
Why is this PR needed?
The putObject() method implementation was missing due to which select query on struct complex data type after update queries were failing.
What changes were proposed in this PR?
Added implementation in ColumnarVectorWrapperDirectWithDeleteDelta. Earlier without this implementation control went to its parent class AbstractCarbonColumnarVector,java which was unsupported.
Does this PR introduce any user interface change?
No
Is any new testcase added?
No
This closes #3943
---
.../ColumnarVectorWrapperDirectWithDeleteDelta.java | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/core/src/main/java/org/apache/carbondata/core/scan/result/vector/impl/directread/ColumnarVectorWrapperDirectWithDeleteDelta.java b/core/src/main/java/org/apache/carbondata/core/scan/result/vector/impl/directread/ColumnarVectorWrapperDirectWithDeleteDelta.java
index 30efbb0..b3111c8 100644
--- a/core/src/main/java/org/apache/carbondata/core/scan/result/vector/impl/directread/ColumnarVectorWrapperDirectWithDeleteDelta.java
+++ b/core/src/main/java/org/apache/carbondata/core/scan/result/vector/impl/directread/ColumnarVectorWrapperDirectWithDeleteDelta.java
@@ -59,6 +59,17 @@ class ColumnarVectorWrapperDirectWithDeleteDelta extends AbstractCarbonColumnarV
}
@Override
+ public void putObject(int rowId, Object obj) {
+ if (!deletedRows.get(rowId)) {
+ if (nullBits.get(rowId)) {
+ columnVector.putNull(counter++);
+ } else {
+ columnVector.putObject(counter++, obj);
+ }
+ }
+ }
+
+ @Override
public void putFloat(int rowId, float value) {
if (!deletedRows.get(rowId)) {
if (nullBits.get(rowId)) {