[GitHub] [pulsar] Nicklee007 commented on a diff in pull request #16325: [fix][broker] fix the local police IsolationGroups cover the defaultIsolationGroups when init managedLedger bookkeeper client

[GitBox <gi...@apache.org>]

Nicklee007 commented on code in PR #16325:
URL: https://github.com/apache/pulsar/pull/16325#discussion_r931776838


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/BookKeeperClientFactoryImpl.java:
##########
@@ -71,9 +71,7 @@ public BookKeeper create(ServiceConfiguration conf, MetadataStoreExtended store,
         MetadataDrivers.registerClientDriver("metadata-store", PulsarMetadataClientDriver.class);
 
         ClientConfiguration bkConf = createBkClientConfiguration(store, conf);
-        if (properties != null) {
-            properties.forEach((key, value) -> bkConf.setProperty(key, value));
-        }
+

Review Comment:
   As the Isolation logic, if we set the isolation policy in bkConf,  when invoke  `newEnsemble` or `replaceBookie`  in `solatedBookieEnsemblePlacementPolicy` as  follow we also can use the policy setting to choice bookies, even we do not set the properties in here; It like do not cause breaking;
   Cancel the properties setting in here is do not want the dynamic local policy covey the properties in broker.conf
   
   https://github.com/apache/pulsar/blob/4c6989c4da6c0b18c9b0196630e03daf437cea68/pulsar-broker-common/src/main/java/org/apache/pulsar/bookie/rackawareness/IsolatedBookieEnsemblePlacementPolicy.java#L146-L160



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org