[GitHub] [iceberg] chenjunjiedada commented on a diff in pull request #4769: Api: add sequenceNumber method

[GitBox <gi...@apache.org>]

chenjunjiedada commented on code in PR #4769:
URL: https://github.com/apache/iceberg/pull/4769#discussion_r930072100


##########
core/src/main/java/org/apache/iceberg/BaseFile.java:
##########
@@ -205,6 +207,15 @@ void setSpecId(int specId) {
     this.partitionSpecId = specId;
   }
 
+  @Override
+  public Long sequenceNumber() {
+    return sequenceNumber;
+  }
+
+  void setSequenceNumber(Long seq) {

Review Comment:
   I found we actually do clean up delete files when applying the snapshot update by comparing the min-sequence-number of the generated manifests.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org