You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "srielau (via GitHub)" <gi...@apache.org> on 2023/02/10 19:58:14 UTC
[GitHub] [spark] srielau commented on a diff in pull request #39951: [SPARK-42312][SQL] Assign name to _LEGACY_ERROR_TEMP_0042
srielau commented on code in PR #39951:
URL: https://github.com/apache/spark/pull/39951#discussion_r1103170279
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -998,6 +998,12 @@
},
"sqlState" : "42K07"
},
+ "INVALID_SET_SYNTAX" : {
+ "message" : [
+ "Expected format is 'SET', 'SET key', or 'SET key=value'. If you want to include special characters in key, or include semicolon in value, please use quotes, e.g., SET `key`=`value`."
Review Comment:
```suggestion
"Expected format is 'SET', 'SET key', or 'SET key=value'. If you want to include special characters in key, or include semicolon in value, please use backquotes, e.g., SET `key`=`value`."
```
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -998,6 +998,12 @@
},
"sqlState" : "42K07"
},
+ "INVALID_SET_SYNTAX" : {
+ "message" : [
+ "Expected format is 'SET', 'SET key', or 'SET key=value'. If you want to include special characters in key, or include semicolon in value, please use quotes, e.g., SET `key`=`value`."
Review Comment:
Is the value back ticked as well? That seems weird. Or is the example wrong and it should be quotes for both?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org