You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by st...@apache.org on 2020/04/06 19:42:05 UTC

[hbase] branch branch-2.3 updated (6f23e09 -> 71bcfea)

This is an automated email from the ASF dual-hosted git repository.

stack pushed a change to branch branch-2.3
in repository https://gitbox.apache.org/repos/asf/hbase.git.


    from 6f23e09  HBASE-24122 Change machine ulimit-l to ulimit-a so dumps full ulimit rather than just 'max locked memory'
     new b75eeb1  Revert "HBASE-24118 [Flakey Tests] TestCloseRegionWhileRSCrash" Reverting in favor of adding an @Ignore on this test until root cause of flakyness HBASE-24117 is addressed.
     new 71bcfea  HBASE-24118 [Flakey Tests] TestCloseRegionWhileRSCrash Reapply but as an @Ignore for the flakey test.

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../master/assignment/TestCloseRegionWhileRSCrash.java  | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)


[hbase] 01/02: Revert "HBASE-24118 [Flakey Tests] TestCloseRegionWhileRSCrash" Reverting in favor of adding an @Ignore on this test until root cause of flakyness HBASE-24117 is addressed.

Posted by st...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

stack pushed a commit to branch branch-2.3
in repository https://gitbox.apache.org/repos/asf/hbase.git

commit b75eeb104d62999aa5452ebd3643644705954220
Author: stack <st...@apache.org>
AuthorDate: Mon Apr 6 12:35:52 2020 -0700

    Revert "HBASE-24118 [Flakey Tests] TestCloseRegionWhileRSCrash"
    Reverting in favor of adding an @Ignore on this test until
    root cause of flakyness HBASE-24117 is addressed.
    
    This reverts commit 9985c06647ef7169b9940cd3b6b24c2ac6a322fc.
---
 .../master/assignment/TestCloseRegionWhileRSCrash.java    | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestCloseRegionWhileRSCrash.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestCloseRegionWhileRSCrash.java
index c0382e4..04e6930 100644
--- a/hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestCloseRegionWhileRSCrash.java
+++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestCloseRegionWhileRSCrash.java
@@ -1,4 +1,4 @@
-/*
+/**
  * Licensed to the Apache Software Foundation (ASF) under one
  * or more contributor license agreements.  See the NOTICE file
  * distributed with this work for additional information
@@ -24,7 +24,9 @@ import org.apache.hadoop.hbase.HBaseTestingUtility;
 import org.apache.hadoop.hbase.ProcedureTestUtil;
 import org.apache.hadoop.hbase.ServerName;
 import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.Put;
 import org.apache.hadoop.hbase.client.RegionInfo;
+import org.apache.hadoop.hbase.client.Table;
 import org.apache.hadoop.hbase.master.HMaster;
 import org.apache.hadoop.hbase.master.ServerManager;
 import org.apache.hadoop.hbase.master.procedure.MasterProcedureEnv;
@@ -190,11 +192,10 @@ public class TestCloseRegionWhileRSCrash {
     // here we start a new master
     UTIL.getMiniHBaseCluster().startMaster();
     t.join();
-    // Make sure that the region is online, it may not be on the original target server, as we will
-    // set forceNewPlan to true if there is a server crash.
-    // DISABLED THIS CHECK. See HBASE-24117.
-    // try (Table table = UTIL.getConnection().getTable(TABLE_NAME)) {
-    //   table.put(new Put(Bytes.toBytes(1)).addColumn(CF, Bytes.toBytes("cq"), Bytes.toBytes(1)));
-    // }
+    // Make sure that the region is online, it may not on the original target server, as we will set
+    // forceNewPlan to true if there is a server crash
+    try (Table table = UTIL.getConnection().getTable(TABLE_NAME)) {
+      table.put(new Put(Bytes.toBytes(1)).addColumn(CF, Bytes.toBytes("cq"), Bytes.toBytes(1)));
+    }
   }
 }


[hbase] 02/02: HBASE-24118 [Flakey Tests] TestCloseRegionWhileRSCrash Reapply but as an @Ignore for the flakey test.

Posted by st...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

stack pushed a commit to branch branch-2.3
in repository https://gitbox.apache.org/repos/asf/hbase.git

commit 71bcfea4c1ca6714c9e0d53575f21a6ffe134ace
Author: stack <st...@apache.org>
AuthorDate: Mon Apr 6 12:38:02 2020 -0700

    HBASE-24118 [Flakey Tests] TestCloseRegionWhileRSCrash
    Reapply but as an @Ignore for the flakey test.
---
 .../hadoop/hbase/master/assignment/TestCloseRegionWhileRSCrash.java     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestCloseRegionWhileRSCrash.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestCloseRegionWhileRSCrash.java
index 04e6930..2bc6d0a 100644
--- a/hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestCloseRegionWhileRSCrash.java
+++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestCloseRegionWhileRSCrash.java
@@ -160,7 +160,7 @@ public class TestCloseRegionWhileRSCrash {
     UTIL.shutdownMiniCluster();
   }
 
-  @Test
+  @org.junit.Ignore @Test // Until root-cause of flakeyness, HBASE-24117, is addressed.
   public void testRetryBackoff() throws IOException, InterruptedException {
     HRegionServer srcRs = UTIL.getRSForFirstRegionInTable(TABLE_NAME);
     RegionInfo region = srcRs.getRegions(TABLE_NAME).get(0).getRegionInfo();