You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/01/13 01:07:41 UTC

[GitHub] [incubator-mxnet] josephevans commented on a change in pull request #19745: [v1.x] Add onnx export support for where and greater_scalar operators.

josephevans commented on a change in pull request #19745:
URL: https://github.com/apache/incubator-mxnet/pull/19745#discussion_r556197198



##########
File path: tests/python-pytest/onnx/test_operators.py
##########
@@ -378,3 +378,27 @@ def test_onnx_export_contrib_BilinearResize2D(tmp_path, dtype, params):
     x = mx.nd.arange(0, 160).reshape((2, 2, 5, 8))
     M = def_model('contrib.BilinearResize2D', **params)
     op_export_test('contrib_BilinearResize2D', M, [x], tmp_path)
+
+
+@pytest.mark.parametrize("dtype", ["float32", "float64", "int32", "int64"])

Review comment:
       Update to work with float16 and also test it :) Thanks for the help.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org