You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/22 21:56:26 UTC
[GitHub] [airflow] pierrejeambrun opened a new pull request #22479: Fix download_media url
pierrejeambrun opened a new pull request #22479:
URL: https://github.com/apache/airflow/pull/22479
Fixes: #14075
Following @sarahamilton draft PR and instructions reported in the issue #14075, here is a small change to fix the download url for `Google Display & Video 360` service.
Link to the API doc: https://developers.google.com/display-video/api/reference/rest/v1/media/download
Link to the underlying lib: https://github.com/googleapis/google-api-python-client/blob/main/googleapiclient/discovery.py
I was not able to create an account on `Google Display & Video 360` to test this. (no free trial, or 'fake' account for devs).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal merged pull request #22479: Fix `download_media` url in `GoogleDisplayVideo360SDFtoGCSOperator`
Posted by GitBox <gi...@apache.org>.
eladkal merged pull request #22479:
URL: https://github.com/apache/airflow/pull/22479
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pierrejeambrun commented on pull request #22479: Fix download_media url
Posted by GitBox <gi...@apache.org>.
pierrejeambrun commented on pull request #22479:
URL: https://github.com/apache/airflow/pull/22479#issuecomment-1075685116
@eladkal here is a quick fix for the issue. :smiley:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #22479: Fix `download_media` url in `GoogleDisplayVideo360SDFtoGCSOperator`
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #22479:
URL: https://github.com/apache/airflow/pull/22479#issuecomment-1076093558
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org