[GitHub] [incubator-gobblin] arjun4084346 commented on a change in pull request #3027: [GOBBLIN-1187] cancel flow execution when dag manager is disabled

[GitBox <gi...@apache.org>]

arjun4084346 commented on a change in pull request #3027:
URL: https://github.com/apache/incubator-gobblin/pull/3027#discussion_r522486541



##########
File path: gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java
##########
@@ -298,24 +296,14 @@ synchronized public void stopDag(URI uri) throws IOException {
   /**
    * Add the specified flow to {@link DagManager#cancelQueue}
    */
-  private void killFlow(String flowGroup, String flowName, long flowExecutionId) throws IOException {
+  void killFlow(String flowGroup, String flowName, long flowExecutionId) throws IOException {
     int queueId =  DagManagerUtils.getDagQueueId(flowExecutionId, this.numThreads);
     String dagId = DagManagerUtils.generateDagId(flowGroup, flowName, flowExecutionId);
     if (!this.cancelQueue[queueId].offer(dagId)) {
       throw new IOException("Could not add dag " + dagId + " to cancellation queue.");
     }
   }
 
-  @Subscribe

Review comment:
       It is doing that, right? see GobblinServiceManager.java




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org