You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by "GAWLAS,JULIUS (HP-Cupertino,ex1)" <ju...@hp.com> on 2001/07/31 18:52:48 UTC
RE: cvs commit: httpd-2.0/modules/ssl ssl_engine_io.c
Bill,
no to pick in details but in your latest fix
> Index: ssl_engine_io.c
> ===================================================================
> RCS file: /home/cvs/httpd-2.0/modules/ssl/ssl_engine_io.c,v
> retrieving revision 1.10
> retrieving revision 1.11
> diff -u -r1.10 -r1.11
> --- ssl_engine_io.c 2001/07/31 03:04:55 1.10
> +++ ssl_engine_io.c 2001/07/31 16:41:13 1.11
> @@ -280,10 +280,9 @@
> return APR_SUCCESS;
> }
>
> - assert(len > 0);
> -
> - n = BIO_write (pRec->pbioRead, data, len);
> - assert(n == len);
> + n = BIO_write (pRec->pbioRead, data, len);
> +
> + assert(n >= 0 && (apr_size_t)n == len);
>
> ssl_hook_process_connection (pRec);
wouldn't it be easier and bit cleaner to simply declare n as apr_size_t?
apr_size_t n;
Julius
Re: cvs commit: httpd-2.0/modules/ssl ssl_engine_io.c
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Not if BIO_write is defined in terms of an int.
----- Original Message -----
From: "GAWLAS,JULIUS (HP-Cupertino,ex1)" <ju...@hp.com>
To: <ne...@apache.org>
Sent: Tuesday, July 31, 2001 11:52 AM
Subject: RE: cvs commit: httpd-2.0/modules/ssl ssl_engine_io.c
> Bill,
>
> no to pick in details but in your latest fix
>
> > Index: ssl_engine_io.c
> > ===================================================================
> > RCS file: /home/cvs/httpd-2.0/modules/ssl/ssl_engine_io.c,v
> > retrieving revision 1.10
> > retrieving revision 1.11
> > diff -u -r1.10 -r1.11
> > --- ssl_engine_io.c 2001/07/31 03:04:55 1.10
> > +++ ssl_engine_io.c 2001/07/31 16:41:13 1.11
> > @@ -280,10 +280,9 @@
> > return APR_SUCCESS;
> > }
> >
> > - assert(len > 0);
> > -
> > - n = BIO_write (pRec->pbioRead, data, len);
> > - assert(n == len);
> > + n = BIO_write (pRec->pbioRead, data, len);
> > +
> > + assert(n >= 0 && (apr_size_t)n == len);
> >
> > ssl_hook_process_connection (pRec);
>
> wouldn't it be easier and bit cleaner to simply declare n as apr_size_t?
>
> apr_size_t n;
>
> Julius
>