You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Dmitry Irlyanov (JIRA)" <ji...@apache.org> on 2007/07/24 11:13:31 UTC
[jira] Created: (HARMONY-4523)
[classlib][swing]BasicSliderUI.ActionScroller should be marked with
notImplementedException
[classlib][swing]BasicSliderUI.ActionScroller should be marked with notImplementedException
-------------------------------------------------------------------------------------------
Key: HARMONY-4523
URL: https://issues.apache.org/jira/browse/HARMONY-4523
Project: Harmony
Issue Type: Task
Components: Classlib
Reporter: Dmitry Irlyanov
Priority: Trivial
Attachments: H4523-BasicSliderUI.patch
BasicSliderUI.ActionScroller class is obsolete since 1.3 (it's indicated in javadoc 1.5) and unimplemented, but the methods aren't marked with NotImplementedExeption
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4523)
[classlib][swing]BasicSliderUI.ActionScroller should be marked with
notImplementedException
Posted by "Dmitry Irlyanov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitry Irlyanov updated HARMONY-4523:
-------------------------------------
Attachment: H4523-BasicSliderUI-way2.patch
> [classlib][swing]BasicSliderUI.ActionScroller should be marked with notImplementedException
> -------------------------------------------------------------------------------------------
>
> Key: HARMONY-4523
> URL: https://issues.apache.org/jira/browse/HARMONY-4523
> Project: Harmony
> Issue Type: Task
> Components: Classlib
> Reporter: Dmitry Irlyanov
> Assignee: Oliver Deakin
> Priority: Trivial
> Attachments: H4523-BasicSliderUI-way1.patch, H4523-BasicSliderUI-way2.patch, H4523-BasicSliderUI.patch
>
>
> BasicSliderUI.ActionScroller class is obsolete since 1.3 (it's indicated in javadoc 1.5) and unimplemented, but the methods aren't marked with NotImplementedExeption
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-4523)
[classlib][swing]BasicSliderUI.ActionScroller should be marked with
notImplementedException
Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12523623 ]
Oliver Deakin commented on HARMONY-4523:
----------------------------------------
Hi Dmitry,
A couple of comments on the patch:
- I think the methods should contain a "throw new NotImplementedException();" so that anyone who calls these methods knows that they are not giving the expected results for a reason. These can be seen in other classes with unimplemented methods (for example, javax.swing.JLabel.AccessibleJLabel). Do you agree?
- After the above change, I see a test failure in javax.swing.plaf.basic.BasicSliderUITest.testActionScrollerEnabled(). This test was added as part of HARMONY-2591 which was concerned with BasicSliderUI.ActionScroller compatibility with the RI. Although this class is described as being "no longer used" in the documentation, perhaps for backward compatility (and RI compatibility) we should keep the isEnabled() method implemented as "return true" and just mark the constructor and actionPerformed methods as not implemented pending future implementation?
> [classlib][swing]BasicSliderUI.ActionScroller should be marked with notImplementedException
> -------------------------------------------------------------------------------------------
>
> Key: HARMONY-4523
> URL: https://issues.apache.org/jira/browse/HARMONY-4523
> Project: Harmony
> Issue Type: Task
> Components: Classlib
> Reporter: Dmitry Irlyanov
> Assignee: Oliver Deakin
> Priority: Trivial
> Attachments: H4523-BasicSliderUI.patch
>
>
> BasicSliderUI.ActionScroller class is obsolete since 1.3 (it's indicated in javadoc 1.5) and unimplemented, but the methods aren't marked with NotImplementedExeption
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4523)
[classlib][swing]BasicSliderUI.ActionScroller should be marked with
notImplementedException
Posted by "Dmitry Irlyanov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitry Irlyanov updated HARMONY-4523:
-------------------------------------
Comment: was deleted
> [classlib][swing]BasicSliderUI.ActionScroller should be marked with notImplementedException
> -------------------------------------------------------------------------------------------
>
> Key: HARMONY-4523
> URL: https://issues.apache.org/jira/browse/HARMONY-4523
> Project: Harmony
> Issue Type: Task
> Components: Classlib
> Reporter: Dmitry Irlyanov
> Assignee: Oliver Deakin
> Priority: Trivial
> Attachments: H4523-BasicSliderUI.patch
>
>
> BasicSliderUI.ActionScroller class is obsolete since 1.3 (it's indicated in javadoc 1.5) and unimplemented, but the methods aren't marked with NotImplementedExeption
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-4523)
[classlib][swing]BasicSliderUI.ActionScroller should be marked with
notImplementedException
Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12523875 ]
Oliver Deakin commented on HARMONY-4523:
----------------------------------------
Yes, that patch is closer to what I was thinking of. Just a couple of small things:
1) Should we put a "throw new NotImplementedException();" into the actionPerformed() method so that anyone calling it is told immediately that it will not behave as expected without inspecting the code?
2) It seems that the implementation of isEnabled() is simply "return enabled". In this case, we could implement this immediately and remove the "throws NotImplementedException" from the method signature. What do you think?
> [classlib][swing]BasicSliderUI.ActionScroller should be marked with notImplementedException
> -------------------------------------------------------------------------------------------
>
> Key: HARMONY-4523
> URL: https://issues.apache.org/jira/browse/HARMONY-4523
> Project: Harmony
> Issue Type: Task
> Components: Classlib
> Reporter: Dmitry Irlyanov
> Assignee: Oliver Deakin
> Priority: Trivial
> Attachments: H4523-BasicSliderUI.patch
>
>
> BasicSliderUI.ActionScroller class is obsolete since 1.3 (it's indicated in javadoc 1.5) and unimplemented, but the methods aren't marked with NotImplementedExeption
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-4523)
[classlib][swing]BasicSliderUI.ActionScroller should be marked with
notImplementedException
Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524716 ]
Oliver Deakin commented on HARMONY-4523:
----------------------------------------
Ah sorry Dmitry, I think you misunderstood 2, I should have been more clear. I didn't mean that the full implementation was "return true;". I meant the implementation is "return enabled;" where enabled is the name of the variable inherited from the AbstractAction class (the superclass of BasicSliderUI.ActionScroller) and indicates if the action is enabled or not. So the method implementation would look like:
public boolean isEnabled() {
return enabled;
}
Thanks Dmitry - I have applied these changes at repo revision r572661. Please verify that they have been applied correctly.
> [classlib][swing]BasicSliderUI.ActionScroller should be marked with notImplementedException
> -------------------------------------------------------------------------------------------
>
> Key: HARMONY-4523
> URL: https://issues.apache.org/jira/browse/HARMONY-4523
> Project: Harmony
> Issue Type: Task
> Components: Classlib
> Reporter: Dmitry Irlyanov
> Assignee: Oliver Deakin
> Priority: Trivial
> Attachments: H4523-BasicSliderUI-way1.patch, H4523-BasicSliderUI-way2.patch, H4523-BasicSliderUI.patch
>
>
> BasicSliderUI.ActionScroller class is obsolete since 1.3 (it's indicated in javadoc 1.5) and unimplemented, but the methods aren't marked with NotImplementedExeption
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4523)
[classlib][swing]BasicSliderUI.ActionScroller should be marked with
notImplementedException
Posted by "Dmitry Irlyanov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitry Irlyanov updated HARMONY-4523:
-------------------------------------
Attachment: H4523-BasicSliderUI.patch
> [classlib][swing]BasicSliderUI.ActionScroller should be marked with notImplementedException
> -------------------------------------------------------------------------------------------
>
> Key: HARMONY-4523
> URL: https://issues.apache.org/jira/browse/HARMONY-4523
> Project: Harmony
> Issue Type: Task
> Components: Classlib
> Reporter: Dmitry Irlyanov
> Assignee: Oliver Deakin
> Priority: Trivial
> Attachments: H4523-BasicSliderUI.patch
>
>
> BasicSliderUI.ActionScroller class is obsolete since 1.3 (it's indicated in javadoc 1.5) and unimplemented, but the methods aren't marked with NotImplementedExeption
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4523)
[classlib][swing]BasicSliderUI.ActionScroller should be marked with
notImplementedException
Posted by "Dmitry Irlyanov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitry Irlyanov updated HARMONY-4523:
-------------------------------------
Attachment: (was: H4523-BasicSliderUI.patch)
> [classlib][swing]BasicSliderUI.ActionScroller should be marked with notImplementedException
> -------------------------------------------------------------------------------------------
>
> Key: HARMONY-4523
> URL: https://issues.apache.org/jira/browse/HARMONY-4523
> Project: Harmony
> Issue Type: Task
> Components: Classlib
> Reporter: Dmitry Irlyanov
> Assignee: Oliver Deakin
> Priority: Trivial
> Attachments: H4523-BasicSliderUI.patch
>
>
> BasicSliderUI.ActionScroller class is obsolete since 1.3 (it's indicated in javadoc 1.5) and unimplemented, but the methods aren't marked with NotImplementedExeption
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4523)
[classlib][swing]BasicSliderUI.ActionScroller should be marked with
notImplementedException
Posted by "Dmitry Irlyanov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitry Irlyanov updated HARMONY-4523:
-------------------------------------
Attachment: H4523-BasicSliderUI.patch
> [classlib][swing]BasicSliderUI.ActionScroller should be marked with notImplementedException
> -------------------------------------------------------------------------------------------
>
> Key: HARMONY-4523
> URL: https://issues.apache.org/jira/browse/HARMONY-4523
> Project: Harmony
> Issue Type: Task
> Components: Classlib
> Reporter: Dmitry Irlyanov
> Priority: Trivial
> Attachments: H4523-BasicSliderUI.patch
>
>
> BasicSliderUI.ActionScroller class is obsolete since 1.3 (it's indicated in javadoc 1.5) and unimplemented, but the methods aren't marked with NotImplementedExeption
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-4523)
[classlib][swing]BasicSliderUI.ActionScroller should be marked with
notImplementedException
Posted by "Dmitry Irlyanov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12523803 ]
Dmitry Irlyanov commented on HARMONY-4523:
------------------------------------------
Thanks Oliver,
You are completely right. I've prepared a new patch.
> [classlib][swing]BasicSliderUI.ActionScroller should be marked with notImplementedException
> -------------------------------------------------------------------------------------------
>
> Key: HARMONY-4523
> URL: https://issues.apache.org/jira/browse/HARMONY-4523
> Project: Harmony
> Issue Type: Task
> Components: Classlib
> Reporter: Dmitry Irlyanov
> Assignee: Oliver Deakin
> Priority: Trivial
> Attachments: H4523-BasicSliderUI.patch
>
>
> BasicSliderUI.ActionScroller class is obsolete since 1.3 (it's indicated in javadoc 1.5) and unimplemented, but the methods aren't marked with NotImplementedExeption
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-4523)
[classlib][swing]BasicSliderUI.ActionScroller should be marked with
notImplementedException
Posted by "Dmitry Irlyanov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitry Irlyanov closed HARMONY-4523.
------------------------------------
Oliver,
Thank you - all is correct
> [classlib][swing]BasicSliderUI.ActionScroller should be marked with notImplementedException
> -------------------------------------------------------------------------------------------
>
> Key: HARMONY-4523
> URL: https://issues.apache.org/jira/browse/HARMONY-4523
> Project: Harmony
> Issue Type: Task
> Components: Classlib
> Reporter: Dmitry Irlyanov
> Assignee: Oliver Deakin
> Priority: Trivial
> Attachments: H4523-BasicSliderUI-way1.patch, H4523-BasicSliderUI-way2.patch, H4523-BasicSliderUI.patch
>
>
> BasicSliderUI.ActionScroller class is obsolete since 1.3 (it's indicated in javadoc 1.5) and unimplemented, but the methods aren't marked with NotImplementedExeption
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-4523)
[classlib][swing]BasicSliderUI.ActionScroller should be marked with
notImplementedException
Posted by "Dmitry Irlyanov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12523806 ]
Dmitry Irlyanov commented on HARMONY-4523:
------------------------------------------
I think the "return true" is preferable too because ActionScroller can be indirectly used in some code
> [classlib][swing]BasicSliderUI.ActionScroller should be marked with notImplementedException
> -------------------------------------------------------------------------------------------
>
> Key: HARMONY-4523
> URL: https://issues.apache.org/jira/browse/HARMONY-4523
> Project: Harmony
> Issue Type: Task
> Components: Classlib
> Reporter: Dmitry Irlyanov
> Assignee: Oliver Deakin
> Priority: Trivial
> Attachments: H4523-BasicSliderUI.patch
>
>
> BasicSliderUI.ActionScroller class is obsolete since 1.3 (it's indicated in javadoc 1.5) and unimplemented, but the methods aren't marked with NotImplementedExeption
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-4523)
[classlib][swing]BasicSliderUI.ActionScroller should be marked with
notImplementedException
Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oliver Deakin reassigned HARMONY-4523:
--------------------------------------
Assignee: Oliver Deakin
> [classlib][swing]BasicSliderUI.ActionScroller should be marked with notImplementedException
> -------------------------------------------------------------------------------------------
>
> Key: HARMONY-4523
> URL: https://issues.apache.org/jira/browse/HARMONY-4523
> Project: Harmony
> Issue Type: Task
> Components: Classlib
> Reporter: Dmitry Irlyanov
> Assignee: Oliver Deakin
> Priority: Trivial
> Attachments: H4523-BasicSliderUI.patch
>
>
> BasicSliderUI.ActionScroller class is obsolete since 1.3 (it's indicated in javadoc 1.5) and unimplemented, but the methods aren't marked with NotImplementedExeption
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4523)
[classlib][swing]BasicSliderUI.ActionScroller should be marked with
notImplementedException
Posted by "Dmitry Irlyanov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitry Irlyanov updated HARMONY-4523:
-------------------------------------
Attachment: (was: H4523-BasicSliderUI.patch)
> [classlib][swing]BasicSliderUI.ActionScroller should be marked with notImplementedException
> -------------------------------------------------------------------------------------------
>
> Key: HARMONY-4523
> URL: https://issues.apache.org/jira/browse/HARMONY-4523
> Project: Harmony
> Issue Type: Task
> Components: Classlib
> Reporter: Dmitry Irlyanov
> Assignee: Oliver Deakin
> Priority: Trivial
> Attachments: H4523-BasicSliderUI.patch
>
>
> BasicSliderUI.ActionScroller class is obsolete since 1.3 (it's indicated in javadoc 1.5) and unimplemented, but the methods aren't marked with NotImplementedExeption
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4523)
[classlib][swing]BasicSliderUI.ActionScroller should be marked with
notImplementedException
Posted by "Dmitry Irlyanov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitry Irlyanov updated HARMONY-4523:
-------------------------------------
Attachment: H4523-BasicSliderUI.patch
Thanks Oliver,
You are completely right. I'm prepared a new patch.
> [classlib][swing]BasicSliderUI.ActionScroller should be marked with notImplementedException
> -------------------------------------------------------------------------------------------
>
> Key: HARMONY-4523
> URL: https://issues.apache.org/jira/browse/HARMONY-4523
> Project: Harmony
> Issue Type: Task
> Components: Classlib
> Reporter: Dmitry Irlyanov
> Assignee: Oliver Deakin
> Priority: Trivial
> Attachments: H4523-BasicSliderUI.patch
>
>
> BasicSliderUI.ActionScroller class is obsolete since 1.3 (it's indicated in javadoc 1.5) and unimplemented, but the methods aren't marked with NotImplementedExeption
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-4523)
[classlib][swing]BasicSliderUI.ActionScroller should be marked with
notImplementedException
Posted by "Dmitry Irlyanov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524698 ]
Dmitry Irlyanov commented on HARMONY-4523:
------------------------------------------
1) Agree
2) I'm not sure that isEnabled method just returns true, maybe it's created for a bit more complex functionality.
But anyway, I'm relying on your commiter' authority and proposing 2 patches: one with "throws NotImplementedException" in the method signature and one without.
> [classlib][swing]BasicSliderUI.ActionScroller should be marked with notImplementedException
> -------------------------------------------------------------------------------------------
>
> Key: HARMONY-4523
> URL: https://issues.apache.org/jira/browse/HARMONY-4523
> Project: Harmony
> Issue Type: Task
> Components: Classlib
> Reporter: Dmitry Irlyanov
> Assignee: Oliver Deakin
> Priority: Trivial
> Attachments: H4523-BasicSliderUI-way1.patch, H4523-BasicSliderUI-way2.patch, H4523-BasicSliderUI.patch
>
>
> BasicSliderUI.ActionScroller class is obsolete since 1.3 (it's indicated in javadoc 1.5) and unimplemented, but the methods aren't marked with NotImplementedExeption
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4523)
[classlib][swing]BasicSliderUI.ActionScroller should be marked with
notImplementedException
Posted by "Dmitry Irlyanov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitry Irlyanov updated HARMONY-4523:
-------------------------------------
Attachment: H4523-BasicSliderUI-way1.patch
> [classlib][swing]BasicSliderUI.ActionScroller should be marked with notImplementedException
> -------------------------------------------------------------------------------------------
>
> Key: HARMONY-4523
> URL: https://issues.apache.org/jira/browse/HARMONY-4523
> Project: Harmony
> Issue Type: Task
> Components: Classlib
> Reporter: Dmitry Irlyanov
> Assignee: Oliver Deakin
> Priority: Trivial
> Attachments: H4523-BasicSliderUI-way1.patch, H4523-BasicSliderUI-way2.patch, H4523-BasicSliderUI.patch
>
>
> BasicSliderUI.ActionScroller class is obsolete since 1.3 (it's indicated in javadoc 1.5) and unimplemented, but the methods aren't marked with NotImplementedExeption
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-4523)
[classlib][swing]BasicSliderUI.ActionScroller should be marked with
notImplementedException
Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oliver Deakin resolved HARMONY-4523.
------------------------------------
Resolution: Fixed
> [classlib][swing]BasicSliderUI.ActionScroller should be marked with notImplementedException
> -------------------------------------------------------------------------------------------
>
> Key: HARMONY-4523
> URL: https://issues.apache.org/jira/browse/HARMONY-4523
> Project: Harmony
> Issue Type: Task
> Components: Classlib
> Reporter: Dmitry Irlyanov
> Assignee: Oliver Deakin
> Priority: Trivial
> Attachments: H4523-BasicSliderUI-way1.patch, H4523-BasicSliderUI-way2.patch, H4523-BasicSliderUI.patch
>
>
> BasicSliderUI.ActionScroller class is obsolete since 1.3 (it's indicated in javadoc 1.5) and unimplemented, but the methods aren't marked with NotImplementedExeption
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.