You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2024/08/13 13:23:09 UTC

[PR] HDDS-11305. Avoid accidental usage of commons-lang v2 [ozone]

adoroszlai opened a new pull request, #7069:
URL: https://github.com/apache/ozone/pull/7069

   ## What changes were proposed in this pull request?
   
   `commons-lang` v2 is a transitive dependency via Hadoop and Ranger.  Ozone and most of its other dependencies use `commons-lang` v3.
   
   The goal of this PR:
   
   - Replace existing usage of `commons-lang` v2 with v3.
   - Ban import of v2 classes to avoid new usage.
   
   https://issues.apache.org/jira/browse/HDDS-11305
   
   ## How was this patch tested?
   
   Tested `pom.xml` change without import changes on `master`:
   
   ```
   [ERROR] Rule 6: org.apache.maven.plugins.enforcer.RestrictImports failed with message:
   [ERROR] 
   [ERROR] Banned imports detected in TEST code:
   [ERROR] 
   [ERROR] Reason: Use commons-lang v3
   [ERROR] 	in hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/TestScmClient.java
   [ERROR] 		static org.apache.commons.lang.RandomStringUtils.randomAlphabetic 	(Line: 46, Matched by: org.apache.commons.lang.**)
   [ERROR] 	in hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/service/TestKeyDeletingService.java
   [ERROR] 		org.apache.commons.lang.RandomStringUtils                         	(Line: 37, Matched by: org.apache.commons.lang.**)
   ```
   
   CI:
   https://github.com/adoroszlai/ozone/actions/runs/10367830837


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-11305. Avoid accidental usage of commons-lang v2 [ozone]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #7069:
URL: https://github.com/apache/ozone/pull/7069


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-11305. Avoid accidental usage of commons-lang v2 [ozone]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #7069:
URL: https://github.com/apache/ozone/pull/7069#issuecomment-2287933532

   Thanks @kerneltime for the review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org