You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/04/21 20:08:02 UTC

[GitHub] [kafka] mjsax commented on pull request #10548: KAFKA-12396 added a nullcheck before trying to retrieve a key

mjsax commented on pull request #10548:
URL: https://github.com/apache/kafka/pull/10548#issuecomment-824325232


   > All of them already had the checks. 
   
   Sweet. I did not double check the code before.
   
   Seems, `put(final Windowed<K> sessionKey,...)` and `remove(final Windowed<K> sessionKey)` don't check for `sessionKey.key() != null` though? Can we add this check?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org