You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by da...@apache.org on 2018/05/23 02:30:30 UTC
lucene-solr:master: SOLR-12247:
NodeAddedTriggerTest.testRestoreState() failure: Did not expect the processor
to fire on first run
Repository: lucene-solr
Updated Branches:
refs/heads/master af59c4636 -> 0a730d4c1
SOLR-12247: NodeAddedTriggerTest.testRestoreState() failure: Did not expect the processor to fire on first run
Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/0a730d4c
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/0a730d4c
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/0a730d4c
Branch: refs/heads/master
Commit: 0a730d4c1a74b6a090e685990e620f482139303f
Parents: af59c46
Author: Cao Manh Dat <da...@apache.org>
Authored: Wed May 23 09:30:19 2018 +0700
Committer: Cao Manh Dat <da...@apache.org>
Committed: Wed May 23 09:30:19 2018 +0700
----------------------------------------------------------------------
.../org/apache/solr/cloud/autoscaling/NodeAddedTriggerTest.java | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/0a730d4c/solr/core/src/test/org/apache/solr/cloud/autoscaling/NodeAddedTriggerTest.java
----------------------------------------------------------------------
diff --git a/solr/core/src/test/org/apache/solr/cloud/autoscaling/NodeAddedTriggerTest.java b/solr/core/src/test/org/apache/solr/cloud/autoscaling/NodeAddedTriggerTest.java
index cd52785..183d154 100644
--- a/solr/core/src/test/org/apache/solr/cloud/autoscaling/NodeAddedTriggerTest.java
+++ b/solr/core/src/test/org/apache/solr/cloud/autoscaling/NodeAddedTriggerTest.java
@@ -254,6 +254,7 @@ public class NodeAddedTriggerTest extends SolrCloudTestCase {
trigger.run();
JettySolrRunner newNode = cluster.startJettySolrRunner();
+ trigger.setProcessor(null); // the processor may get called for old nodes
trigger.run(); // this run should detect the new node
trigger.close(); // close the old trigger
@@ -301,7 +302,9 @@ public class NodeAddedTriggerTest extends SolrCloudTestCase {
assertTrue(fired.get());
TriggerEvent nodeAddedEvent = eventRef.get();
assertNotNull(nodeAddedEvent);
- //TODO assertEquals("", newNode.getNodeName(), nodeAddedEvent.getProperty(NodeAddedTrigger.NodeAddedEvent.NODE_NAME));
+ List<String> nodeNames = (List<String>) nodeAddedEvent.getProperty(NodeAddedTrigger.NodeAddedEvent.NODE_NAMES);
+ assertTrue("Newly added node was not present in event message",
+ nodeNames.contains(newNode.getNodeName()));
}
}