You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Eric DE MAULDE (JIRA)" <ji...@apache.org> on 2009/01/18 02:32:59 UTC
[jira] Created: (OFBIZ-2128) product image auto scale
product image auto scale
-------------------------
Key: OFBIZ-2128
URL: https://issues.apache.org/jira/browse/OFBIZ-2128
Project: OFBiz
Issue Type: New Feature
Components: product
Affects Versions: SVN trunk
Environment: Linux Debian, OFBiz trunk rev. 735315
Reporter: Eric DE MAULDE
Fix For: SVN trunk
This change allows to auto-scale product image when a user upload an original image.
The original image is saved into OFBiz.
Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml
When an user uploads an original image, OFBiz resizes this image and creates each related file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2128) product image auto scale
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux updated OFBIZ-2128:
-----------------------------------
Attachment: productImageAutoScale.patch
Hi Eric,
In this new patch I have added a block of lines (near ImageTransform.java[267]) wich allows a dynamic creation of the framework/images/webapp/images/products sub-directories. I did not commit yet because I 'm still to figure out if we should onot introduce rather an external API for such tool. BTW Imagero is not usable because of licence aspects, it's clearly a commercial product.
So the candidates seem to be so far
# [PMIW: Poor Man's Imaging Wrapper|http://www.mullassery.com/software/PMIW/index.jsp]
# [Java Advanced Imaging (JAI) API|http://java.sun.com/javase/technologies/desktop/media/jai/] tough not sure to [its licence|https://jai.dev.java.net/jdl-jai.pdf]
Any imputs appreciated
> product image auto scale
> -------------------------
>
> Key: OFBIZ-2128
> URL: https://issues.apache.org/jira/browse/OFBIZ-2128
> Project: OFBiz
> Issue Type: New Feature
> Components: product
> Affects Versions: SVN trunk
> Environment: Linux Debian, OFBiz trunk rev. 737217
> Reporter: Eric DE MAULDE
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: productImageAutoScale.patch, productImageAutoScale.patch, screenshot-1.jpg
>
>
> This change allows to auto-scale product image when a user upload an original image.
> The original image is saved into OFBiz.
> Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml
> When an user uploads an original image, OFBiz resizes this image and creates each related file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2128) product image auto scale
Posted by "Eric DE MAULDE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667211#action_12667211 ]
Eric DE MAULDE commented on OFBIZ-2128:
---------------------------------------
In this patch, the main thing is to save and keep the original image,
in order to plan future developments and API improvement.
Indeed from an original image, we able to work any changes.
We can implement services to modify all images in one time :
add a logo, resize, cut, compress ...
The current "ImageIo.read(new File(filePath))" can't read some JPG images ?
What do think about these API :
JAI (Java Advanced Imaging from Sun http://java.sun.com/javase/technologies/desktop/media/jai/ )
Imagero (free for non-commercial use, http://reader.imagero.com/ )
> product image auto scale
> -------------------------
>
> Key: OFBIZ-2128
> URL: https://issues.apache.org/jira/browse/OFBIZ-2128
> Project: OFBiz
> Issue Type: New Feature
> Components: product
> Affects Versions: SVN trunk
> Environment: Linux Debian, OFBiz trunk rev. 737217
> Reporter: Eric DE MAULDE
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: productImageAutoScale.patch, screenshot-1.jpg
>
>
> This change allows to auto-scale product image when a user upload an original image.
> The original image is saved into OFBiz.
> Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml
> When an user uploads an original image, OFBiz resizes this image and creates each related file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (OFBIZ-2128) product image auto scale
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667241#action_12667241 ]
jacques.le.roux edited comment on OFBIZ-2128 at 1/26/09 5:32 AM:
-----------------------------------------------------------------
Hi Eric,
In this new patch I have added a block of lines (near ImageTransform.java[267]) wich allows a dynamic creation of the framework/images/webapp/images/products sub-directories. I did not commit yet because I have still to figure out if we should not introduce rather an external API. BTW Imagero is not usable because of licence aspect, it's clearly a commercial product.
So the candidates seem to be so far
# [PMIW: Poor Man's Imaging Wrapper|http://www.mullassery.com/software/PMIW/index.jsp]
# [Java Advanced Imaging (JAI) API|http://java.sun.com/javase/technologies/desktop/media/jai/] tough not sure to [its licence|https://jai.dev.java.net/jdl-jai.pdf]
Any imputs appreciated
was (Author: jacques.le.roux):
Hi Eric,
In this new patch I have added a block of lines (near ImageTransform.java[267]) wich allows a dynamic creation of the framework/images/webapp/images/products sub-directories. I did not commit yet because I 'm still to figure out if we should onot introduce rather an external API for such tool. BTW Imagero is not usable because of licence aspects, it's clearly a commercial product.
So the candidates seem to be so far
# [PMIW: Poor Man's Imaging Wrapper|http://www.mullassery.com/software/PMIW/index.jsp]
# [Java Advanced Imaging (JAI) API|http://java.sun.com/javase/technologies/desktop/media/jai/] tough not sure to [its licence|https://jai.dev.java.net/jdl-jai.pdf]
Any imputs appreciated
> product image auto scale
> -------------------------
>
> Key: OFBIZ-2128
> URL: https://issues.apache.org/jira/browse/OFBIZ-2128
> Project: OFBiz
> Issue Type: New Feature
> Components: product
> Affects Versions: SVN trunk
> Environment: Linux Debian, OFBiz trunk rev. 737217
> Reporter: Eric DE MAULDE
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: productImageAutoScale.patch, productImageAutoScale.patch, screenshot-1.jpg
>
>
> This change allows to auto-scale product image when a user upload an original image.
> The original image is saved into OFBiz.
> Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml
> When an user uploads an original image, OFBiz resizes this image and creates each related file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-2128) product image auto scale
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux closed OFBIZ-2128.
----------------------------------
Resolution: Fixed
Thanks Eric,
Your patch is in trunk, revision: 739042 .
I finally decided to commit as it works well. We will see later if we find enough manpower to extend using a generic API
> product image auto scale
> -------------------------
>
> Key: OFBIZ-2128
> URL: https://issues.apache.org/jira/browse/OFBIZ-2128
> Project: OFBiz
> Issue Type: New Feature
> Components: product
> Affects Versions: SVN trunk
> Environment: Linux Debian, OFBiz trunk rev. 737217
> Reporter: Eric DE MAULDE
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: productImageAutoScale.patch, productImageAutoScale.patch, screenshot-1.jpg
>
>
> This change allows to auto-scale product image when a user upload an original image.
> The original image is saved into OFBiz.
> Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml
> When an user uploads an original image, OFBiz resizes this image and creates each related file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2128) product image auto scale
Posted by "Eric DE MAULDE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric DE MAULDE updated OFBIZ-2128:
----------------------------------
Attachment: productImageAutoScale.patch
patch to implement product image auto scale
into product content
this patch is well formated
(manually for the time being)
> product image auto scale
> -------------------------
>
> Key: OFBIZ-2128
> URL: https://issues.apache.org/jira/browse/OFBIZ-2128
> Project: OFBiz
> Issue Type: New Feature
> Components: product
> Affects Versions: SVN trunk
> Environment: Linux Debian, OFBiz trunk rev. 735985
> Reporter: Eric DE MAULDE
> Fix For: SVN trunk
>
> Attachments: productImageAutoScale.patch, screenshot-1.jpg
>
>
> This change allows to auto-scale product image when a user upload an original image.
> The original image is saved into OFBiz.
> Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml
> When an user uploads an original image, OFBiz resizes this image and creates each related file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2128) product image auto scale
Posted by "Eric DE MAULDE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666905#action_12666905 ]
Eric DE MAULDE commented on OFBIZ-2128:
---------------------------------------
This patch doesn't contains new image directories
I wasn't abble to add these directories into my patch (with a diff)
Because my configuration can't save a file if its directory isn't created,
we have to create :
framework/images/webapp/images/products/original
framework/images/webapp/images/products/additional/small
framework/images/webapp/images/products/additional/medium
framework/images/webapp/images/products/additional/large
framework/images/webapp/images/products/additional/detail
Thanks for your comprehension
Eric
> product image auto scale
> -------------------------
>
> Key: OFBIZ-2128
> URL: https://issues.apache.org/jira/browse/OFBIZ-2128
> Project: OFBiz
> Issue Type: New Feature
> Components: product
> Affects Versions: SVN trunk
> Environment: Linux Debian, OFBiz trunk rev. 735985
> Reporter: Eric DE MAULDE
> Fix For: SVN trunk
>
> Attachments: productImageAutoScale.patch, screenshot-1.jpg
>
>
> This change allows to auto-scale product image when a user upload an original image.
> The original image is saved into OFBiz.
> Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml
> When an user uploads an original image, OFBiz resizes this image and creates each related file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2128) product image auto scale
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667443#action_12667443 ]
Jacques Le Roux commented on OFBIZ-2128:
----------------------------------------
So the only issues would be not optimal resize resolution, some JPG not working and no PNG at all ?
> product image auto scale
> -------------------------
>
> Key: OFBIZ-2128
> URL: https://issues.apache.org/jira/browse/OFBIZ-2128
> Project: OFBiz
> Issue Type: New Feature
> Components: product
> Affects Versions: SVN trunk
> Environment: Linux Debian, OFBiz trunk rev. 737217
> Reporter: Eric DE MAULDE
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: productImageAutoScale.patch, productImageAutoScale.patch, screenshot-1.jpg
>
>
> This change allows to auto-scale product image when a user upload an original image.
> The original image is saved into OFBiz.
> Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml
> When an user uploads an original image, OFBiz resizes this image and creates each related file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2128) product image auto scale
Posted by "Eric DE MAULDE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666227#action_12666227 ]
Eric DE MAULDE commented on OFBIZ-2128:
---------------------------------------
I modified my main class
I'm finishing to implement this function to product additional view
> product image auto scale
> -------------------------
>
> Key: OFBIZ-2128
> URL: https://issues.apache.org/jira/browse/OFBIZ-2128
> Project: OFBiz
> Issue Type: New Feature
> Components: product
> Affects Versions: SVN trunk
> Environment: Linux Debian, OFBiz trunk rev. 735985
> Reporter: Eric DE MAULDE
> Fix For: SVN trunk
>
> Attachments: screenshot-1.jpg
>
>
> This change allows to auto-scale product image when a user upload an original image.
> The original image is saved into OFBiz.
> Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml
> When an user uploads an original image, OFBiz resizes this image and creates each related file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2128) product image auto scale
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667243#action_12667243 ]
Jacques Le Roux commented on OFBIZ-2128:
----------------------------------------
Finally JAI seems OK since it uses PMIW which is Apache licenced and used in Jakarta Image-Taglib Paul Piper said (but I will check I have already seen something which seamed OK but was not : Selenium). Anyway if it's OK it seems easier to use PMIW for our current needs...
> product image auto scale
> -------------------------
>
> Key: OFBIZ-2128
> URL: https://issues.apache.org/jira/browse/OFBIZ-2128
> Project: OFBiz
> Issue Type: New Feature
> Components: product
> Affects Versions: SVN trunk
> Environment: Linux Debian, OFBiz trunk rev. 737217
> Reporter: Eric DE MAULDE
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: productImageAutoScale.patch, productImageAutoScale.patch, screenshot-1.jpg
>
>
> This change allows to auto-scale product image when a user upload an original image.
> The original image is saved into OFBiz.
> Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml
> When an user uploads an original image, OFBiz resizes this image and creates each related file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (OFBIZ-2128) product image auto scale
Posted by "Eric DE MAULDE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric DE MAULDE resolved OFBIZ-2128.
-----------------------------------
Resolution: Fixed
Patch done
> product image auto scale
> -------------------------
>
> Key: OFBIZ-2128
> URL: https://issues.apache.org/jira/browse/OFBIZ-2128
> Project: OFBiz
> Issue Type: New Feature
> Components: product
> Affects Versions: SVN trunk
> Environment: Linux Debian, OFBiz trunk rev. 735315
> Reporter: Eric DE MAULDE
> Fix For: SVN trunk
>
> Attachments: ProductImageAutoScale.patch, screenshot-1.jpg
>
>
> This change allows to auto-scale product image when a user upload an original image.
> The original image is saved into OFBiz.
> Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml
> When an user uploads an original image, OFBiz resizes this image and creates each related file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2128) product image auto scale
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux updated OFBIZ-2128:
-----------------------------------
Attachment: productImageAutoScale.patch
Oops, I forgot new files :/
> product image auto scale
> -------------------------
>
> Key: OFBIZ-2128
> URL: https://issues.apache.org/jira/browse/OFBIZ-2128
> Project: OFBiz
> Issue Type: New Feature
> Components: product
> Affects Versions: SVN trunk
> Environment: Linux Debian, OFBiz trunk rev. 737217
> Reporter: Eric DE MAULDE
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: productImageAutoScale.patch, productImageAutoScale.patch, productImageAutoScale.patch, productImageAutoScale.patch, screenshot-1.jpg
>
>
> This change allows to auto-scale product image when a user upload an original image.
> The original image is saved into OFBiz.
> Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml
> When an user uploads an original image, OFBiz resizes this image and creates each related file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2128) product image auto scale
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12664941#action_12664941 ]
Jacques Le Roux commented on OFBIZ-2128:
----------------------------------------
Hi Eric,
Some issues with your patch
* I guess you use a local repository because you have a revision 7215 number
* I don't know how you generated your patch but I get this error
D:\workspace\ofbizRun>patch -p0 0<ProductImageAutoScale.patch
can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|´╗┐=== entitymodel.xml
|==================================================================
|--- entitymodel.xml (applications/product/entitydef/entitymodel.xml) (revision 7215)
|+++ entitymodel.xml (applications/product/entitydef/entitymodel.xml) (revision 7215)
Please (re)read http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices
Thanks
--------------------------
File to patch: EOF
> product image auto scale
> -------------------------
>
> Key: OFBIZ-2128
> URL: https://issues.apache.org/jira/browse/OFBIZ-2128
> Project: OFBiz
> Issue Type: New Feature
> Components: product
> Affects Versions: SVN trunk
> Environment: Linux Debian, OFBiz trunk rev. 735315
> Reporter: Eric DE MAULDE
> Fix For: SVN trunk
>
> Attachments: ProductImageAutoScale.patch, screenshot-1.jpg
>
>
> This change allows to auto-scale product image when a user upload an original image.
> The original image is saved into OFBiz.
> Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml
> When an user uploads an original image, OFBiz resizes this image and creates each related file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2128) product image auto scale
Posted by "Eric DE MAULDE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667389#action_12667389 ]
Eric DE MAULDE commented on OFBIZ-2128:
---------------------------------------
Of course, I works with this service, even if the resize resolution isn't excellent.
If we save original images, one day with a better API we can resize again by example.
I'm not a comitter to decide ! Just I have suggested a solution
> product image auto scale
> -------------------------
>
> Key: OFBIZ-2128
> URL: https://issues.apache.org/jira/browse/OFBIZ-2128
> Project: OFBiz
> Issue Type: New Feature
> Components: product
> Affects Versions: SVN trunk
> Environment: Linux Debian, OFBiz trunk rev. 737217
> Reporter: Eric DE MAULDE
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: productImageAutoScale.patch, productImageAutoScale.patch, screenshot-1.jpg
>
>
> This change allows to auto-scale product image when a user upload an original image.
> The original image is saved into OFBiz.
> Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml
> When an user uploads an original image, OFBiz resizes this image and creates each related file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2128) product image auto scale
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666750#action_12666750 ]
Jacques Le Roux commented on OFBIZ-2128:
----------------------------------------
Hi Eric,
Should I review or wait ?
> product image auto scale
> -------------------------
>
> Key: OFBIZ-2128
> URL: https://issues.apache.org/jira/browse/OFBIZ-2128
> Project: OFBiz
> Issue Type: New Feature
> Components: product
> Affects Versions: SVN trunk
> Environment: Linux Debian, OFBiz trunk rev. 735985
> Reporter: Eric DE MAULDE
> Fix For: SVN trunk
>
> Attachments: screenshot-1.jpg
>
>
> This change allows to auto-scale product image when a user upload an original image.
> The original image is saved into OFBiz.
> Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml
> When an user uploads an original image, OFBiz resizes this image and creates each related file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2128) product image auto scale
Posted by "Eric DE MAULDE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric DE MAULDE updated OFBIZ-2128:
----------------------------------
Attachment: (was: productImageAutoScale.patch)
> product image auto scale
> -------------------------
>
> Key: OFBIZ-2128
> URL: https://issues.apache.org/jira/browse/OFBIZ-2128
> Project: OFBiz
> Issue Type: New Feature
> Components: product
> Affects Versions: SVN trunk
> Environment: Linux Debian, OFBiz trunk rev. 735985
> Reporter: Eric DE MAULDE
> Fix For: SVN trunk
>
> Attachments: screenshot-1.jpg
>
>
> This change allows to auto-scale product image when a user upload an original image.
> The original image is saved into OFBiz.
> Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml
> When an user uploads an original image, OFBiz resizes this image and creates each related file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2128) product image auto scale
Posted by "Eric DE MAULDE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric DE MAULDE updated OFBIZ-2128:
----------------------------------
Attachment: ProductImageAutoScale.patch
Patch to implement product image auto scale
when an user uploads an original image
> product image auto scale
> -------------------------
>
> Key: OFBIZ-2128
> URL: https://issues.apache.org/jira/browse/OFBIZ-2128
> Project: OFBiz
> Issue Type: New Feature
> Components: product
> Affects Versions: SVN trunk
> Environment: Linux Debian, OFBiz trunk rev. 735315
> Reporter: Eric DE MAULDE
> Fix For: SVN trunk
>
> Attachments: ProductImageAutoScale.patch, screenshot-1.jpg
>
>
> This change allows to auto-scale product image when a user upload an original image.
> The original image is saved into OFBiz.
> Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml
> When an user uploads an original image, OFBiz resizes this image and creates each related file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-2128) product image auto scale
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux reassigned OFBIZ-2128:
--------------------------------------
Assignee: Jacques Le Roux
> product image auto scale
> -------------------------
>
> Key: OFBIZ-2128
> URL: https://issues.apache.org/jira/browse/OFBIZ-2128
> Project: OFBiz
> Issue Type: New Feature
> Components: product
> Affects Versions: SVN trunk
> Environment: Linux Debian, OFBiz trunk rev. 737217
> Reporter: Eric DE MAULDE
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: productImageAutoScale.patch, screenshot-1.jpg
>
>
> This change allows to auto-scale product image when a user upload an original image.
> The original image is saved into OFBiz.
> Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml
> When an user uploads an original image, OFBiz resizes this image and creates each related file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2128) product image auto scale
Posted by "Eric DE MAULDE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric DE MAULDE updated OFBIZ-2128:
----------------------------------
Environment: Linux Debian, OFBiz trunk rev. 737217 (was: Linux Debian, OFBiz trunk rev. 735985)
> product image auto scale
> -------------------------
>
> Key: OFBIZ-2128
> URL: https://issues.apache.org/jira/browse/OFBIZ-2128
> Project: OFBiz
> Issue Type: New Feature
> Components: product
> Affects Versions: SVN trunk
> Environment: Linux Debian, OFBiz trunk rev. 737217
> Reporter: Eric DE MAULDE
> Fix For: SVN trunk
>
> Attachments: productImageAutoScale.patch, screenshot-1.jpg
>
>
> This change allows to auto-scale product image when a user upload an original image.
> The original image is saved into OFBiz.
> Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml
> When an user uploads an original image, OFBiz resizes this image and creates each related file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2128) product image auto scale
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux updated OFBIZ-2128:
-----------------------------------
Attachment: (was: productImageAutoScale.patch)
> product image auto scale
> -------------------------
>
> Key: OFBIZ-2128
> URL: https://issues.apache.org/jira/browse/OFBIZ-2128
> Project: OFBiz
> Issue Type: New Feature
> Components: product
> Affects Versions: SVN trunk
> Environment: Linux Debian, OFBiz trunk rev. 737217
> Reporter: Eric DE MAULDE
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: productImageAutoScale.patch, screenshot-1.jpg
>
>
> This change allows to auto-scale product image when a user upload an original image.
> The original image is saved into OFBiz.
> Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml
> When an user uploads an original image, OFBiz resizes this image and creates each related file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2128) product image auto scale
Posted by "Eric DE MAULDE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667485#action_12667485 ]
Eric DE MAULDE commented on OFBIZ-2128:
---------------------------------------
JPG Images from one supplier can't be read with ImageIO.read, as all tried PNG images.
However documentation says these formats are compatible (http://java.sun.com/j2se/1.5.0/docs/api/javax/imageio/package-summary.html)
By example resizing resolution is a bit better with Gimp
It would be better to try with another API ?
> product image auto scale
> -------------------------
>
> Key: OFBIZ-2128
> URL: https://issues.apache.org/jira/browse/OFBIZ-2128
> Project: OFBiz
> Issue Type: New Feature
> Components: product
> Affects Versions: SVN trunk
> Environment: Linux Debian, OFBiz trunk rev. 737217
> Reporter: Eric DE MAULDE
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: productImageAutoScale.patch, productImageAutoScale.patch, screenshot-1.jpg
>
>
> This change allows to auto-scale product image when a user upload an original image.
> The original image is saved into OFBiz.
> Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml
> When an user uploads an original image, OFBiz resizes this image and creates each related file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (OFBIZ-2128) product image auto scale
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux reopened OFBIZ-2128:
------------------------------------
PLease Eric don' set the issue as Resolved or Fixed, we will do when commiting
> product image auto scale
> -------------------------
>
> Key: OFBIZ-2128
> URL: https://issues.apache.org/jira/browse/OFBIZ-2128
> Project: OFBiz
> Issue Type: New Feature
> Components: product
> Affects Versions: SVN trunk
> Environment: Linux Debian, OFBiz trunk rev. 737217
> Reporter: Eric DE MAULDE
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: productImageAutoScale.patch, screenshot-1.jpg
>
>
> This change allows to auto-scale product image when a user upload an original image.
> The original image is saved into OFBiz.
> Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml
> When an user uploads an original image, OFBiz resizes this image and creates each related file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2128) product image auto scale
Posted by "Eric DE MAULDE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric DE MAULDE updated OFBIZ-2128:
----------------------------------
Attachment: (was: ProductImageAutoScale.patch)
> product image auto scale
> -------------------------
>
> Key: OFBIZ-2128
> URL: https://issues.apache.org/jira/browse/OFBIZ-2128
> Project: OFBiz
> Issue Type: New Feature
> Components: product
> Affects Versions: SVN trunk
> Environment: Linux Debian, OFBiz trunk rev. 735985
> Reporter: Eric DE MAULDE
> Fix For: SVN trunk
>
> Attachments: screenshot-1.jpg
>
>
> This change allows to auto-scale product image when a user upload an original image.
> The original image is saved into OFBiz.
> Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml
> When an user uploads an original image, OFBiz resizes this image and creates each related file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2128) product image auto scale
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667244#action_12667244 ]
Jacques Le Roux commented on OFBIZ-2128:
----------------------------------------
Clearly PMIW is ok : http://jakarta.apache.org/taglibs/
> product image auto scale
> -------------------------
>
> Key: OFBIZ-2128
> URL: https://issues.apache.org/jira/browse/OFBIZ-2128
> Project: OFBiz
> Issue Type: New Feature
> Components: product
> Affects Versions: SVN trunk
> Environment: Linux Debian, OFBiz trunk rev. 737217
> Reporter: Eric DE MAULDE
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: productImageAutoScale.patch, productImageAutoScale.patch, screenshot-1.jpg
>
>
> This change allows to auto-scale product image when a user upload an original image.
> The original image is saved into OFBiz.
> Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml
> When an user uploads an original image, OFBiz resizes this image and creates each related file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2128) product image auto scale
Posted by "Eric DE MAULDE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric DE MAULDE updated OFBIZ-2128:
----------------------------------
Attachment: screenshot-1.jpg
Product Content : Ovveride Simple Fields
> product image auto scale
> -------------------------
>
> Key: OFBIZ-2128
> URL: https://issues.apache.org/jira/browse/OFBIZ-2128
> Project: OFBiz
> Issue Type: New Feature
> Components: product
> Affects Versions: SVN trunk
> Environment: Linux Debian, OFBiz trunk rev. 735315
> Reporter: Eric DE MAULDE
> Fix For: SVN trunk
>
> Attachments: screenshot-1.jpg
>
>
> This change allows to auto-scale product image when a user upload an original image.
> The original image is saved into OFBiz.
> Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml
> When an user uploads an original image, OFBiz resizes this image and creates each related file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2128) product image auto scale
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux updated OFBIZ-2128:
-----------------------------------
Attachment: productImageAutoScale.patch
New replacing patch, return in block added was not correct for a service
> product image auto scale
> -------------------------
>
> Key: OFBIZ-2128
> URL: https://issues.apache.org/jira/browse/OFBIZ-2128
> Project: OFBiz
> Issue Type: New Feature
> Components: product
> Affects Versions: SVN trunk
> Environment: Linux Debian, OFBiz trunk rev. 737217
> Reporter: Eric DE MAULDE
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: productImageAutoScale.patch, productImageAutoScale.patch, productImageAutoScale.patch, screenshot-1.jpg
>
>
> This change allows to auto-scale product image when a user upload an original image.
> The original image is saved into OFBiz.
> Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml
> When an user uploads an original image, OFBiz resizes this image and creates each related file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2128) product image auto scale
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667242#action_12667242 ]
Jacques Le Roux commented on OFBIZ-2128:
----------------------------------------
Note also that we should be able to deal with PNG files at least...
> product image auto scale
> -------------------------
>
> Key: OFBIZ-2128
> URL: https://issues.apache.org/jira/browse/OFBIZ-2128
> Project: OFBiz
> Issue Type: New Feature
> Components: product
> Affects Versions: SVN trunk
> Environment: Linux Debian, OFBiz trunk rev. 737217
> Reporter: Eric DE MAULDE
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: productImageAutoScale.patch, productImageAutoScale.patch, screenshot-1.jpg
>
>
> This change allows to auto-scale product image when a user upload an original image.
> The original image is saved into OFBiz.
> Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml
> When an user uploads an original image, OFBiz resizes this image and creates each related file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2128) product image auto scale
Posted by "Eric DE MAULDE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric DE MAULDE updated OFBIZ-2128:
----------------------------------
Attachment: productImageAutoScale.patch
Patch to automatic resize original Image in product content.
It saves the original image.
It resizes the original image into small, medium, large and detail size,
related to the ImageProperties.xml file.
In this file, we can define the final image extension.
Same when an additionnal product view is added,
but in this case, it doesn't save the related content of different sizes
It doesn't work with some JPEG image. I don't kinow why !
It doesn't write an errror message in product content screen,
if there has been an error during scalling (just in log)
> product image auto scale
> -------------------------
>
> Key: OFBIZ-2128
> URL: https://issues.apache.org/jira/browse/OFBIZ-2128
> Project: OFBiz
> Issue Type: New Feature
> Components: product
> Affects Versions: SVN trunk
> Environment: Linux Debian, OFBiz trunk rev. 735985
> Reporter: Eric DE MAULDE
> Fix For: SVN trunk
>
> Attachments: productImageAutoScale.patch, screenshot-1.jpg
>
>
> This change allows to auto-scale product image when a user upload an original image.
> The original image is saved into OFBiz.
> Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml
> When an user uploads an original image, OFBiz resizes this image and creates each related file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2128) product image auto scale
Posted by "Eric DE MAULDE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric DE MAULDE updated OFBIZ-2128:
----------------------------------
Environment: Linux Debian, OFBiz trunk rev. 735985 (was: Linux Debian, OFBiz trunk rev. 735315)
> product image auto scale
> -------------------------
>
> Key: OFBIZ-2128
> URL: https://issues.apache.org/jira/browse/OFBIZ-2128
> Project: OFBiz
> Issue Type: New Feature
> Components: product
> Affects Versions: SVN trunk
> Environment: Linux Debian, OFBiz trunk rev. 735985
> Reporter: Eric DE MAULDE
> Fix For: SVN trunk
>
> Attachments: screenshot-1.jpg
>
>
> This change allows to auto-scale product image when a user upload an original image.
> The original image is saved into OFBiz.
> Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml
> When an user uploads an original image, OFBiz resizes this image and creates each related file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2128) product image auto scale
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux updated OFBIZ-2128:
-----------------------------------
Priority: Trivial (was: Major)
> product image auto scale
> -------------------------
>
> Key: OFBIZ-2128
> URL: https://issues.apache.org/jira/browse/OFBIZ-2128
> Project: OFBiz
> Issue Type: New Feature
> Components: product
> Affects Versions: SVN trunk
> Environment: Linux Debian, OFBiz trunk rev. 737217
> Reporter: Eric DE MAULDE
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: productImageAutoScale.patch, screenshot-1.jpg
>
>
> This change allows to auto-scale product image when a user upload an original image.
> The original image is saved into OFBiz.
> Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml
> When an user uploads an original image, OFBiz resizes this image and creates each related file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2128) product image auto scale
Posted by "Eric DE MAULDE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667295#action_12667295 ]
Eric DE MAULDE commented on OFBIZ-2128:
---------------------------------------
I don't have a lot of experience with Java and OFBiz.
Any new ideas and means are welcome.
Sure, it's more efficient to implement an API.
the main idea is to prepare and implement images automation,
from the original images.
Thanks Jacques to improve this service
> product image auto scale
> -------------------------
>
> Key: OFBIZ-2128
> URL: https://issues.apache.org/jira/browse/OFBIZ-2128
> Project: OFBiz
> Issue Type: New Feature
> Components: product
> Affects Versions: SVN trunk
> Environment: Linux Debian, OFBiz trunk rev. 737217
> Reporter: Eric DE MAULDE
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: productImageAutoScale.patch, productImageAutoScale.patch, screenshot-1.jpg
>
>
> This change allows to auto-scale product image when a user upload an original image.
> The original image is saved into OFBiz.
> Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml
> When an user uploads an original image, OFBiz resizes this image and creates each related file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2128) product image auto scale
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux updated OFBIZ-2128:
-----------------------------------
Attachment: productImageAutoScale.patch
Finally a correct patch ? :)
> product image auto scale
> -------------------------
>
> Key: OFBIZ-2128
> URL: https://issues.apache.org/jira/browse/OFBIZ-2128
> Project: OFBiz
> Issue Type: New Feature
> Components: product
> Affects Versions: SVN trunk
> Environment: Linux Debian, OFBiz trunk rev. 737217
> Reporter: Eric DE MAULDE
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: productImageAutoScale.patch, productImageAutoScale.patch, screenshot-1.jpg
>
>
> This change allows to auto-scale product image when a user upload an original image.
> The original image is saved into OFBiz.
> Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml
> When an user uploads an original image, OFBiz resizes this image and creates each related file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2128) product image auto scale
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667368#action_12667368 ]
Jacques Le Roux commented on OFBIZ-2128:
----------------------------------------
Eric,
What are the problems you face so far ? Because it's better to have something that works, even incomplete, than nothing, maybe we could already commit as is if the issues are not to annoying...
> product image auto scale
> -------------------------
>
> Key: OFBIZ-2128
> URL: https://issues.apache.org/jira/browse/OFBIZ-2128
> Project: OFBiz
> Issue Type: New Feature
> Components: product
> Affects Versions: SVN trunk
> Environment: Linux Debian, OFBiz trunk rev. 737217
> Reporter: Eric DE MAULDE
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: productImageAutoScale.patch, productImageAutoScale.patch, screenshot-1.jpg
>
>
> This change allows to auto-scale product image when a user upload an original image.
> The original image is saved into OFBiz.
> Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml
> When an user uploads an original image, OFBiz resizes this image and creates each related file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.