You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by cvlchinet <gi...@git.apache.org> on 2014/11/27 00:31:56 UTC
[GitHub] thrift pull request: THRIFT-2854 Go Struct writer and reader loose...
GitHub user cvlchinet opened a pull request:
https://github.com/apache/thrift/pull/291
THRIFT-2854 Go Struct writer and reader looses important error information
This PR fixes https://issues.apache.org/jira/browse/THRIFT-2854.
The included test will cover the complete client error handling code except the check for the Sequence ID. (unless I miss something)
I will submit a follow up PR to test the error handling for the Sequence ID too once this PR has been merged.
The covered code makes up the majority of the server error handling code too.
And yes.. it was not fun too code the test.. :P
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cvlchinet/thrift go-struct-error
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/291.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #291
----
commit 18d2d2b58a1dd3ed256fe189bc9b8a5a77f5bcc5
Author: Chi Vinh Le <cv...@chinet.info>
Date: 2014-11-26T23:19:17Z
Fixes error reporting in go generator
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-2854 Go Struct writer and reader loose...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/291
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---