[GitHub] [maven] dehasi commented on a change in pull request #347: [MNG-6802] Fix bug in FileProfileActivator

[GitBox <gi...@apache.org>]

dehasi commented on a change in pull request #347:
URL: https://github.com/apache/maven/pull/347#discussion_r607321958



##########
File path: maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java
##########
@@ -88,8 +91,10 @@
 import org.apache.maven.model.resolution.WorkspaceModelResolver;
 import org.apache.maven.model.superpom.SuperPomProvider;
 import org.apache.maven.model.validation.ModelValidator;
+import org.codehaus.plexus.interpolation.InterpolationException;
 import org.codehaus.plexus.interpolation.MapBasedValueSource;
 import org.codehaus.plexus.interpolation.StringSearchInterpolator;
+import org.codehaus.plexus.util.StringUtils;

Review comment:
       @elharo I added my own `private static isNotEmpty` method. I want to avoid `lang3` vs `plexus` discussion because it's out of the scope of this PR. Can we proceed with this solution?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org